• KaiGai Kohei's avatar
    [JFFS2] Tidy up fix for ACL/permissions problem. · cfc8dc6f
    KaiGai Kohei authored
    [In commit 9ed437c5 we fixed a problem 
    with standard permissions on newly-created inodes, when POSIX ACLs are 
    enabled. This cleans it up...]
    The attached patch separate jffs2_init_acl() into two parts.
    The one is jffs2_init_acl_pre() called from jffs2_new_inode().
    It compute ACL oriented inode->i_mode bits, and allocate in-memory ACL
    objects associated with the new inode just before when inode meta
    infomation is written to the medium.
    The other is jffs2_init_acl_post() called from jffs2_symlink(),
    jffs2_mkdir(), jffs2_mknod() and jffs2_do_create().
    It actually writes in-memory ACL objects into the medium next to
    the success of writing meta-information.
    In the current implementation, we have to write a same inode meta
    infomation twice when inode->i_mode is updated by the default ACL.
    However, we can avoid the behavior by putting an updated i_mode
    before it is written at first, as jffs2_init_acl_pre() doing.
    Signed-off-by: default avatarKaiGai Kohei <kaigai@ak.jp.nec.com>
    Signed-off-by: default avatarDavid Woodhouse <dwmw2@infradead.org>
write.c 20.9 KB