• Andrew Morton's avatar
    [PATCH] binfmt_flat: don't check for EMFILE · df88912a
    Andrew Morton authored
    Bernd Schmidt points out that binfmt_flat is now leaving the exec file open
    while the application runs.  This offsets all the application's fd numbers.
    We should have closed the file within exec(), not at exit()-time.
    But there doesn't seem to be a lot of point in doing all this just to avoid
    going over RLIMIT_NOFILE by one fd for a few microseconds.  So take the EMFILE
    checking out again.  This will cause binfmt_flat to again fail LTP's
    exec-should-return-EMFILE-when-fdtable-is-full test.  That test appears to be
    wrong anyway - Open Group specs say nothing about exec() returning EMFILE.
    Cc: Bernd Schmidt <bernd.schmidt@analog.com>
    Cc: Greg Ungerer <gerg@uclinux.org>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
binfmt_flat.c 26 KB