Skip to content
  • Andrew Morton's avatar
    [PATCH] git-netdev-all: s2io warning fix · 26b7625c
    Andrew Morton authored
    
    
    drivers/net/s2io.c: In function `s2io_txdl_getskb':
    drivers/net/s2io.c:2023: warning: cast from pointer to integer of different size
    drivers/net/s2io.c: In function `s2io_open':
    drivers/net/s2io.c:3325: warning: long long unsigned int format, u64 arg (arg 3)
    drivers/net/s2io.c:3333: warning: long long unsigned int format, u64 arg (arg 3)
    drivers/net/s2io.c: In function `s2io_eeprom_test':
    drivers/net/s2io.c:4749: warning: long long unsigned int format, long unsigned int arg (arg 3)
    drivers/net/s2io.c:4749: warning: long long unsigned int format, u64 arg (arg 4)
    drivers/net/s2io.c:4768: warning: long long unsigned int format, long unsigned int arg (arg 3)
    drivers/net/s2io.c:4768: warning: long long unsigned int format, u64 arg (arg 4)
    
    I had to update this patch because more warnings have just appeared.
    
    You cannot print a u64 with %l or %ll.  You do not know what type the
    architecture is using.  It must be cast to a type which matches the printf
    control string - unsigned long long.
    
    The patch also fixes some overly-long strings.  Please try to keep the code
    looking neat in an 80-col window.
    
    Cc: Jeff Garzik <jgarzik@pobox.com>
    Cc: Ananda Raju <Ananda.Raju@neterion.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
    26b7625c