Commit 2d93913e authored by Colin Ian King's avatar Colin Ian King Committed by Herbert Xu

crypto: chelsio - don't leak information from the stack to userspace

The structure crypto_info contains fields that are not initialized and
only .version is set.  The copy_to_user call is hence leaking information
from the stack to userspace which must be avoided. Fix this by zero'ing
all the unused fields.

Detected by CoverityScan, CID#1467421 ("Uninitialized scalar variable")

Fixes: a0894394 ("crypto: chtls - Register chtls with net tls")
Signed-off-by: 's avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: 's avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 3d8ccf9f
......@@ -441,7 +441,7 @@ static int chtls_uld_rx_handler(void *handle, const __be64 *rsp,
static int do_chtls_getsockopt(struct sock *sk, char __user *optval,
int __user *optlen)
{
struct tls_crypto_info crypto_info;
struct tls_crypto_info crypto_info = { 0 };
crypto_info.version = TLS_1_2_VERSION;
if (copy_to_user(optval, &crypto_info, sizeof(struct tls_crypto_info)))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment