Commit 32a8df4e authored by Yuyang Du's avatar Yuyang Du Committed by Ingo Molnar

sched: Fix odd values in effective_load() calculations

In effective_load, we have (long w * unsigned long tg->shares) / long W,
when w is negative, it is cast to unsigned long and hence the product is
insanely large. Fix this by casting tg->shares to long.
Reported-by: default avatarSasha Levin <>
Signed-off-by: default avatarYuyang Du <>
Signed-off-by: default avatarPeter Zijlstra (Intel) <>
Cc: Dave Jones <>
Cc: Andrey Ryabinin <>
Cc: Linus Torvalds <>
Link: default avatarIngo Molnar <>
parent 536ebe9c
......@@ -4424,7 +4424,7 @@ static long effective_load(struct task_group *tg, int cpu, long wl, long wg)
* wl = S * s'_i; see (2)
if (W > 0 && w < W)
wl = (w * tg->shares) / W;
wl = (w * (long)tg->shares) / W;
wl = tg->shares;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment