Commit 4eff96dd authored by Jan Kara's avatar Jan Kara Committed by Linus Torvalds

writeback: put unused inodes to LRU after writeback completion

Commit 169ebd90 ("writeback: Avoid iput() from flusher thread")
removed iget-iput pair from inode writeback.  As a side effect, inodes
that are dirty during iput_final() call won't be ever added to inode LRU
(iput_final() doesn't add dirty inodes to LRU and later when the inode
is cleaned there's noone to add the inode there).  Thus inodes are
effectively unreclaimable until someone looks them up again.

The practical effect of this bug is limited by the fact that inodes are
pinned by a dentry for long enough that the inode gets cleaned.  But
still the bug can have nasty consequences leading up to OOM conditions
under certain circumstances.  Following can easily reproduce the

  for (( i = 0; i < 1000; i++ )); do
    mkdir $i
    for (( j = 0; j < 1000; j++ )); do
      touch $i/$j
      echo 2 > /proc/sys/vm/drop_caches

then one needs to run 'sync; ls -lR' to make inodes reclaimable again.

We fix the issue by inserting unused clean inodes into the LRU after
writeback finishes in inode_sync_complete().
Signed-off-by: default avatarJan Kara <>
Reported-by: default avatarOGAWA Hirofumi <>
Cc: Al Viro <>
Cc: OGAWA Hirofumi <>
Cc: Wu Fengguang <>
Cc: Dave Chinner <>
Cc: <>		[3.5+]
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 50694c28
......@@ -228,6 +228,8 @@ static void requeue_io(struct inode *inode, struct bdi_writeback *wb)
static void inode_sync_complete(struct inode *inode)
inode->i_state &= ~I_SYNC;
/* If inode is clean an unused, put it into LRU now... */
/* Waiters must see I_SYNC cleared before being woken up */
wake_up_bit(&inode->i_state, __I_SYNC);
......@@ -408,6 +408,19 @@ static void inode_lru_list_add(struct inode *inode)
* Add inode to LRU if needed (inode is unused and clean).
* Needs inode->i_lock held.
void inode_add_lru(struct inode *inode)
if (!(inode->i_state & (I_DIRTY | I_SYNC | I_FREEING | I_WILL_FREE)) &&
!atomic_read(&inode->i_count) && inode->i_sb->s_flags & MS_ACTIVE)
static void inode_lru_list_del(struct inode *inode)
......@@ -1390,8 +1403,7 @@ static void iput_final(struct inode *inode)
if (!drop && (sb->s_flags & MS_ACTIVE)) {
inode->i_state |= I_REFERENCED;
if (!(inode->i_state & (I_DIRTY|I_SYNC)))
......@@ -110,6 +110,7 @@ extern int open_check_o_direct(struct file *f);
* inode.c
extern spinlock_t inode_sb_list_lock;
extern void inode_add_lru(struct inode *inode);
* fs-writeback.c
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment