Commit 61e4947c authored by Lukasz Dorau's avatar Lukasz Dorau Committed by NeilBrown

md: Fix skipping recovery for read-only arrays.

        commit 7ceb17e8
        md: Allow devices to be re-added to a read-only array.

spares are activated on a read-only array. In case of raid1 and raid10
personalities it causes that not-in-sync devices are marked in-sync
without checking if recovery has been finished.

If a read-only array is degraded and one of its devices is not in-sync
(because the array has been only partially recovered) recovery will be skipped.

This patch adds checking if recovery has been finished before marking a device
in-sync for raid1 and raid10 personalities. In case of raid5 personality
such condition is already present (at raid5.c:6029).

Bug was introduced in 3.10 and causes data corruption.

Signed-off-by: default avatarPawel Baldysiak <>
Signed-off-by: default avatarLukasz Dorau <>
Signed-off-by: default avatarNeilBrown <>
parent 320437af
......@@ -1479,6 +1479,7 @@ static int raid1_spare_active(struct mddev *mddev)
if (rdev
&& rdev->recovery_offset == MaxSector
&& !test_bit(Faulty, &rdev->flags)
&& !test_and_set_bit(In_sync, &rdev->flags)) {
......@@ -1782,6 +1782,7 @@ static int raid10_spare_active(struct mddev *mddev)
} else if (tmp->rdev
&& tmp->rdev->recovery_offset == MaxSector
&& !test_bit(Faulty, &tmp->rdev->flags)
&& !test_and_set_bit(In_sync, &tmp->rdev->flags)) {
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment