Commit f7312735 authored by Jeff Layton's avatar Jeff Layton

fs/fcntl: return -ESRCH in f_setown when pid/pgid can't be found

The current implementation of F_SETOWN doesn't properly vet the argument
passed in and only returns an error if INT_MIN is passed in. If the
argument doesn't specify a valid pid/pgid, then we just end up cleaning
out the file->f_owner structure.

What we really want is to only clean that out only in the case where
userland passed in an argument of 0. For anything else, we want to
return ESRCH if it doesn't refer to a valid pid.

The relevant POSIX spec page is here:

Cc: Jiri Slaby <>
Cc: zhong jiang <>
Signed-off-by: 's avatarJeff Layton <>
parent fc3dc674
......@@ -112,8 +112,9 @@ EXPORT_SYMBOL(__f_setown);
int f_setown(struct file *filp, unsigned long arg, int force)
enum pid_type type;
struct pid *pid;
int who = arg;
struct pid *pid = NULL;
int who = arg, ret = 0;
if (who < 0) {
/* avoid overflow below */
......@@ -123,12 +124,19 @@ int f_setown(struct file *filp, unsigned long arg, int force)
who = -who;
pid = find_vpid(who);
__f_setown(filp, pid, type, force);
if (who) {
pid = find_vpid(who);
if (!pid)
ret = -ESRCH;
if (!ret)
__f_setown(filp, pid, type, force);
return 0;
return ret;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment