1. 24 Nov, 2014 1 commit
  2. 02 Sep, 2013 1 commit
    • Jan-Simon Möller's avatar
      crypto: fcrypt - Fix bitoperation for compilation with clang · 06e710bd
      Jan-Simon Möller authored
      v2: Fix bug in statement as pointed out by Herbert Xu. Kudos to pipacs.
      
      Author:  PaX Team <pageexec at freemail.hu>
      ML-Post: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120507/142707.html
      URL:     http://llvm.linuxfoundation.org
      
      Merge:   Jan-Simon Möller <dl9pf at gmx.de>
      
      Description:
      
      Fix for warning:
      linux/crypto/fcrypt.c:143:47: warning: signed shift result (0x598000000) requires 36 bits to
            represent, but 'int' only has 32 bits [-Wshift-overflow]
              Z(0xef), Z(0x70), Z(0xcf), Z(0xc2), Z(0x2a), Z(0xb3), Z(0x61), Z(0xad),
                                                           ^~~~~~~
      linux/crypto/fcrypt.c:113:29: note: expanded from macro 'Z'
                                  ^  ~~
      linux/include/uapi/linux/byteorder/little_endian.h:38:53: note: expanded from macro
            '__cpu_to_be32'
                                                          ^
      linux/include/uapi/linux/swab.h:116:21: note: expanded from macro '__swab32'
              ___constant_swab32(x) :                 \
                                 ^
      linux/include/uapi/linux/swab.h:18:12: note: expanded from macro '___constant_swab32'
              (((__u32)(x) & (__u32)0x0000ff00UL) <<  8) |            \
                        ^
      
      Solution - make sure we don't exceed the 32 bit range.
       #define Z(x) cpu_to_be32(((x & 0x1f) << 27) | (x >> 5))
      Signed-off-by: 's avatarJan-Simon Möller <dl9pf@gmx.de>
      CC: pageexec@freemail.hu
      CC: llvmlinux@lists.linuxfoundation.org
      CC: behanw@converseincode.com
      CC: herbert@gondor.apana.org.au
      CC: davem@davemloft.net
      CC: linux-crypto@vger.kernel.org
      CC: linux-kernel@vger.kernel.org
      Signed-off-by: 's avatarHerbert Xu <herbert@gondor.apana.org.au>
      06e710bd
  3. 01 Aug, 2012 1 commit
  4. 16 Feb, 2010 1 commit
  5. 25 Dec, 2008 1 commit
  6. 21 Apr, 2008 1 commit
    • Kamalesh Babulal's avatar
      [CRYPTO] all: Clean up init()/fini() · 3af5b90b
      Kamalesh Babulal authored
      On Thu, Mar 27, 2008 at 03:40:36PM +0100, Bodo Eggert wrote:
      > Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
      > 
      > > This patch cleanups the crypto code, replaces the init() and fini()
      > > with the <algorithm name>_init/_fini
      > 
      > This part ist OK.
      > 
      > > or init/fini_<algorithm name> (if the 
      > > <algorithm name>_init/_fini exist)
      > 
      > Having init_foo and foo_init won't be a good thing, will it? I'd start
      > confusing them.
      > 
      > What about foo_modinit instead?
      
      Thanks for the suggestion, the init() is replaced with
      
      	<algorithm name>_mod_init ()
      
      and fini () is replaced with <algorithm name>_mod_fini.
      Signed-off-by: 's avatarKamalesh Babulal <kamalesh@linux.vnet.ibm.com>
      Signed-off-by: 's avatarHerbert Xu <herbert@gondor.apana.org.au>
      3af5b90b
  7. 05 Dec, 2007 1 commit
  8. 19 Oct, 2007 1 commit
  9. 06 Feb, 2007 1 commit