1. 20 Apr, 2017 1 commit
    • David Howells's avatar
      Annotate hardware config module parameters in sound/isa/ · e992ef57
      David Howells authored
      When the kernel is running in secure boot mode, we lock down the kernel to
      prevent userspace from modifying the running kernel image.  Whilst this
      includes prohibiting access to things like /dev/mem, it must also prevent
      access by means of configuring driver modules in such a way as to cause a
      device to access or modify the kernel image.
      To this end, annotate module_param* statements that refer to hardware
      configuration and indicate for future reference what type of parameter they
      specify.  The parameter parser in the core sees this information and can
      skip such parameters with an error message if the kernel is locked down.
      The module initialisation then runs as normal, but just sees whatever the
      default values for those parameters is.
      Note that we do still need to do the module initialisation because some
      drivers have viable defaults set in case parameters aren't specified and
      some drivers support automatic configuration (e.g. PNP or PCI) in addition
      to manually coded parameters.
      This patch annotates drivers in sound/isa/.
      Suggested-by: default avatarAlan Cox <gnomes@lxorguk.ukuu.org.uk>
      Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
      cc: Jaroslav Kysela <perex@perex.cz>
      cc: Takashi Iwai <tiwai@suse.com>
      cc: alsa-devel@alsa-project.org
  2. 01 Jun, 2016 1 commit
  3. 02 Jan, 2015 1 commit
    • Lars-Peter Clausen's avatar
      ALSA: wss: Remove (almost) always NULL parameters · fa60c065
      Lars-Peter Clausen authored
      Most callers of snd_wss_pcm(), snd_wss_timer() and snd_cs4236_pcm() pass
      NULL as the last parameter, some callers pass a pointer but never use it
      after the function has been called and only a few callers pass a pointer and
      actually use it. The later is only the case for snd_wss_pcm() for
      snd_cs4236_pcm() and it is possible to get the same PCM object by accessing
      the pcm field of the snd_wss struct that was passed as the first parameter.
      This function removes the last parameters from the functions mentioned above
      and updates the callers which used it to use chip->pcm instead. This allows
      us to slightly simplify the functions since they don't have to check and set
      the last parameter anymore which makes the code slightly shorter and
      Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
  4. 12 Feb, 2014 1 commit
  5. 29 May, 2013 1 commit
  6. 07 Dec, 2012 1 commit
  7. 19 Dec, 2011 1 commit
  8. 14 Sep, 2011 1 commit
    • Clemens Ladisch's avatar
      ALSA: mpu401: clean up interrupt specification · dba8b469
      Clemens Ladisch authored
      The semantics of snd_mpu401_uart_new()'s interrupt parameters are
      somewhat counterintuitive:  To prevent the function from allocating its
      own interrupt, either the irq number must be invalid, or the irq_flags
      parameter must be zero.  At the same time, the irq parameter being
      invalid specifies that the mpu401 code has to work without an interrupt
      allocated by the caller.  This implies that, if there is an interrupt
      and it is allocated by the caller, the irq parameter must be set to
      a valid-looking number which then isn't actually used.
      With the removal of IRQF_DISABLED, zero becomes a valid irq_flags value,
      which forces us to handle the parameters differently.
      This patch introduces a new flag MPU401_INFO_IRQ_HOOK for when the
      device interrupt is handled by the caller, and makes the allocation of
      the interrupt to depend only on the irq parameter.  As suggested by
      Takashi, the irq_flags parameter was dropped because, when used, it had
      the constant value IRQF_DISABLED.
      Signed-off-by: default avatarClemens Ladisch <clemens@ladisch.de>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
  9. 04 May, 2009 1 commit
  10. 24 Apr, 2009 1 commit
  11. 14 Apr, 2009 1 commit
  12. 21 Jan, 2009 1 commit
  13. 12 Jan, 2009 1 commit
  14. 06 Aug, 2008 5 commits
  15. 31 Jan, 2008 2 commits
  16. 16 Oct, 2007 3 commits