• Jan Kara's avatar
    writeback: Fix lock imbalance in writeback_sb_inodes() · ead188f9
    Jan Kara authored
    Fix bug introduced by 169ebd90.  We have to have wb_list_lock locked when
    restarting writeback loop after having waited for inode writeback.
    
    Bug description by Ted Tso:
    
      I can reproduce this fairly easily by using ext4 w/o a journal, running
      under KVM with 1024megs memory, with fsstress (xfstests #13):
    
      [   45.153294] =====================================
      [   45.154784] [ BUG: bad unlock balance detected! ]
      [   45.155591] 3.5.0-rc1-00002-gb22b1f17 #124 Not tainted
      [   45.155591] -------------------------------------
      [   45.155591] flush-254:16/2499 is trying to release lock (&(&wb->list_lock)->rlock) at:
      [   45.155591] [<c022c3da>] writeback_sb_inodes+0x160/0x327
      [   45.155591] but there are no more locks to release!
    Reported-by: default avatarTheodore Ts'o <tytso@mit.edu>
    Tested-by: default avatarTheodore Ts'o <tytso@mit.edu>
    Signed-off-by: default avatarJan Kara <jack@suse.cz>
    Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
    ead188f9
Name
Last commit
Last update
Documentation Loading commit data...
arch Loading commit data...
block Loading commit data...
crypto Loading commit data...
drivers Loading commit data...
firmware Loading commit data...
fs Loading commit data...
include Loading commit data...
init Loading commit data...
ipc Loading commit data...
kernel Loading commit data...
lib Loading commit data...
mm Loading commit data...
net Loading commit data...
samples Loading commit data...
scripts Loading commit data...
security Loading commit data...
sound Loading commit data...
tools Loading commit data...
usr Loading commit data...
virt/kvm Loading commit data...
.gitignore Loading commit data...
.mailmap Loading commit data...
COPYING Loading commit data...
CREDITS Loading commit data...
Kbuild Loading commit data...
Kconfig Loading commit data...
MAINTAINERS Loading commit data...
Makefile Loading commit data...
README Loading commit data...
REPORTING-BUGS Loading commit data...