Skip to content
  • Havoc Pennington's avatar
    Revamp and modernize X error traps · b837ef5a
    Havoc Pennington authored
    * add per-display gdk_x11_display_error_trap_push()
      (X11-specific because gdk_error_trap_push() probably
      should have been)
    * make gdk_error_trap_push() handle only GDK displays
      not displays opened without a GDK wrapper
    * make gdk_error_trap_pop() and gdk_x11_display_error_trap_pop()
      automatically sync only if needed, so manual gdk_flush() is not
      required
    * add gdk_error_trap_pop_ignored() which just asynchronously
      ignores errors, so never needs to sync
    * add G_GNUC_WARN_UNUSED_RESULT to plain pop(), because
      if you use plain pop() and don't need the return value,
      the async gdk_error_trap_pop_ignored() should be used
      instead. This results in lots of warnings to clean
      up in a later patch.
    
    The main objective here was to avoid the need to sync just
    to ignore an error. Now, syncing is automatic, and only
    happens when we need to know the error code.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=629608
    b837ef5a