Commit 4f78abdd authored by Carlos Garnacho's avatar Carlos Garnacho
Browse files

imwayland: Avoid TOGGLE_INPUT_PANEL requests if there's no focus

Fixes two things: 1) As GTK+ can be coerced into using the wayland IM
module despite the compositor not implementing the interface, all paths
not checking for global state before sending requests are prone to
crashes, this one fell hit this pitfall.

And 2) ensures the tap gesture only triggers TOGGLE_INPUT_PANEL if the
widget IM is focused. This is a possibility on eg. WebKit pages, where
its IM is only focused as long as a form element in the page is focused.
Tapping elsewhere shouldn't toggle the OSK.

Closes: #114
parent 6e2d1403
......@@ -420,6 +420,9 @@ released_cb (GtkGestureMultiPress *gesture,
GtkInputHints hints;
if (!global->current)
g_object_get (context, "input-hints", &hints, NULL);
if (n_press == 1 &&
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment