1. 03 Mar, 2004 13 commits
    • Matthias Clasen's avatar
      Move the actual implementation into a new · 19369fea
      Matthias Clasen authored
      Wed Mar  3 23:28:48 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_set_active): Move the actual
      	implementation into a new gtk_combo_box_set_active_internal()
      	function, which doesn't do the short-circuiting.
      	* gtk/gtkcombobox.c (gtk_combo_box_model_row_deleted): Use
      	set_active_internal() here, since the active item may change here,
      	although the index is unchanged.
      
      Wed Mar  3 23:26:49 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_menu_position): Reintroduce the
      	traditional option menu placement of the popup for regular combo
      	boxes. Grids and editable combo boxes use the combo-like placement
      	below the entry.  (#136021)
      	* gtk/gtkcombobox.c (gtk_combo_box_menu_button_press):
      	* gtk/gtkcombobox.c (gtk_combo_box_popup): Call gtk_menu_set_active()
      	before popping up the menu, to make the placement work.
      19369fea
    • Owen Taylor's avatar
      Special case scroll events so that they propagate up the widget heirarchy · 7a9bec28
      Owen Taylor authored
      Wed Mar  3 17:20:15 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkmain.c (gtk_propagate_event): Special case
              scroll events so that they propagate up the widget
              heirarchy when received on insensitive widgets.
              (#101102, reported by Geoff Reedy)
      7a9bec28
    • Owen Taylor's avatar
      #109594, reported by Olivier Ripoll · 0d898ffc
      Owen Taylor authored
      Wed Mar  3 16:47:10 2004  Owen Taylor  <otaylor@redhat.com>
      
               #109594, reported by Olivier Ripoll
      
              * gtk/gtkentry.c (gtk_entry_size_request): Use max of
              width and digit width for gtk_entry_set_width_chars,
              and round up.
      
              * gtk/gtkcolorsel.c (gtk_color_selection_init): Set the
              width of the entry to 7 chars.
      0d898ffc
    • Owen Taylor's avatar
      Strip out the "export-dynamic" libtool option from library link lines. · d7681e7c
      Owen Taylor authored
      Wed Mar  3 16:00:10 2004  Owen Taylor  <otaylor@redhat.com>
      
              * configure.in: Strip out the "export-dynamic" libtool
              option from library link lines. (#124687, James Henstridge)
      d7681e7c
    • Jonathan Blandford's avatar
      Don't activate the combo if we're in the midst of changing folders. · e47f7d58
      Jonathan Blandford authored
      Wed Mar  3 16:06:03 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (save_folder_combo_changed_cb):
              Don't activate the combo if we're in the midst of changing
              folders.
      e47f7d58
    • Mark McLoughlin's avatar
      don't try and store pointers in ints. Fixes 64-bit build. · 81ea4248
      Mark McLoughlin authored
      2004-03-03  Mark McLoughlin  <mark@skynet.ie>
      
              * tests/testsocket_common.c: (print_hello): don't try and store
              pointers in ints. Fixes 64-bit build.
      81ea4248
    • Federico Mena Quintero's avatar
      Simplify by not using a temporary variable, and clarify the documentation. · ecb01c42
      Federico Mena Quintero authored
      2004-03-03  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilesystem.c (gtk_file_system_get_parent): Simplify by
      	not using a temporary variable, and clarify the documentation.
      	Fixes #136008.
      ecb01c42
    • Mark McLoughlin's avatar
      Set the label widget's state to prelight if we're prelit. Fixes bug · 3c8e60e7
      Mark McLoughlin authored
      2004-03-03  Mark McLoughlin  <mark@skynet.ie>
      
              * gtk/gtkexpander.c:
              (gtk_expander_enter_notify), (gtk_expander_leave_notify),
              (gtk_expander_set_label_widget): Set the label widget's
              state to prelight if we're prelit. Fixes bug #136078.
      3c8e60e7
    • Murray Cumming's avatar
      Corrected the group_changed signal vfunc declaration, adding the first · 1cbdd62c
      Murray Cumming authored
      2004-03-03  Murray Cumming  <murrayc@murrayc.com>
      
              * gtk/gtkradiobutton.h, radiomenuitem.h: Corrected the group_changed
              signal vfunc declaration, adding the first parameter, which is the
              widget emitting the signal.
      1cbdd62c
    • Morten Welinder's avatar
      Plug leak. · eb7f75b7
      Morten Welinder authored
      2004-03-03  Morten Welinder  <terra@gnome.org>
      
      	* tests/testfilechooser.c (update_preview_cb): Plug leak.
      eb7f75b7
    • Jonathan Blandford's avatar
      Split function into realized and unrealized variants, and consolidate the · bb5a4999
      Jonathan Blandford authored
      Tue Mar  2 23:39:55 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdialog.c
              (file_chooser_widget_default_realized_size_changed): Split
              function into realized and unrealized variants, and consolidate
              the handling fo size-changing and default changing.
      
              * gtk/gtkfilechooserembed.[ch] (gtk_file_chooser_embed_class_init):
              remove resizable-hints-changed, as it just complicated things.
      
              * gtk/gtkfilechooserdefault.c (update_appearance): Don't emit
              resizable-hints-changed.
      bb5a4999
    • Tor Lillqvist's avatar
      Add a missing entry. (#135982, J. Ali Harlow) · 9ca11bfa
      Tor Lillqvist authored
      2004-03-03  Tor Lillqvist  <tml@iki.fi>
      
      	* gtk/gtk.def: Add a missing entry. (#135982, J. Ali Harlow)
      
      	* NEWS: Correct spelling of my name in one place.
      9ca11bfa
    • Federico Mena Quintero's avatar
      Handle errors in setting the path bar's path. Fixes #136000, based on a · e50fb687
      Federico Mena Quintero authored
      2004-03-02  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_set_current_folder): Handle errors in
      	setting the path bar's path.  Fixes #136000, based on a patch by
      	Morten Welinder.
      
      	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_insert_bookmark):
      	Don't free our own propagated error.
      
      	* gtk/gtkpathbar.c (gtk_path_bar_set_path): Likewise, and free the
      	parent_path upon error.  Fixes #136006, patch by Morten Welinder.
      	(gtk_path_bar_set_path): Unref the file_folder upon error.
      	(gtk_path_bar_set_path): Return a boolean success code.
      e50fb687
  2. 02 Mar, 2004 23 commits
    • Matthias Clasen's avatar
      Add an animation mode, to test how the combobox behaves if the model · 2169f509
      Matthias Clasen authored
      Wed Mar  3 00:28:59 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* tests/testcombochange.c: Add an animation mode, to test
      	how the combobox behaves if the model changes while it is popped
      	up.
      2169f509
    • Owen Taylor's avatar
      === Released 2.3.5 === · 30121c9a
      Owen Taylor authored
      Tue Mar  2 17:06:05 2004  Owen Taylor  <otaylor@redhat.com>
      
              * === Released 2.3.5 ===
      
              * NEWS: Updates
      
              * configure.in: Version 2.3.5, interface age 0.
              Require glib-2.3.5, pango-1.3.5.
      30121c9a
    • Matthias Clasen's avatar
      Avoid popping up the completions across the edge of the monitor. Part of · f2cc9ae8
      Matthias Clasen authored
      Tue Mar  2 23:08:12 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Avoid
      	popping up the completions across the edge of the monitor.
      	Part of #135561.
      f2cc9ae8
    • Owen Taylor's avatar
      Move the /nonexistant stuff out of the main window, keep the main window · ce52e077
      Owen Taylor authored
      Tue Mar  2 16:47:40 2004  Owen Taylor  <otaylor@redhat.com>
      
              * tests/testfilechooser.c (set_filename_existing_nonexistent_cb):
              Move the /nonexistant stuff out of the main window,
              keep the main window somewhat normal looking.
      ce52e077
    • Owen Taylor's avatar
      gtk/gtktreestore.c (gtk_tree_store_reorder) Fix up the interpretation of · d0f6b481
      Owen Taylor authored
      Tue Mar  2 16:18:43 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktreestore.c (gtk_tree_store_reorder)
              * gtk/gtkliststore.c (gtk_list_store_reorder): Fix
              up the interpretation of new_order to match what
              it means elsewhere, document the meaning of new_order.
      
              * gtk/gtkcombobox.c (gtk_combo_box_model_rows_reordered):
              Fix interpretation of new_order.
      
              * tests/testcombochange.c (on_reorder): Fix interpretation
              of new_order.
      
              * tests/testcombochange.c (on_reorder): Fix hitting
              "reorder" with an empty list.
      d0f6b481
    • Søren Sandmann Pedersen's avatar
      Remove conflict markers · 32e21f2b
      Søren Sandmann Pedersen authored
      32e21f2b
    • Soeren Sandmann's avatar
      Patch from Frederic Crozat, test code from Jean-Philippe Chancelier. Fixes · cddfd994
      Soeren Sandmann authored
      Tue Mar  2 21:23:30 2004  Soeren Sandmann  <sandmann@daimi.au.dk>
      
      	Patch from Frederic Crozat, test code from Jean-Philippe
      	Chancelier. Fixes bug #120479.
      
      	* gtk/gtkcombo.c (gtk_combo_popup_list): Make sure popup belongs
      	to the right window group.
      
      	* gtk/gtkmenu.c (gtk_menu_popup): Same
      
      	* tests/testsocket.c (main): Pack the plugs into an hbox instead
      	of a vbox.
      
      	* tests/testsocket_common.c: Add a GtkMenuBar, a GtkCombo and a
      	GtkComboBox to the children.
      cddfd994
    • Owen Taylor's avatar
      If the model was empty before, select the first inserted item. · f05cb42d
      Owen Taylor authored
      Tue Mar  2 14:38:23 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkcombobox.c (gtk_combo_box_model_row_inserted):
              If the model was empty before, select the first inserted
              item.
      
              * gtk/gtkcombobox.c (gtk_combo_box_model_row_deleted):
              Fix up the logic for the new row to select.
      
              * gtk/gtkcombobox.c (gtk_combo_box_class_init):
              Rename "appearance" property to "appears-as-list".
      
              * tests/testcombochange.c tests/Makefile.am: Test case
              for combos and dynamically changing models.
      f05cb42d
    • Jonathan Blandford's avatar
      set the default value, spotted by Morten Welinder. · e8c5b648
      Jonathan Blandford authored
      Tue Mar  2 15:19:52 2004  Jonathan Blandford  <jrb@redhat.com>
      
              * gtk/gtkfilechooserdefault.c
              (gtk_file_chooser_default_get_resizable_hints): set the default
              value, spotted by Morten Welinder.
      e8c5b648
    • Jonathan Blandford's avatar
      get the logic correct. This will fix sizing on save dialogs. · 87a6680f
      Jonathan Blandford authored
      Tue Mar  2 15:03:15 2004  Jonathan Blandford  <jrb@redhat.com>
      
              * gtk/gtkfilechooserdefault.c
              (gtk_file_chooser_default_get_resizable_hints): get the logic
              correct.  This will fix sizing on save dialogs.
      
              (save_widgets_create): set_mnemonic_widget.
      87a6680f
    • Federico Mena Quintero's avatar
      Don't update the save folder combo if we are already switching folders; · 9133c58b
      Federico Mena Quintero authored
      2004-03-02  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_set_current_folder): Don't update the
      	save folder combo if we are already switching folders; based on a
      	patch by Jonathan Blandford.
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_add_current_folder):
      	Handle failure to insert the path.  Based on a patch by Morten
      	Welinder attached to bug #135380.
      
      	* tests/testfilechooser.c (extra_widget_create): Add a bunch of
      	buttons to test various things.
      9133c58b
    • Matthias Clasen's avatar
      Add testentrycompletion. · 596cbff9
      Matthias Clasen authored
      Tue Mar  2 20:59:23 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* tests/Makefile.am: Add testentrycompletion.
      
      	* tests/testentrycompletion.c: New file to test some of the
      	more exotic GtkEntryCompletion features.
      596cbff9
    • Jonathan Blandford's avatar
      improve tests a little. · fe8838bc
      Jonathan Blandford authored
      Tue Mar  2 14:38:10 2004  Jonathan Blandford  <jrb@redhat.com>
      
              * tests/testfilechooser.c (main): improve tests a little.
      fe8838bc
    • Owen Taylor's avatar
      Always connect to the changed signals on the model, update the active item · 1d64b555
      Owen Taylor authored
      Tue Mar  2 11:45:50 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkcombobox.c: Always connect to the changed
              signals on the model, update the active item as
              appropriate when rows are inserted/deleted/reordered,
              re-layout the menu on ::rows-reordered.
      
              * gtk/gtkcellview.c (gtk_cell_view_set_displayed_row):
              Allow %NULL for path to unset and leave no current
              path.
      1d64b555
    • Matthias Clasen's avatar
      Position the popup above the sample if there is not enough room below. · de011a6d
      Matthias Clasen authored
      Tue Mar  2 19:54:53 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_list_position): Position
      	the popup above the sample if there is not enough room below.
      	Part of #135543.
      
      Tue Mar  2 19:53:36 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_set_popup_widget): Make the
      	frame for the list mode etched in, to give the popup a slightly
      	less flat appearance.
      
      Tue Mar  2 17:55:31 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtk.def: Add gtk_combo_box_entry_new_text().
      de011a6d
    • Morten Welinder's avatar
      Don't scale images that are small enough to fit. Avoid using incompatibly · e4cec76b
      Morten Welinder authored
      2004-03-02  Morten Welinder  <terra@gnome.org>
      
      	* tests/testfilechooser.c (size_prepared_cb): Don't scale images
      	that are small enough to fit.  Avoid using incompatibly typed data
      	pointer.
      e4cec76b
    • Morten Welinder's avatar
      Major thinko, trivial patch. /me chances a commit. · c0b55fe0
      Morten Welinder authored
      2004-03-02  Morten Welinder  <terra@gnome.org>
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_get_resizable_hints): Test the
      	resize_horizontally pointer, not the deferenced pointer.
      c0b55fe0
    • Federico Mena Quintero's avatar
      New flag shortcuts_current_folder_is_volume. · af409998
      Federico Mena Quintero authored
      2004-03-01  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): New
      	flag shortcuts_current_folder_is_volume.
      	(shortcuts_add_current_folder): Set
      	impl->shortcuts_current_folder_is_volume as appropriate.
      	(remove_current_folder_cb): Handle the flag.
      	(shortcuts_activate_item): Likewise.
      	(shortcuts_update_current_folder): Handle the
      	impl->shortcuts_current_folder_active flag; only add the folder if
      	it doesn't already exist in the list.
      	(shortcuts_model_create): Don't insert the current folder
      	separator here.
      	(shortcuts_add_current_folder): Insert the separator here.
      	(shortcut_find_position): Renamed from shortcut_exists(); now
      	returns an index.
      	(shortcuts_add_current_folder): Set the active item in the combo.
      af409998
    • Federico Mena Quintero's avatar
      Eep, use gtk_tree_model_filter_convert_iter_to_child_iter(), not the · 4e08da81
      Federico Mena Quintero authored
      2004-03-01  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_row_activated_cb): Eep,
      	use gtk_tree_model_filter_convert_iter_to_child_iter(), not the reverse.
      4e08da81
    • Federico Mena Quintero's avatar
      Don't unref an old model; there isn't one. This was a leftover from when · 7233e912
      Federico Mena Quintero authored
      2004-03-01  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_model_create): Don't
      	unref an old model; there isn't one.  This was a leftover from
      	when we recreated the model on every change.
      	(save_widgets_create): Create the save folder combo.
      	(shortcuts_model_create): Don't set the model on the tree view
      	here.
      	(gtk_file_chooser_default_constructor): Create the shortcuts model
      	here, before the rest of the widgets.
      	(shortcuts_list_create): Don't call shortcuts_model_create() here;
      	just set the model on the tree.
      	(save_folder_combo_create): New function, provided by Jonathan
      	Blandford.
      	(update_appearance): Set the sensitivity of the folder combo.
      	(shortcuts_activate_iter): New helper function; code moved from
      	shortcuts_row_activated_cb().
      	(shortcuts_activate_item): New helper function.
      	(shortcuts_row_activated_cb): Use shortcuts_activate_iter().
      	(ShortcutsIndex): Renamed SHORTCUTS_SEPARATOR to
      	SHORTCUTS_BOOKMARKS_SEPARATOR.
      	(struct _GtkFileChooserDefault): New field shortcuts_current_folder_active.
      	(shortcuts_insert_separator): Add a position argument.
      	(shortcuts_get_index): Handle the SHORTCUTS_CURRENT_FOLDER_SEPARATOR
      	and SHORTCUTS_CURRENT_FOLDER positions.
      	(shortcut_exists): Ignore the current folder row.
      	(struct _GtkFileChooserDefault): New field shortcuts_filter_model.
      	(shortcuts_model_create): Create a filter model for the shortcuts list.
      	(shortcuts_list_create): Set the model to the shortcuts_filter_model.
      	(remove_bookmark_button_clicked_cb): Use the shortcuts_filter_model.
      	(bookmarks_check_remove_sensitivity): Likewise.
      	(shortcuts_row_activated_cb): Likewise.
      	(gtk_file_chooser_default_set_current_folder): New function.
      	(gtk_file_chooser_default_set_current_folder): Update the current
      	folder row in the shortcuts list.
      
      	* gtk/gtkfilechooserwidget.c
      	(gtk_file_chooser_widget_constructor): Cast correctly for
      	_gtk_file_chooser_embed_set_delegate().
      7233e912
    • Owen Taylor's avatar
      Add gtk_drag_source_set/get_target_list(). (#127499, based on patch from · d52caae6
      Owen Taylor authored
      Mon Mar  1 19:30:25 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkdnd.[ch]: Add gtk_drag_source_set/get_target_list().
              (#127499, based on patch from Michael Natterer)
      
              * tests/testgtk.c: Fix bidi strings to display correctly
              with new auto-bidi.
      d52caae6
    • Matthias Clasen's avatar
      Remove the include of Xft.h, which is already dragged in via pangoxft.h. · 7002bb3e
      Matthias Clasen authored
      Tue Mar  2 01:34:40 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtksettings.c: Remove the include of Xft.h, which is already
      	dragged in via pangoxft.h.  (#135496, David Hawthorne)
      7002bb3e
    • Tim Janik's avatar
      expose gtk_bindings_activate_event(), changed callers. · c454880a
      Tim Janik authored
      Mon Mar  1 23:52:15 2004  Tim Janik  <timj@gtk.org>
      
              * gtk/gtkbindings.[hc]: expose gtk_bindings_activate_event(), changed
              callers.
      
              * gtk/gtkwindow.[hc]: added gtk_window_propagate_key_event() to expose
              the key event propagation mechanism used for focus widgets.
              (gtk_window_key_release_event): use the same key event propagation logic
              as gtk_window_key_press_event().
      c454880a
  3. 01 Mar, 2004 4 commits