1. 24 Oct, 2005 1 commit
    • Kristian Rietveld's avatar
      emitting row-has-child-toggled when the level is not in the cache does not · 3fe6e986
      Kristian Rietveld authored
      2005-10-24  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): emitting
      	row-has-child-toggled when the level is not in the cache does not
      	make sense.  (This bug probably crept in during the early stages
      	of GtkTreeModelSort when there wasn't a correct row-has-child-toggled
      	implementation yet),
      	(gtk_tree_model_sort_real_unref_node): only get the child iter
      	when we will actually also use it.
      3fe6e986
  2. 22 Oct, 2005 2 commits
    • Michael Natterer's avatar
      check for the widget being realized, in addition to being visible, to · d25d6585
      Michael Natterer authored
      2005-10-22  Michael Natterer  <mitch@imendio.com>
      
      	* gtk/gtktreeview.c (gtk_tree_view_scroll_to_cell): check for the
      	widget being realized, in addition to being visible, to avoid
      	running into precondition check in gtk_tree_view_get_cell_area().
      	(approved by Kris).
      d25d6585
    • Dom Lachowicz's avatar
      Experimentally, scrollbar steppers can shrink to 8 pixels on Win32. · f9365c37
      Dom Lachowicz authored
      	* modules/engines/ms-windows/msw_style.c (setup_msw_rc_style):
      	Experimentally, scrollbar steppers can shrink to 8 pixels on
      	Win32. Reflect that in the theme.
      	* modules/engines/ms-windows/Theme/gtk-2.0/gtkrc: Experimentally,
      	there is a 1-pixel border between a scrollbar and its child
      	in ScrolledWindows on Win32. Reflect that in the theme.
      f9365c37
  3. 20 Oct, 2005 1 commit
  4. 19 Oct, 2005 1 commit
    • Federico Mena Quintero's avatar
      Fixes bug #317999: · 647ba5b4
      Federico Mena Quintero authored
      2005-10-18  Federico Mena Quintero  <federico@ximian.com>
      
      	Fixes bug #317999:
      
      	* tests/autotestfilechooser.c
      	(test_button_folder_states_for_action): Test that we have either
      	$cwd or the explicitly-set folder.
      	(test_reload_sequence): Likewise.
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_get_current_folder): If our reload_state
      	is RELOAD_EMPTY, return a GtkFilePath corresponding to $cwd.
      647ba5b4
  5. 14 Oct, 2005 1 commit
    • Tor Lillqvist's avatar
      Remove the clipboard viewer code. It didn't really do anything useful, and · e6fa7394
      Tor Lillqvist authored
      2005-10-14  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkdisplay-win32.c: Remove the clipboard viewer code.
      	It didn't really do anything useful, and was just confusing and
      	incomplete. Comments claimed we don't do delayed rendering, but in
      	fact we do, for images. (The delayed rendering code has other
      	problems, though, see #168173.) The clipboard viewer code was
      	probably even buggy (the WM_CHANGECBCHAIN handled didn't propagate
      	the message when necessary). It was just test code, it said so in
      	a comment. Add something similar back later if necessary.
      
      	(_win32_on_clipboard_change,
      	_gdk_win32_register_clipboard_notification): Remove.
      
      	(gdk_display_supports_selection_notification,
      	gdk_display_request_selection_notification): Always just return
      	FALSE. We didn't generate any GDK_OWNER_CHANGE events anywhere.
      e6fa7394
  6. 13 Oct, 2005 2 commits
    • Tor Lillqvist's avatar
      Don't treat Alt-Enter specially. It does not have any special meaning and · d297ff32
      Tor Lillqvist authored
      2005-10-13  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkevents-win32.c (gdk_event_translate): Don't treat
      	Alt-Enter specially. It does not have any special meaning and
      	should be passed on to the application. (#318378, Tim Evans)
      d297ff32
    • Tor Lillqvist's avatar
      Set visual depth to 24 for 32 bits-per-pixel devices on Win32. This allows · b25e6c5b
      Tor Lillqvist authored
      2005-10-13  Tor Lillqvist  <tml@novell.com>
      
      	Set visual depth to 24 for 32 bits-per-pixel devices on
      	Win32. This allows gdk_drawable_real_draw_pixbuf() to use the
      	optimized composite_0888() function rather than the slower image
      	dithering functions to draw pixbufs (#313993, John Ehresman)
      
      	* gdk/win32/gdkimage-win32.c (_gdk_win32_new_image): Use
      	_gdk_windowing_get_bits_for_depth() to initialize
      	GdkImage::bits_per_pixel.
      	(_gdk_windowing_get_bits_for_depth): Return 32 bits for depth 24.
      
      	* gdk/win32/gdkpixmap-win32.c (gdk_pixmap_new): Use
      	_gdk_windowing_get_bits_for_depth() to initialize
      	BITMAPINFOHEADER::biBitCount.
      
      	* gdk/win32/gdkvisual-win32.c (_gdk_visual_init): Set
      	GdkVisual::depth to 24 even if GetDeviceCaps(BITSPIXEL) returns
      	32.
      b25e6c5b
  7. 12 Oct, 2005 1 commit
  8. 11 Oct, 2005 1 commit
    • Matthias Clasen's avatar
      Try to match an off toggle here with the matching on toggle if it · a07a5ecb
      Matthias Clasen authored
      2005-10-11  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktextbtree.c (_gtk_text_btree_delete): Try to match an off
      	toggle here with the matching on toggle if it immediately follows.
      	This is a common case, and handling it here prevents quadratic blowup
      	in cleanup_line() below.  (#317125)
      
      	* gtk/gtktextsegment.h:
      	* gtk/gtktextsegment.c (_gtk_char_segment_new_from_two_strings): Pass
      	the character counts into this function instead of computing them
      	again.
      a07a5ecb
  9. 10 Oct, 2005 1 commit
  10. 09 Oct, 2005 1 commit
  11. 07 Oct, 2005 6 commits
    • Matthias Clasen's avatar
      fix includes · 6592f00a
      Matthias Clasen authored
      6592f00a
    • Federico Mena Quintero's avatar
      Fixes bug #317999: · cca93029
      Federico Mena Quintero authored
      2005-10-07  Federico Mena Quintero  <federico@ximian.com>
      
      	Fixes bug #317999:
      
      	* tests/autotestfilechooser.c (test_reload_sequence): Ensure that
      	the the result of gtk_file_chooser_get_folder() is NULL or
      	non-NULL at the right times.  Log the tests.
      	(test_button_folder_states): New test for the initial states of
      	the current folder in GtkFileChooserButton.
      	(main): Test that the number of warnings/errors/critical errors is
      	zero.
      
      	* gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder):
      	Clarify the documentation on when this can return NULL.
      	(gtk_file_chooser_get_current_folder_uri): Likewise.
      
      	* gtk/gtkfilechooserbutton.c (struct
      	_GtkFileChooserButtonPrivate): Added a folder_has_been_set flag;
      	we use it to keep track of whether a folder has been set.
      	(gtk_file_chooser_button_map):  Implement.  If no folder has been
      	loaded before, we at least try to load $cwd here.
      	(gtk_file_chooser_button_constructor): If the construct-time
      	dialog already has a folder set, turn on our folder_has_been_set
      	flag.
      	(dialog_current_folder_changed_cb): Turn on our
      	folder_has_been_set flag.
      cca93029
    • Michael Natterer's avatar
      remove some explicit #defines of PROFILE_FILE_CHOOSER because they break · cab26ded
      Michael Natterer authored
      2005-10-07  Michael Natterer  <mitch@gimp.org>
      
      	* gtk/gtkfilechooserdefault.c: remove some explicit #defines of
      	PROFILE_FILE_CHOOSER because they break compilation after the
      	removal of <unistd.h>.
      cab26ded
    • Matthias Clasen's avatar
      Remove a redundant (and unconditional) include of unistd.h (#318211, · 5b2d546e
      Matthias Clasen authored
      2005-10-07   Matthias Clasen  <mclasen@redhat.com>
      
              * gtk/gtkfilechooserdefault.c: Remove a redundant (and
              unconditional) include of unistd.h  (#318211, Kazuki Iwamoto)
      5b2d546e
    • Matthias Clasen's avatar
      Use g_return_val_if_fail(), not g_return_if_fail(). (#318412, Kazuki · 8725724e
      Matthias Clasen authored
      2005-10-07   Matthias Clasen  <mclasen@redhat.com>
      
              * gtk/gtktexttag.c (gtk_text_attributes_ref): Use
              g_return_val_if_fail(), not g_return_if_fail().  (#318412,
              Kazuki Iwamoto)
      8725724e
    • Matthias Clasen's avatar
      Add a has-selection property · b863d240
      Matthias Clasen authored
      b863d240
  12. 05 Oct, 2005 4 commits
  13. 04 Oct, 2005 4 commits
  14. 03 Oct, 2005 1 commit
  15. 30 Sep, 2005 4 commits
    • Tor Lillqvist's avatar
      In case BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause · ef2c2326
      Tor Lillqvist authored
      2005-10-01  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkdrawable-win32.c (blit_from_pixmap): In case
      	BitBlt() fails with ERROR_INVALID_HANDLE, the most probable cause
      	is that the the desktop isn't visible because the session has been
      	switched, the screen is locked, or a terminal server session
      	disconnected, so no error message necessary. (#137796)
      
      	It is of course remotely possible that BitBlt() failing with
      	ERROR_INVALID_HANDLE might also be caused by some other
      	problem. We could strive for perfection and track whether the
      	desktop is visible by using WTSRegisterSessionNotification() and
      	handling WM_WTSESSION_CHANGE. I think that's overdoing it just for
      	this issue, though. If we would track desktop visibility, we
      	should then avoid even trying to update the display at all while
      	the desktop isn't visible.
      ef2c2326
    • Matthias Clasen's avatar
      Another attempt to correct the calculations for the first week day. We may · c693b5d6
      Matthias Clasen authored
      2005-09-30  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkcalendar.c (gtk_calendar_init): Another attempt
      	to correct the calculations for the first week day. We may
      	just have to remove this code if too many locales turn out
      	to have broken data.
      c693b5d6
    • Matthias Clasen's avatar
      Don't leak pixbuf in some cases. (#317611, Tommi Komulainen) · 0d047a35
      Matthias Clasen authored
      2005-09-30  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkimage.c (gtk_image_expose): Don't leak pixbuf in
      	some cases.  (#317611, Tommi Komulainen)
      0d047a35
    • Matthias Clasen's avatar
      Prevent overflow when storing size hints in an unsigned short variable. · 51c6eb96
      Matthias Clasen authored
      2005-09-30  Matthias Clasen  <mclasen@redhat.com>
      
              * gtk/gtksocket-x11.c (_gtk_socket_windowing_size_request):
              Prevent overflow when storing size hints in an unsigned
              short variable. Tracked down by Ray Strode and Søren Sandmann.
      51c6eb96
  16. 29 Sep, 2005 6 commits
    • Matthias Clasen's avatar
      Check arguments. (#317491, Paolo Borelli) · 56b4314a
      Matthias Clasen authored
      2005-09-29  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkbutton.c (gtk_button_set_image): Check arguments.  (#317491,
      	Paolo Borelli)
      56b4314a
    • Matthias Clasen's avatar
      Stop drags when being grab shadowed. (#317332) · f6501cb4
      Matthias Clasen authored
      2005-09-29  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkpaned.c (gtk_paned_grab_notify): Stop drags when being
      	grab shadowed.  (#317332)
      f6501cb4
    • Tor Lillqvist's avatar
      DLLs are always in bin nowadays, no need to test. · 840796df
      Tor Lillqvist authored
      2005-09-29  Tor Lillqvist  <tml@novell.com>
      
      	* gtk-zip.sh.in: DLLs are always in bin nowadays, no need to test.
      840796df
    • Federico Mena Quintero's avatar
      Oops, return if the unmap test fails. (test_reload_sequence): Use · e14ad12b
      Federico Mena Quintero authored
      2005-09-28  Federico Mena Quintero  <federico@ximian.com>
      
      	* tests/autotestfilechooser.c (test_reload_sequence): Oops, return
      	if the unmap test fails.
      	(test_reload_sequence): Use gtk_widget_show_now() instead of
      	gtk_widget_show() for the dialog.
      	Thanks to Tim Janik for noticing these.
      e14ad12b
    • Federico Mena Quintero's avatar
      New file with a set of tests for GtkCellRendererText. The idea is to run a · 3e9f549d
      Federico Mena Quintero authored
      2005-09-28  Federico Mena Quintero  <federico@ximian.com>
      
      	* tests/testcellrenderertext.c: New file with a set of tests for
      	GtkCellRendererText.  The idea is to run a text renderer through
      	most of its interesting property values to see that it works
      	correctly.
      
      	* tests/Makefile.am: Added testcellrenderertext.
      
      	* gtk/gtkfilechooserdefault.c (load_set_model): Mark the
      	entry/exit of this function for profiling.
      	(gtk_file_chooser_default_style_set): Mark the start/end of the
      	calls to the parent class and the the signal emission for profiling.
      3e9f549d
    • Federico Mena Quintero's avatar
      New file with a set of tests for GtkCellRendererText. The idea is to run a · 77b52249
      Federico Mena Quintero authored
      2005-09-28  Federico Mena Quintero  <federico@ximian.com>
      
      	* tests/testcellrenderertext.c: New file with a set of tests for
      	GtkCellRendererText.  The idea is to run a text renderer through
      	most of its interesting property values to see that it works
      	correctly.
      
      	* tests/Makefile.am: Added testcellrenderertext.
      
      	* gtk/gtkfilechooserdefault.c (load_set_model): Mark the
      	entry/exit of this function for profiling.
      	(gtk_file_chooser_default_style_set): Mark the start/end of the
      	calls to the parent class and the the signal emission for profiling.
      77b52249
  17. 28 Sep, 2005 3 commits