1. 23 Aug, 2018 1 commit
  2. 22 Aug, 2018 1 commit
    • Benjamin Otte's avatar
      Don't deprecate gtk_widget_show_all() · da8994f9
      Benjamin Otte authored
      After discussions on IRC, the conclusion was reached that deprecations
      only make sense if an action can be taken to not use the deprecated code
      that makes the code more current and simplifies a later port to a newer
      GTK version.
      In this particular case, the suitable action would be adding
      gtk_widget_show() calls whenever a widget is created, so that a call to
      show_all() is not necessary.
      However, in GTK4 these calls would not be necessary and end up just
      bloating the codebase unnecessarily.
      So it was decided the better solution would be to not deprecate the API
      and instead leave this work to be done during potential GTK4 ports of
      This reverts commit 4d71d230.
      Fixes !1282
  3. 21 Aug, 2018 2 commits
  4. 20 Aug, 2018 1 commit
  5. 19 Aug, 2018 1 commit
  6. 18 Aug, 2018 4 commits
  7. 17 Aug, 2018 2 commits
    • Iain Lane's avatar
      colorpickershell: Unpack the tuple returned from PickColor() · dce33fa8
      Iain Lane authored
      When calling PickColor on org.gnome.Shell, we get back an "a{sv}", which
      GDBus provides to us as "(a{sv})".
      At the minute we're not unpacking this tuple, and so picking fails with
      messages like:
        GLib-CRITICAL **: 13:38:19.439: g_variant_lookup_value: assertion 'g_variant_is_of_type (dictionary, G_VARIANT_TYPE ("a{s*}")) || g_variant_is_of_type (dictionary, G_VARIANT_TYPE ("a{o*}"))' failed
        Gtk-WARNING **: 13:38:19.439: Picking color failed: No color received
      Let's unpack it.
    • Ricardo Silva Veloso's avatar
  8. 15 Aug, 2018 2 commits
  9. 14 Aug, 2018 3 commits
  10. 12 Aug, 2018 4 commits
  11. 11 Aug, 2018 2 commits
  12. 10 Aug, 2018 3 commits
    • Jonas Ådahl's avatar
      tooltip: Implement positioning using gdk_window_move_to_rect() · 14d22cb3
      Jonas Ådahl authored
      In order to make tooltip positioning portable, make use of the
      move_to_rect API. Some semantical changes are made, as identical
      semantics cannot be implemented using the move-to-rect API.
      Primarily the implemented semantics are:
      Position the tooltip in the center pixels slightly below (defaults to 4
      units below) the tooltipped widget. This is always the case for keyboard
      driven tooltips; the case where it tries to avoid the pointer cursor is
      not implemented.
      For pointer position triggered tooltips, implement the following
      additional semantics:
      Use the current cursor size to determine the padding used to enlarge the
      anchor rectangle. This is to try to avoid the cursor overlapping the
      If the anchor rectangle is too tall (meaning if we'd be constrained
      and flip on the Y axis, it'd flip too far away from the originally
      intended position), rely only on the pointer position to position the
      tooltip. The approximate pointer cursor rectangle is used as a anchor
      rectangle. Ideally we should use the actual pointer cursor rectangle
      (image used as well as hotspot coordinate), but we don't have API to
      get that information.
      If the anchor rectangle isn't to tall, just make sure the tooltip isn't
      too far away from the pointer position on the X axis.
      Closes: #134
      Closes: #432
      Closes: #574
      Closes: #579
      Closes: #878
    • Jonas Ådahl's avatar
      gdk/wayland: Always map windows 'moved-to-rect' as popups · 595f3902
      Jonas Ådahl authored
      Only popups can make use of the move-to-rect semantics so it makes no
      sense to try anything other surface type.
    • Jonas Ådahl's avatar
      gdk/wayland: Don't remap non-subsurface as subsurface · 1ed53199
      Jonas Ådahl authored
      Let's just use the fact that a window was mapped as a subsurface to
      remap it above another transient parent instead of relying on the more
      complicated 'should-map-as-subsurface' helper function.
  13. 09 Aug, 2018 1 commit
  14. 08 Aug, 2018 1 commit
  15. 07 Aug, 2018 1 commit
    • Руслан Ижбулатов's avatar
      GDK W32: Support smooth scrolling · 359df028
      Руслан Ижбулатов authored
      Set delta_x or delta_y for GdkScrollEvent.
      HIWORD (wParam) in WM_MOUSE(H)WHEEL is the scroll delta.
      A delta value of WHEEL_DELTA (which is 120) means scrolling
      one full unit of something (for example, a line).
      The delta should also be multiplied by the value that the
      SystemParametersInfo (SPI_GETWHEELSCROLL(LINES|CHARS), 0, &value, 0)
      call gives back, unless it gives back 0xffffffff, in which case
      it indicates that scrolling is page- or screen-based, not line-based
      (GDK doesn't support that at the moment).
      Also, all deltas should be inverted, since MS sends negative deltas
      when scrolling down (rotating the wheel back, in the direction of
      the user).
      With deltas set the mode should be set to GDK_SCROLL_SMOOTH.
      Fixes issue 1263.
  16. 06 Aug, 2018 4 commits
  17. 05 Aug, 2018 5 commits
  18. 04 Aug, 2018 2 commits