1. 18 May, 2001 4 commits
    • Owen Taylor's avatar
      Remove reallocate-redraws property. This is something that only a widget · 50512ddc
      Owen Taylor authored
      Fri May 18 14:25:20 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkcontainer.c: Remove reallocate-redraws property.
      	This is something that only a widget writer would ever want
      	to change.
      
      	* gtk/gtksignal.c: Handle G_SIGNAL_TYPE_STATIC_SCOPE for
      	gtk_signal_emit_by_name().
      
      	* gtk/gtkviewport.c: Fix some warnings.
      
      	* gtk/gtkwidget.c gtk/gtksizegroup.c: Add "size group" facility
      	allowing the requisitions of multiple widgets to be grouped
      	together.
      
      	* tests/testgtk.c: Add GtkSizeGroup test
      
      	* demos/gtk-demo/sizegroup.c: Add GtkSizeGroup demo.
      
      	* demos/gtk-demo/main.c demos/gtk-demo/pixbufs.c: Fix some
      	warnings.
      
      	* configure.in: Switch to using AM_GLIB_GNU_GETTEXT.
      50512ddc
    • Martin Baulig's avatar
      Renamed gtk_image_menu_item_add_icon() to gtk_image_menu_item_set_icon() · 60530b8a
      Martin Baulig authored
      2001-04-28  Martin Baulig  <baulig@suse.de>
      
      	* gtk/gtkimagemenuitem.[ch]: Renamed gtk_image_menu_item_add_icon()
      	to gtk_image_menu_item_set_icon() and made it work if there's already
      	an image.
      	(gtk_image_menu_item_new): This function doesn't take any arguments anymore.
      	(gtk_image_menu_item_new_with_label): New function.
      60530b8a
    • Jonathan Blandford's avatar
      It's the worlds ugliest highlighting code!!!! The result is okay so long · 009212ad
      Jonathan Blandford authored
      Thu May 17 16:20:04 2001  Jonathan Blandford  <jrb@redhat.com>
      
      	* demos/gtk-demo/main.c (fontify): It's the worlds ugliest
      	highlighting code!!!!  The result is okay so long as you don't try
      	to stress it.  It also highlights a bug in the TextView so it's in
      	an unproportional font right now until it's fixed.
      
      	*demos/gtk-demo/*.c: Clean up code a bit to make it
      	ugly-parser(TM) friendly. (-:
      009212ad
    • Joe Shaw's avatar
      Remove the assertions that x_offset and y_offset must be >= 0. Clip the · 288ff7e0
      Joe Shaw authored
      2001-05-17  Joe Shaw  <joe@ximian.com>
      
      	* gtk/gtktextdisplay.c (gtk_text_layout_draw): Remove the assertions
      	that x_offset and y_offset must be >= 0. Clip the cursor being drawn
      	if it is only partially onscreen.
      288ff7e0
  2. 17 May, 2001 2 commits
    • Owen Taylor's avatar
      Make logical motion and deletion by graphemes, not by characters. · 69ef3403
      Owen Taylor authored
      Thu May 17 17:10:13 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkentry.c: Make logical motion and deletion by graphemes,
      	not by characters.
      
      	* gtk/gtkentry.c: Handle "trailing" returns from Pango when they
      	are not zero or one; that is, when graphemes of multiple characters
      	are involved.
      
      	* gtk/gtktextlayout.c (line_display_index_to_iter): Remove unnecessary
      	FIXME.
      69ef3403
    • Alexander Larsson's avatar
      Add properties, based on patch by Lee Mallabone. · 6ee1ae13
      Alexander Larsson authored
      2001-05-17  Alexander Larsson  <alla@lysator.liu.se>
      
      	* gtk/gtkbbox.c:
      	Add properties, based on patch by Lee Mallabone.
      
      	* gtk/gtknotebook.c:
      	* gtk/gtktoolbar.c:
      	Convert from GtkArg to GParam, based on patch by John Margaglione.
      
      	* gtk/gtkhscale.c:
      	* gtk/gtkvscale.c:
      	* gtk/gtkhscrollbar.c:
      	* gtk/gtkvscrollbar.c:
      	* gtk/gtkrange.c:
      	Move adjustment property to GtkRange.
      
      	* gtk/gtklabel.c:
      	Setup mnemonics on property changes
      
      	* gtk/gtkwidget.c (gtk_widget_get_property):
      	GdkExtensionMode is an enum, not a flag. Set it with
      	g_value_set_enum ().
      
      	* tests/prop-editor.c:
      	Better propery editor.
      
      	* tests/testgtk.c:
      	Add new property test. Pass zero to the property editor to
      	get properties from all derived types.
      6ee1ae13
  3. 16 May, 2001 3 commits
    • Owen Taylor's avatar
      Require libtool-1.4, automake-1.4p1. · 55b115ac
      Owen Taylor authored
      Sun May 13 12:01:12 2001  Owen Taylor  <otaylor@redhat.com>
      
              * autogen.sh (have_automake): Require libtool-1.4,
              automake-1.4p1.
      
              * acinclude.m4: Remove libtool macros.
      
              * gdk-pixbuf/Makefile.am: Add dependencies to loade
              modules.
      
              * gdk/Makefile.am: Add dependency on libgdk_pixbuf.la
              for libgdk.
      
              * gtk/Makefile.am: Add dependency on libgdk_pixbuf.la
              libgdk.la for libgtk.
      
              * modules/input/Makefile.am: Make modules have full
              dependencies.
      55b115ac
    • Jonathan Blandford's avatar
      fix bug #54699 where paths weren't being checked for correctness. · 97fb7b78
      Jonathan Blandford authored
      Wed May 16 14:06:01 2001  Jonathan Blandford  <jrb@redhat.com>
      
      	* gtk/gtktreemodel.c (gtk_tree_path_new_from_string): fix bug
      	#54699 where paths weren't being checked for correctness.
      97fb7b78
    • Jonathan Blandford's avatar
      You can now set all sorts of properties in any order you wan, whether or · 2970a2fe
      Jonathan Blandford authored
      Tue May 15 20:13:24 2001  Jonathan Blandford  <jrb@redhat.com>
      
      	* gtk/gtktreeviewcolumn.c: You can now set all sorts of properties
      	in any order you wan, whether or not the column is added to the
      	tree, or the tree is realized.  Yay!
      
      	* gtk/gtktreeviewcolumn.c
      	(gtk_tree_view_column_setup_sort_column_id_callback): handle
      	sorting columns a lot saner
      
      	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_set_reorderable):
      	new function to actually set wether or not a column is
      	reorderable.
      
      	* gtk/gtktreeview.c (gtk_tree_view_unrealize): Only destroy things
      	if we have 'em.
      
      	* gtk/gtktreeviewcolumn.c (_gtk_tree_view_column_set_tree_view):
      	Fix nasty bug where we were showing the button just before
      	realizing it.  As a result, the parent window was
      	tree_view->window instead of tree_view->priv->header_window.
      
      	* gtk/gtktreeview.c (gtk_tree_view_set_reorderable): new property
      	to let you easily reorder a list or tree.
      2970a2fe
  4. 15 May, 2001 2 commits
  5. 14 May, 2001 1 commit
    • Owen Taylor's avatar
      Block against redundant changes. · 6d2ce706
      Owen Taylor authored
      Mon May 14 14:56:21 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* tests/prop-editor.c: Block against redundant changes.
      
      	* gtk/gtkpaned.c gtk/gtk[hv]paned.c: Add position, position_set
      	properties.
      6d2ce706
  6. 13 May, 2001 2 commits
    • Owen Taylor's avatar
      Missed from last commit. · 0466a7af
      Owen Taylor authored
      0466a7af
    • Owen Taylor's avatar
      Remove creative formatting. · 868b0063
      Owen Taylor authored
      Sun May 13 18:40:04 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* gdk/gdkpixmap.h: Remove creative formatting.
      
      Thu May 10 19:22:28 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtktogglebutton.c:  Patch from John Margaglione converting to
      	property API. (#51669)
      
      	* gtk/gtkscale.c: Patch from John Margaglione converting to
      	property API. (#51891)
      
      	* gtk/gtkaccellabel.c: Applied patch from Lee Mallabone, converting
      	to property API. (#50985)
      868b0063
  7. 12 May, 2001 1 commit
  8. 11 May, 2001 5 commits
    • ERDI Gergo's avatar
      Peek strike-through setting (gdk_draw_layout_line_with_colors): Render · 7cf82777
      ERDI Gergo authored
      2001-05-05  ERDI Gergo  <cactus@cactus.rulez.org>
      
      	* gdk/gdkpango.c (gdk_pango_get_item_properties): Peek
      	strike-through setting
      	(gdk_draw_layout_line_with_colors): Render strike-through
      7cf82777
    • Alexander Larsson's avatar
      Expose the ring in the triangle at the correct place when exposing just a · 0cfd48a8
      Alexander Larsson authored
      2001-05-11  Alexander Larsson  <alexl@redhat.com>
      
      	* gtk/gtkhsv.c (paint_triangle):
      	Expose the ring in the triangle at the correct place when
      	exposing just a part of the triangle.
      0cfd48a8
    • Alexander Larsson's avatar
      Return FALSE, or window focusing will not work. · cf18c025
      Alexander Larsson authored
      2001-05-11  Alexander Larsson  <alexl@redhat.com>
      
      	* gtk/gtkwindow-decorate.c (gtk_decorated_window_focus_change):
      	Return FALSE, or window focusing will not work.
      cf18c025
    • Havoc Pennington's avatar
      docs, fixes bug #54144 · cc6b34c1
      Havoc Pennington authored
      2001-05-11  Havoc Pennington  <hp@pobox.com>
      
      	* gtk/gtkimage.c (gtk_image_new_from_stock): docs, fixes bug
      	#54144
      
      	* gtk/gtkcolorsel.c (gtk_color_selection_new): docs, fixes
      	bug #54330
      
      2001-05-11  Havoc Pennington  <hp@pobox.com>
      
      	* gtk/tmpl/gtkvruler.sgml,
      	gtk/tmpl/gtkhruler.sgml: fix bug #54431
      
      	* gtk/tmpl/gtkdrawingarea.sgml: fix bug #54331
      
      	* gtk/tmpl/gtkenums.sgml: fix bug #54329, and
      	update some other random things
      
      	* gtk/gtk-sections.txt: updates
      
      	* gtk/tmpl/gtkmenuitem.sgml: fix bug #54277
      
      	* gtk/tmpl/gtkradiomenuitem.sgml: fix bug #54323,
      	#54324, #54325
      cc6b34c1
    • Tim Janik's avatar
      don't propagate exposes to NULL child. · 564e2235
      Tim Janik authored
      Fri May 11 02:53:57 2001  Tim Janik  <timj@gtk.org>
      
              * gtk/gtktogglebutton.c (gtk_toggle_button_expose): don't
              propagate exposes to NULL child.
      
              * gtk/gtkscrolledwindow.c (gtk_scrolled_window_adjustment_changed): guard
              against not having one of the scrollbars.
      
              * gtk/gtklabel.c (gtk_label_setup_mnemonic): clean up after us,
              we don't keep a mnemonic window if we have no mnemonic installed.
      564e2235
  9. 10 May, 2001 2 commits
    • Tim Janik's avatar
      grum, gtk_type_class() is not GNUC_CONST it has the _important_ side · 836e5f4a
      Tim Janik authored
      Fri May 11 01:05:00 2001  Tim Janik  <timj@gtk.org>
      
              * gtk/gtktypeutils.h: grum, gtk_type_class() is not GNUC_CONST
              it has the _important_ side effect of initializing a class.
      836e5f4a
    • Alexander Larsson's avatar
      Make sure you can compile out the implementation/wrapper assert macros. · 2c396fea
      Alexander Larsson authored
      2001-05-10  Alexander Larsson  <alexl@redhat.com>
      
      	* gdk/linux-fb/gdkprivate-fb.h:
      	Make sure you can compile out the implementation/wrapper assert
      	macros.
      
      	* gdk/linux-fb/gdkdrawable-fb2.c:
      	Check implementation/wrappers, initialize type for pixmap dummys.
      
      	* gdk/linux-fb/gdkimage-fb.c (_gdk_fb_get_image):
      	Hide the cursor if reading from the screen.
      
      	* gdk/linux-fb/gdkrender-fb.c (gdk_fb_fill_span_generic):
      	Fix sign bug in tiling code.
      
      	* gdk/linux-fb/gdkwindow-fb.c (_gdk_windowing_window_clear_area):
      	Handle background pixmaps.
      2c396fea
  10. 09 May, 2001 2 commits
    • Jonathan Blandford's avatar
      New function to let user control where columns are dragged. · 6e705640
      Jonathan Blandford authored
      Wed May  9 15:27:22 2001  Jonathan Blandford  <jrb@redhat.com>
      
      	* gtk/gtktreeview.c (gtk_tree_view_set_column_drag_function): New
      	function to let user control where columns are dragged.
      
      	* gtk/gtktreeview.c (gtk_tree_view_key_press): Cancel drags if
      	Escape is pressed.
      6e705640
    • Jonathan Blandford's avatar
      New "columns_changed" signal. · 3340826a
      Jonathan Blandford authored
      Wed May  9 09:08:44 2001  Jonathan Blandford  <jrb@webwynk.net>
      
      	* gtk/gtktreeview.c (gtk_tree_view_class_init): New
      	"columns_changed" signal.
      	(gtk_tree_view_motion_draw_column_motion_arrow): Change column
      	motion code to draw arrows to the side if indicator is outside the
      	widget.
      	(gtk_tree_view_map_expanded_rows): Implement.
      3340826a
  11. 07 May, 2001 5 commits
    • Alexander Larsson's avatar
      Include gdkfb.h on linux-fb. · 3e7bd8bf
      Alexander Larsson authored
      2001-05-07  Alexander Larsson  <alexl@redhat.com>
      
      	* demos/testpixbuf-save.c:
      	* demos/testpixbuf-drawable.c:
      	Include gdkfb.h on linux-fb.
      3e7bd8bf
    • Alexander Larsson's avatar
      New function for getting toplevel window at position. · 404d1a2d
      Alexander Larsson authored
      2001-05-07  Alexander Larsson  <alexl@redhat.com>
      
      	* gdk/linux-fb/gdkdnd-fb.c (get_toplevel_window_at):
      	New function for getting toplevel window at position.
      	(gdk_drag_find_window): Use get_toplevel_window () instead
      	of gdk_window_get_pointer(). (gdk_drag_status): Use
      	correct context for getting window.
      
      	* gdk/linux-fb/gdkproperty-fb.c (gdk_atom_name):
      	g_strdup the atom name.
      
      	* gdk/linux-fb/gdkwindow-fb.c:
      	Costmetic fix.
      
      	* gtk/gtkdnd.c (gtk_drag_source_handle_event):
      	Add code for changing cursor on linux-fb backend (same as
      	win32).
      404d1a2d
    • Federico Mena Quintero's avatar
      Fixlet - Federico · b19d0812
      Federico Mena Quintero authored
      b19d0812
    • Federico Mena Quintero's avatar
      Test for bin->child being present before doing anything with it. Patch · f14a8073
      Federico Mena Quintero authored
      2001-05-07  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkwindow.c (gtk_window_focus): Test for bin->child being
      	present before doing anything with it.  Patch from Håvard Kvålen
      	<havardk@netcom.no>.
      f14a8073
    • Havoc Pennington's avatar
      fix some shell typos · b4e4a0ed
      Havoc Pennington authored
      2001-05-04  Havoc Pennington  <hp@redhat.com>
      
      	* configure.in: fix some shell typos
      
      	* gtk/gtkcolorsel.c (gtk_color_selection_destroy): warning fix
      
      	* gtk/gtkimage.c: handle animations
      
      	* gtk/gtkcheckbutton.c (gtk_check_button_size_request): request
      	border_width * 2, not just border_width
      
      	* gtk/gtkscale.c: add "format_value" signal to allow people
      	to override the way values are drawn.
      	(gtk_scale_get_value_size): fix width/height mistake,
      	and compute size from actual displayed text, not
      	from made-up text.
      
      	* gtk/gtktexttag.c (gtk_text_tag_class_init): fix return type in
      	signal registration
      
      	* tests/testtext.c: Add "Remove all tags" menu item for testing
      
      	* gtk/gtktextbuffer.c (gtk_text_buffer_remove_all_tags): implement
      
      	* demos/gtk-demo/main.c (main): add hack so we can find modules
      	without installing gtk
      
      	* demos/gtk-demo/textview.c (insert_text): demo font scaling
      
      	* gtk/gtkcellrenderertext.c: Add "scale" property (font scaling
      	factor)
      	(gtk_cell_renderer_text_set_property): remove some bogus
      	g_object_notify
      
      	* gtk/gtktexttag.c: add "scale" property which is a font scaling
      	factor
      
      	* gtk/gtktextlayout.c (add_text_attrs): add font scale attribute
      	to layout
      
      	* gtk/gtktextiter.c (gtk_text_iter_is_start): rename from
      	gtk_text_iter_is_first
      
      2001-05-04  Havoc Pennington  <hp@redhat.com>
      
      	* pixops/pixops.c (pixops_process): merge fix from stable: Patch
      	 from hoshem@mel.comcen.com.au to fix nonzero X offsets.  Fixes
      	 bug #50371.
      
              * gdk-pixbuf/pixops/pixops.c (pixops_composite_nearest): merge
      	from stable: Patch from OKADA Mitsuru <m-okada@fjb.co.jp> to fix
      	confusion of using "src" instead of "p".
              (pixops_composite_color_nearest): Use a more accurate (and
      	correct, to begin with) compositing method.  This cures checks
      	showing through on images with no alpha.
      
      	* gdk-pixbuf.c (gdk_pixbuf_fill): fix bug that left some trailing
      	bytes unfilled.
      
      	* gdk-pixbuf-io.h: fix UpdatedNotifyFunc to use signed ints
      
      	* gdk-pixbuf-loader.h (struct _GdkPixbufLoaderClass): Change
      	area_updated signal to use signed ints.  Removed animation-related
      	signals.
      
      	* io-gif.c, io-gif-animation.h, io-gif-animation.c: Massive
      	rewrite action
      
      	* gdk-pixbuf-animation.c: Add GdkPixbufAnimationIter to abstract
      	all the pesky details. Remove old frame-based API. Make
      	GdkPixbufAnimation an abstract base class, derived by the loaders.
      b4e4a0ed
  12. 06 May, 2001 1 commit
    • Hans Breuer's avatar
      updated exports · 1fa43ed5
      Hans Breuer authored
      2001-01-06  Hans Breuer  <hans@breuer.org>
      
      	* gdk/gdk.def : updated exports
      
      	* gdk/win32/makefile.msc : -DGDK_ENABLE_BROKEN otherwise
      	gdk won't compile anymore
      
      	* gdk/win32/gdkevents-win32.c : initialize ret_val when
      	processing GDK_FILTER functions, initialize event.key->hardware_keycode.
      	Improved gdk_flush () to not only do pending drawing operations
      	but also process all currently pending events. This should make
      	the behaviour more similar to the X11 version.
      
      	* gdk/win32/gdkgc-win32.c (predraw_set_background) : a background
      	option needs to be set even if there is no GDK_GC_BACKGROUND.
      	(gdk_win32_hdc_get) : use predraw_set_background () independent
      	of value_mask. This allows to draw dashed lines leaving the original
      	background intact.
      
      	* gdk/win32/gdkimage-win32.c (gdk_image_new_bitamp) : free data
      	after processing, because we can't reuse it as the X11 version does.
      
      	* gtk/gtk.def : updated exports
      
      	* gtk/makefile.msc.in : added ATK, removed all test apps. (I
      	would like to get rid of this file again, and use straight
      	makefile.msc again, as the other Gtk+ subdirs do)
      
      	* test/makefile.msc (new file) : build the test apps here
      1fa43ed5
  13. 05 May, 2001 2 commits
    • Owen Taylor's avatar
      Release 1.3.5 · bd7502f9
      Owen Taylor authored
      Sat May  5 10:06:24 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* Release 1.3.5
      
      	* configure.in (GTK_MICRO_VERSION): Up to 1.3.5
      
              * NEWS: Updated
      
      	* demos/gtk-demo/Makefile.am (EXTRA_DIST): Fix minor
      	Makefile breakage.
      bd7502f9
    • Owen Taylor's avatar
      Fix typo in filename. · d15b4aa5
      Owen Taylor authored
      Sat May  5 09:18:30 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* demos/gtk-demo/images.c (progressive_timeout): Fix
      	typo in filename.
      
      	* gtk/gtktreeview.c (gtk_tree_view_row_activated): Comment
      	out FIXME warning; just too annoying.
      d15b4aa5
  14. 04 May, 2001 1 commit
    • Alex Larsson's avatar
      Better error messages. · 3b782bdb
      Alex Larsson authored
      2001-05-04  Alex Larsson  <alla@lysator.liu.se>
      
      	* gdk/linux-fb/gdkcolor-fb.c:
      	Better error messages.
      
      	* gdk/linux-fb/gdkpixmap-fb.c (gdk_pixmap_new):
      	Initialize abs_x and abs_y.
      
      	* gdk/linux-fb/gdkrender-fb.c (gdk_fb_fill_span_generic):
      	Correct handling of stipple offset.
      
      	* gdk/linux-fb/gdkvisual-fb.c (gdk_visual_init):
      	Treat directcolor framebuffers as truecolor.
      3b782bdb
  15. 03 May, 2001 5 commits
    • Owen Taylor's avatar
      Add dependency on Atk for accessibility support. · 42cc312d
      Owen Taylor authored
      Thu May  3 14:13:49 2001  Owen Taylor  <otaylor@redhat.com>
      
              * INSTALL.in HACKING gtk/gtkaccessible.[ch] gtk/gtk.c: Add
      	dependency on Atk for accessibility support.
      
      	* configure.in **/Makefile.am: Major reworking of substituted
      	variables for CFLAGS/LIBS to make a lot more sane and
      	keep the the compile/link lines a bit shorter.
      
      	* gdk/x11/gdkkeys-x11.c: Fix #endif with trailing stuff.
      42cc312d
    • Owen Taylor's avatar
      Fix return value to be G_TYPE_BOOLEAN, not G_TYPE_INT, also, use · cdd15272
      Owen Taylor authored
      Thu May  3 08:10:54 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtktexttag.c (gtk_text_tag_class_init): Fix return
      	value to be G_TYPE_BOOLEAN, not G_TYPE_INT, also,
      	use _gtk_boolean_handled_accumulator.
      cdd15272
    • Owen Taylor's avatar
      Patch from Juan Pablo Mendoza Mendoza to fix things so clicking inside · 7e9df644
      Owen Taylor authored
      Thu May  3 07:00:09 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtktextview.c: Patch from Juan Pablo Mendoza Mendoza
      	to fix things so clicking inside selection leaves cursor
      	at point where clicked. (#50324)
      
      	* gtk/gtksettings.c (gtk_settings_class_init): Restore
      	sane value for default double click time.
      
      	* tests/testtext.c (test_init): Really path to input modules.
      7e9df644
    • Sven Neumann's avatar
      include target-specific headers as done in testpixbuf-drawable.c · d0d9f644
      Sven Neumann authored
      2001-05-03  Sven Neumann  <sven@convergence.de>
      
              * demos/testpixbuf-save.c: include target-specific headers as
              done in testpixbuf-drawable.c
      d0d9f644
    • Owen Taylor's avatar
      Reduce new_text_length appropriately when we run into the size limit for · 4c2a74b7
      Owen Taylor authored
      Wed May  2 20:36:38 2001  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkentry.c (gtk_entry_real_insert_text): Reduce
      	new_text_length appropriately when we run into the
      	size limit for the entry. (#53445, reported by Jeff Franks)
      
      	* tests/testgtk.c (create_entry): Remove most of the
      	property toggle buttons. Replace with a "Props" button
      	that brings up a property editor.
      
      	* tests/prop-editor.[ch] test/testtreeview.c tests/Makefile.am:
      	Split the property editor code out for reuse, improve.
      4c2a74b7
  16. 02 May, 2001 2 commits