1. 13 Apr, 1998 2 commits
    • PDT 1998 Shawn T. Amundson's avatar
      Changed LGPL address for FSF in all .h and .c files · 92006c8e
      PDT 1998 Shawn T. Amundson authored
      Sun Apr 12 18:54:29 PDT 1998 Shawn T. Amundson <amundson@gtk.org>
      
              * Changed LGPL address for FSF in all .h and .c files
      92006c8e
    • Owen Taylor's avatar
      Set a flag so instead of clearing the area in advance. That looked · e6af5d49
      Owen Taylor authored
      Sun Apr 12 20:09:40 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtklabel.[ch] (gtk_label_expose): Set a flag so
      	instead of clearing the area in advance. That looked
      	_really_ bad.
      
      	* gtk/gtkcontainer.c (gtk_container_class_init): Changed
      	"focus" to RUN_LAST.
      
      	* gtk/gtkentry.c (gtk_entry_realize): Fixed place
      	where allocation was used where requisition was meant.
      	(Found by David J N Begley <david@avarice.nepean.uws.edu.au>)
      
      	* gtk/gtkwindow.c (gtk_window_set_default): Fixed
      	assertion in when setting default to NULL>
      	("Damon Chaplin" <DAChaplin@email.msn.com>)
      
      	* gtk/gtkwidget.c (gtk_widget_unparent): Unset the
      	default widget on the toplevel, if necessary.
      
      Sun Apr 12 02:04:21 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkpreview.c: Removed unecessary and harmful
      	htons/ntohs when storing properties. (X does the byte
      	swapping itself)
      e6af5d49
  2. 11 Apr, 1998 3 commits
  3. 10 Apr, 1998 1 commit
    • Owen Taylor's avatar
      Picky --enable-ansi cleanups. · 3a029481
      Owen Taylor authored
      Thu Apr  9 18:36:31 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkmisc.c gdk/gdkwindow gtk/gtkentry.c gtk/testgtk.c:
      	Picky --enable-ansi cleanups.
      
      	* gtk/gtkstatusbar.c (gtk_statusbar_pop): Pop top message
      	off _belonging_to_this_context_. (gtk-d4bjorn-980409-0)
      
      	From "Damon Chaplin" <DAChaplin@email.msn.com>
      
      	* gtk/gtktable.c (gtk_table_size_request_pass3): Small fix to size
      	requisition code.
      
      	* gtk/gtknotebook.c: Make sure not to do things to page->tab_label
      	if it doesn't exist.
      3a029481
  4. 09 Apr, 1998 3 commits
    • Owen Taylor's avatar
      (Found by Mattias.Gronlund" <Mattias.Gronlund@sa.erisoft.se>) · 26df647a
      Owen Taylor authored
      Thu Apr  9 14:24:35 1998  Owen Taylor  <owt1@cornell.edu>
      
      	(Found by Mattias.Gronlund" <Mattias.Gronlund@sa.erisoft.se>)
      
      	* gtk/gtkcurve.c (gtk_curve_interpolate): Added a
      	missing g_free.
      
      	* gtk/gtkcurve.c (gtk_curve_graph_events): Limits
      	were off by one, resulting in writing past array
      	bounds. Removed some unused code.
      
      	* gdk/gdk.c (gdk_dnd_drag_begin): The event structure
      	used for gdk_event_put should be a GdkEvent, not a
      	subtype, since it will all be copied.
      
      	* gtk/gtkcolorsel.c: Added a unrealize handler that
      	unref's the GC's that were created.
      
      	* gtk/testgtk.c (clist_warning_test): ref and sink
      	child because it may never be added to anything.
      26df647a
    • Elliot Lee's avatar
      Combobulator fixes..... .... · 2a2323d6
      Elliot Lee authored
      
      
      Combobulator fixes.....
      ....
      
      .....
      
      
      ......
      
      
      
      .......
      
      
      
      ........
      
      April fools! ;-)
      2a2323d6
    • Owen Taylor's avatar
      Removed unsed variables (gtk-jbuhler-980408-0) · 3a1eebe6
      Owen Taylor authored
      Wed Apr  8 20:50:02 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkwindow.c (gtk_window_set_hints): Removed unsed
      	variables (gtk-jbuhler-980408-0)
      3a1eebe6
  5. 08 Apr, 1998 2 commits
  6. 07 Apr, 1998 4 commits
    • Owen Taylor's avatar
      Removed, because that's what a NULL comparison function means. And it · 1c77b5f9
      Owen Taylor authored
      Tue Apr  7 19:36:48 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gutils.c (g_direct_compare): Removed, because that's what
      	a NULL comparison function means. And it wasn't 64 bit safe.
      
      Tue Apr  7 19:14:03 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gdk/gdkpixmap.c: Added maximum field widths to prevent
      	possible '%s' scanf overflows. Replaced scanf("%c")
      	with getc(), Don't interpret /*/ as a full comment. Use
      	g_realloc/g_new.
      
      	* gtk/gtkwidget.h gtk/gtkprivate.h: Changed all flag
      	tests to check for ((GTK_WIDGET_FLAGS(widget) & FLAG) != 0)
      	instead of (GTK_WIDGET_FLAGS(widget) & FLAG)
      
      	* gtk/gtkfilesel.c: Use getwd() instead of getcwd() on
      	SunOS, because getcwd() hangs up in a wait4().
      	(Found by David Monniaux <monniaux@clipper.ens.fr>)
      
      	- Check device/inode/mtime not just inode/mtime, when
      	caching scanned directories.
      	(From: scottk@ig.utexas.edu (Scott Kempf))
      
      	* gdk/gdkpixmap.c: Check for 0 width/height when
      	creating pixmaps.
      
      	* gtk/*.c: Global substitution of recently introduced
      	"MAX (0," for allocations to "MAX (1,", since
      	creating a backing pixmap with a zero width or height
      	fails.
      
      	* gdk/gdkwindow.c (gdk_window_new): Don't set all the
      	WM properties for child windows. Don't set the base
      	size, since the value we set will be taken as a minimum
      	size.
      1c77b5f9
    • Tim Janik's avatar
      don't take '\n' into account for size computation (Damon Chaplin). · 13de9dc3
      Tim Janik authored
      Wed Apr  8 00:00:48 1998  Tim Janik  <timj@gtk.org>
      
              * gtk/gtklabel.c (gtk_label_expose): don't take '\n' into account for
                      size computation (Damon Chaplin).
      
                              * gtk/gtkvscale.c (gtk_vscale_draw_value): adjusted static snprintf()
                                      buffer size to 32 characters (Damon Chaplin).
                                              * gtk/gtkhscale.c (gtk_hscale_draw_value): likewise.
      
                                                      * gtk/gtkmain.c (gtk_main_iteration_do): gdk_flush() the X-queue if
                                                              iteration_done==TRUE since we will most likely not get invoked again
                                                                      (Marius Vollmer).
      13de9dc3
    • Elliot Lee's avatar
      gtk_button_remove(): When removing a child widget from a button, we don't · 39a05c0b
      Elliot Lee authored
      
      
      gtk_button_remove():
      	When removing a child widget from a button, we don't want to check
      	the child's visibility after removal (for the purpose of knowing
      	whether a queue_resize is needed), we want to check it *before*,
      	because the child may be destroyed during the
      	gtk_widget_unparent()
      
      	The diff is clearer than this stupid log message. :)
      39a05c0b
    • Owen Taylor's avatar
      Set the window hints on every map so that GTK_WIN_POS_MOUSE works · 8051b9d2
      Owen Taylor authored
      Mon Apr  6 23:48:29 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkwindow.c (gtk_window_realize): Set the
      	window hints on every map so that GTK_WIN_POS_MOUSE
      	works correctly.
      8051b9d2
  7. 06 Apr, 1998 4 commits
    • Federico Mena Quintero's avatar
      Added function to set the homogeneous flag of the table (needed by derived · 30533f03
      Federico Mena Quintero authored
      1998-04-06  Federico Mena Quintero  <federico@nuclecu.unam.mx>
      
      	* gtk/gtktable.h:
      	* gtk/gtktable.c (gtk_table_set_homogeneous): Added function to
      	set the homogeneous flag of the table (needed by derived widgets
      	and such).
      
      1998-04-03  Federico Mena Quintero  <federico@nuclecu.unam.mx>
      
      	* gtk/gtkradiobutton.h: Add prototype for gtk_radio_button_new_with_label_from_widget.
      30533f03
    • Owen Taylor's avatar
      Take border in account properly. · 0f9fe897
      Owen Taylor authored
      Mon Apr  6 08:05:23 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkbutton.c (gtk_button_paint): Take border in
      	account properly.
      
      	* gtk/gtktext.c (gtk_text_realize): Don't recompute
      	geometry when creating with initial 1x1 geometry,
      	since our calculations can't handle that. Leave
      	text->line_start_cache NULL as sign we don't have
      	a real geometry yet.
      
      	* gtk/gtkentry.c (gtk_entry_motion_notify): Use the x
      	value we get from gdk_window_get_pointer, not from
      	event->x - since we always specify OwnerGrabButtonMask
      	(why???), event->x can refer to another window.
      0f9fe897
    • Owen Taylor's avatar
      Make tab key move in reading order (left-to-right top to bottom) - which · 61ca2419
      Owen Taylor authored
      Mon Apr  6 00:28:28 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkcontainer.c (gtk_container_focus_tab): Make
      	tab key move in reading order (left-to-right top
      	to bottom) - which might have been the original intended
      	behavior modulo sorting bugs.
      
      	* gtk-config.in: Never output -I/usr/include from --cflags
      61ca2419
    • Owen Taylor's avatar
      Fixed bug where right justified menu would overlap last left justified · 79d880cc
      Owen Taylor authored
      Sun Apr  5 21:47:12 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkmenubar.c: Fixed bug where right justified
      	menu would overlap last left justified item.
      79d880cc
  8. 05 Apr, 1998 4 commits
    • Owen Taylor's avatar
      Fixed assignment of adjustment->value to negative values. Moved a few · 20fee708
      Owen Taylor authored
      Sun Apr  5 19:30:23 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkclist.c: Fixed assignment of adjustment->value
      	to negative values. Moved a few other allocation type things
      	around in ways that may or may matter. Fixed some allocation
      	errors (scrollbars were overlapping main window).
      
      	* gtk/gtkbutton.c (gtk_real_button_released): Small hack to keep
      	button labels from vanishing when the invoked operation blocks.
      
      	* gtk/gtkbox.c (gtk_box_remove): Assigning GTK_WIDGET_VISIBLE (widget)
      	to a gboolean (char) is _bad_. GTK_VISIBLE == 256.
      20fee708
    • Owen Taylor's avatar
      Reverted broken implementation of removing the current timeout/idle. · 1a099c2c
      Owen Taylor authored
      Sun Apr  5 15:08:25 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkmain.c: Reverted broken implementation of removing
      	the current timeout/idle. Substituted a (hopefully) functional one.
      1a099c2c
    • Tim Janik's avatar
      take expired timeouts into account, otherwise things like e.g. · ab798921
      Tim Janik authored
      Sun Apr  5 09:35:55 1998  Tim Janik  <timj@gtk.org>
      
              * gtk/gtkmain.c (gtk_events_pending): take expired timeouts into
                      account, otherwise things like e.g. spin-buttons don't work.
                              also, count gtk_main_quit() as an event.
      ab798921
    • Tim Janik's avatar
      fixed panel allocation and stacking order, fixed the base class · 6e28c400
      Tim Janik authored
      Sun Apr  5 08:03:01 1998  Tim Janik  <timj@gtk.org>
      
              * gtk/gtkspinbutton.c: fixed panel allocation and stacking order,
                      fixed the base class realization.
      
                              * gtk/gtkmisc.c: implemented widget arguments.
      
                                      * gtk/gtkentry.c: fixes in _realize to behave similar to
                                              _size_allocate.
      6e28c400
  9. 04 Apr, 1998 4 commits
  10. 03 Apr, 1998 1 commit
    • Owen Taylor's avatar
      More extensive debugging output · 32cd050c
      Owen Taylor authored
      Fri Apr  3 17:14:55 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gdk/gdk.c: More extensive debugging output
      
      	* gtk/gtkalignment.c gtk/gtkbutton.c gtk/gtkcheckbutton.c
      	  gtk/gtkclist.c gtk/gtkeventbox.c gtk/gtkhandlebox.c
      	  gtk/gtk[hv]box.c gtk/gtk[hv]paned.c gtk/gtklist.c
      	  gtk/gtkmenu.c gtk/gtkmenubar.c gtk/gtkmenuitem.c
      	  gtk/gtknotebook.c gtk/gtktable.c gtk/gtktree.c
      	  gtk/gtktreeitem.c gtk/gtkviewport.c
      
      	Avoid assigning negative values to unsigned allocation.width and
      	height
      
      	* gtk/gtkwindow.c:
      
      	Instead of realizing the widget, then size allocating, (resulting
      	in XMoveResizeWindows for all children, do the size allocation
      	first, then realize.
      
      	In gtk_real_window_move_resize, combine move and resize
      	into a single GDK/X call when possible.
      
      	* gtk/gtkclist.c gtk/gtkdrawingarea.c:
      
      	Remove assumption that the widget will be size allocated _after_
      	it is realized.
      
      	* gtk/gtklist.c (gtk_list_motion_notify): Removed useless
      	debugging message.
      32cd050c
  11. 31 Mar, 1998 3 commits
  12. 30 Mar, 1998 2 commits
    • Owen Taylor's avatar
      Improved main loop test. (Quits main loop properly, makes it more obvious · 4bf5d761
      Owen Taylor authored
      Mon Mar 30 16:35:57 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/testgtk.c: Improved main loop test. (Quits main
      	loop properly, makes it more obvious to the user
      	what is going on)
      
      	* gtk/gtkwidget.c (gtk_widget_unparent): Reset the
      	allocation _after_ clearing the window.
      
      	* configure.in: If can't find XShmAttach in Xext, check
      	in XextSam (for AIX).
      
      	* gtk/gtkmain.c (gtk_events_pending): Remember, small
      	numbers are _high_ priority for idle queues.
      
      	* gtk/gtkmain.c (gtk_handle_current_timeouts): Allow
      	removing the currently running timeout.
      
      	* gtk/testgtk.c (timeout_test): Use the right prototype
      	for callback.
      4bf5d761
    • Tim Janik's avatar
      removed this function, it was unneeded and not exported. · 8eb7761e
      Tim Janik authored
      Mon Mar 30 21:40:21 1998  Tim Janik  <timj@gtk.org>
      
              * gtk/gtkclist.c (gtk_clist_row_from_ypixel): removed this function,
                      it was unneeded and not exported.
      
                              * gtk/gtkwidget.c (gtk_widget_ref) (gtk_widget_unref): don't check-cast
                                      the widgets to volatile GtkObjects (which was there for debugging
                                              purposes only). these functions should probably be macros, but that
                                                      would break binary compatibility again, sigh.
                                                              (gtk_widget_destroy): removed superfluous check-casts, since the
                                                                      neccessary checks are done in gtk_object_destroy anyways. this should
                                                                              be a macro as well but stays as a function for the above reasoonings.
      8eb7761e
  13. 29 Mar, 1998 2 commits
    • Tim Janik's avatar
      Added wrapping capabilities to GtkSpinButton. New function : · 2f5621e5
      Tim Janik authored
      Sun Mar 29 22:29:00 1998  Tim Janik  <timj@gtk.org>
      
              * gtk/gtkspinbutton.[ch] gtk/testgtk.c (gtk_spin_button_set_wrap):
                      Added wrapping capabilities to GtkSpinButton. New function :
                              gtk_spin_button_set_wrap (Lars Hamann and Stefan Jeske).
      2f5621e5
    • Owen Taylor's avatar
      Disconnect from combo->entry, not combo. (From: Daniel Skarda · 93e15856
      Owen Taylor authored
      Sat Mar 28 21:18:42 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkcombo.c (gtk_combo_disable_activate):
      	Disconnect from combo->entry, not combo.
      	(From: Daniel Skarda <0rfelyus@atrey.karlin.mff.cuni.cz>)
      
      	* gdk/gdkpixmap.c (gdk_pixmap_colormap_create_from_xpm): Deal
      	better with xpm's with bad colors in them.
      
      Plus, 3rd attempt to commit gtklabel changes
      93e15856
  14. 28 Mar, 1998 1 commit
    • Owen Taylor's avatar
      Don't clear the window on an expose event. On draws, just clear the · b2c30ad9
      Owen Taylor authored
      Fri Mar 27 17:58:41 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkhandlebox.c (gtk_handle_box_paint): Don't clear
      	the window on an expose event. On draws, just clear the
      	portion we are redrawing.
      
      	* gdk/gdkfont.c (gdk_fontset_load): Corrected calculation
      	of fontset ascent/descent.
      
      	* gtk/gtkwidget.[ch]: Added new function to show a toplevel
      	window and wait for it to be mapped, gtk_window_show_now ()
      b2c30ad9
  15. 27 Mar, 1998 2 commits
    • Owen Taylor's avatar
      Missed one · f2cfc17b
      Owen Taylor authored
      f2cfc17b
    • Owen Taylor's avatar
      If the widget is _not_ a descendant of a Window widget, propagate key · e0ea1f0c
      Owen Taylor authored
      Fri Mar 27 00:13:18 1998  Owen Taylor  <owt1@cornell.edu>
      
      	* gtk/gtkmain.c (gtk_propagate_event): If the widget is _not_
      	a descendant of a Window widget, propagate key presses like
      	other events.
      
      	* gtk/gtkentry.c gtk/gtktext.c: Ignore multiple simultaneous
      	button presses instead of treating subsequent presses as
      	release/press pairs for tablet compatibility.
      
      	* configure.in config.h.in: Removed inline checks, because they
      	are duplicated in glib.
      
      	* gtk/gtkwidget.c (gtk_widget_draw): When gtk_widget_draw ()
      	occurs with queued draw already in place, redraw _entire_
      	widget. (Pointed out by Tim Janik)
      e0ea1f0c
  16. 26 Mar, 1998 2 commits
    • Tim Janik's avatar
      make a clear distinction between key press/release events, which will be · 11f79ebe
      Tim Janik authored
      Thu Mar 26 23:12:54 1998  Tim Janik  <timj@gtk.org>
      
              * gtk/gtkmain.c (gtk_propagate_event): make a clear distinction between
                      key press/release events, which will be sent to a widgets toplevel
                              ancestor and be forwarded from there, and all other events that need to
                                      get propagated up the widget tree (pointed out by Owen Taylor).
      11f79ebe
    • Tim Janik's avatar
      always display the correct active state. · c2906f2b
      Tim Janik authored
      Thu Mar 26 21:37:57 1998  Tim Janik  <timj@gtk.org>
      
              * gtk/gtkradiobutton.c (gtk_radio_button_draw_indicator): always
                      display the correct active state.
      
                              * gtk/gtkcheckbutton.c (gtk_real_check_button_draw_indicator): always
                                      display the correct active state.
      
                                              * gtk/gtkwidget.c (gtk_widget_set_arg): CAN_FOCUS and CAN_DEFAULT flag
                                                      changes need to queue a resize.
      
                                                              * gtk/gtkbutton.c (gtk_button_paint): take border_width into
                                                                      consideration for restrict area.
      
                                                                              * gtk/gtktogglebutton.c (gtk_toggle_button_class_init): enable the
                                                                                      draw_default member of GtkButton, otherwise the diplay is messed up
                                                                                              for CAN_DEFAULT toggles.
                                                                                                      (gtk_toggle_button_draw_focus): always display whether the toggle button
                                                                                                              is active or not.
      
                                                                                                                      * gtk/gtkwidget.c (gtk_widget_set_state):
                                                                                                                              (gtk_widget_set_sensitive):
                                                                                                                                      (gtk_widget_set_parent):
                                                                                                                                              (gtk_widget_propagate_state): take into consideration, whether we really
                                                                                                                                                      want to change childrens states, or just restauration of old states.
      c2906f2b