-
Daniel Boles authored
Bad actors, such as our very own FileChooserButton, may connect to the :popped-up property and alter the model as the menu becomes in/visible. We were getting an iter to the model while popped-up, then doing popdown(), then using the iter, which may have just been invalidated by the errant notify::popped-up handler. If so, we quickly crash fatally. This is clearly bonkers, but until such patterns are removed, we have to work around them. So, set_active() from the clicked item while it is known to be valid, by moving the call to set_active() before popdown(). While here, change set_active_iter(iter) to set_active_internal(path) to avoid pointlessly going through the iter to get the path we already have https://bugzilla.gnome.org/show_bug.cgi?id=729651
696b9a5d