1. 10 Nov, 2005 7 commits
    • Matthias Clasen's avatar
      Remove an erroneous semicolon. · 6556787e
      Matthias Clasen authored
      2005-11-10  Matthias Clasen  <mclasen@redhat.com>
      
      	* gdk/x11/gdkcolor-x11.c (gdkx_colormap_get): Remove an erroneous
      	semicolon.
      6556787e
    • Matthias Clasen's avatar
      Don't corrupt odd keymaps (#316638, Kean Johnston) · 83e2e23f
      Matthias Clasen authored
      2005-11-10  Matthias Clasen  <mclasen@redhat.com>
      
      	Don't corrupt odd keymaps (#316638, Kean Johnston)
      
      	* gdk/x11/gdkkeys-x11.c (set_symbol): Auxiliary function to
      	handle frobbing keymaps with odd numbers of syms/code.
      
      	* gdk/x11/gdkkeys-x11.c (update_keymaps): Use set_symbol() to
      	frob the keymap.
      83e2e23f
    • Matthias Clasen's avatar
      Improve navigation to parent folders. (#318444, Andrei Yurkevich) · 938d34c0
      Matthias Clasen authored
      2005-11-10  Matthias Clasen  <mclasen@redhat.com>
      
      	Improve navigation to parent folders.  (#318444, Andrei Yurkevich)
      
      	* gtk/gtkpathbar.[hc]: Add a child_path argument to
      	the path_clicked signal.
      	* gtk/gtkfilechooserdefault.c (path_bar_clicked): Select the
      	child_path, if it is provided.
      	* gtk/marshalers.list (path_bar_clicked): Add the necessary
      	glue.
      938d34c0
    • Matthias Clasen's avatar
      Fix some compiler warnings. (#321141, Kjartan Maraas) · 14c284c3
      Matthias Clasen authored
      2005-11-10  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkmenu.c: Fix some compiler warnings. (#321141,
      	Kjartan Maraas)
      14c284c3
    • Matthias Clasen's avatar
      Implement a getter for headers-clickable. (#163851, Richard Hult) · cfd7c13b
      Matthias Clasen authored
      2005-11-10  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktreeview.c: Implement a getter for headers-clickable.
      	(#163851, Richard Hult)
      cfd7c13b
    • Michael Natterer's avatar
      Applied patch from maemo-gtk that addresses many issues wrt display · 8bdc0bf9
      Michael Natterer authored
      2005-11-10  Michael Natterer  <mitch@imendio.com>
      
      	Applied patch from maemo-gtk that addresses many issues wrt
      	display migration and display closing (bug #85715).
      
      	* gdk/gdkdisplay.c (gdk_display_dispose): don't just set the
      	default display to NULL when it's closed. Instead set the most
      	recently opened display as new default (if one exists).
      
      	* gdk/gdkpango.c (on_renderer_display_closed): fixed signature
      	of this callback.
      
      	* gdk/gdkscreen.c (gdk_screen_dispose): check if the GCs still
      	exist before unrefing them.
      
      	* gdk/gdkwindow.c (_gdk_window_destroy_hierarchy): if the screen
      	is closed, allow destruction of the root window.
      
      	* gdk/x11/gdkdisplay-x11.c: moved some stuff from finalize() to
      	dispose(), free stuff that was leaked before.
      
      	* gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen): check if
      	the xsettings_client still exists before destroying it.
      
      	* gdk/x11/gdkkeys-x11.c: added finalization and free the allocated
      	X resources.
      
      	* gdk/x11/gdkpixmap-x11.c: moved stuff from finalize() to new
      	dispose() implementation.
      
      	* gdk/x11/gdkscreen-x11.c: moved stuff from finalize() to
      	dispose() and check if it still exists before unrefing it. Set
      	their pointers to NULL/None *after* upchaining in dispose(),
      	because X11 implementations of members of the parent class still
      	need them for their own destruction.
      
      	* gdk/x11/gdkvisual-x11.c: removed finalize() implementation which
      	was g_error()ing when finalizing a visual.
      
      	* gtk/gtkclipboard.c (gtk_clipboard_finalize): don't use
      	get_clipboard_widget() because it would create the widget if it
      	doesn't exist. Use g_object_get_data() directly instead.
      
      	* gtk/gtktextdisplay.c (on_renderer_display_closed): fixed signature
      	of this callback.
      8bdc0bf9
    • Simos Xenitellis's avatar
      1571574c
  2. 09 Nov, 2005 4 commits
    • Tim Janik's avatar
      patch from maemo-gtk that changes GtkRange to render its arrows · 401468a9
      Tim Janik authored
      Wed Nov  9 16:29:42 2005  Tim Janik  <timj@imendio.com>
      
              * gtk/gtkrange.c: patch from maemo-gtk that changes GtkRange
              to render its arrows insensitive when the adjustment is in
              its min or max position. this makes range arrow behaviour
              consistent with spin button behaviour. (#321056)
      401468a9
    • Tor Lillqvist's avatar
      gdk/gdkinternals.h Add new GDK_DEBUG_DRAW flag to the GdkDebugFlag enum. · 3b9a63ec
      Tor Lillqvist authored
      2005-11-09  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/gdkinternals.h
      	* gdk/gdk.c (gdk_debug_keys[]): Add new GDK_DEBUG_DRAW flag to
      	the GdkDebugFlag enum.
      
      	* gdk/win32/gdkdrawable-win32.c: Use DRAW to trigger GDK_NOTEs in
      	this file instead of MISC. Now asking for MISC will give mainly
      	window manipulation debugging output.
      3b9a63ec
    • Tor Lillqvist's avatar
      Remove unnecessary includes. · 9b5c5f9d
      Tor Lillqvist authored
      2005-11-09  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkwindow-win32.c: Remove unnecessary includes.
      
      	(_gdk_win32_get_adjusted_client_rect): Remove this two-line
      	function which was used only in one place.
      
      	(get_outer_rect): Use _gdk_win32_adjust_client_rect().
      
      	(gdk_window_set_geometry_hints): If we have identical minimum and
      	maximum size hints, remove the resize and maximize
      	decorations/functions. (#104514)
      
      	If we have a maximum size hint, remove the maximize
      	decoration/function but ensure the resize decoration/function is
      	available. Otherwise ensure both resize and maximize
      	decorations/functions are there.
      
      	(set_or_clear_style_bits): Factored out common code from
      	gdk_window_set_decorations() and gdk_window_set_functions().
      
      	Hack the window style setting once more: Only touch the window
      	style bits corresponding to the GdkWMDecoration or GdkWMFunction
      	parameter bitmasks. Hopefully this finally is the correct thing to
      	do. We used to clear all other bits than those that were being
      	set, or set all other bits than those that were being cleared.
      
      	Take into account that adding or removing decorations leaves the
      	window's outer size unchanged, i.e., the client area's size and
      	position change. This is apparently not what we want, so change
      	also the window's (outer) position and size appropriately so that
      	the client area's position and size stay constant.
      
      	gtk-demo's color selector dialog is now non-resizable like on X11
      	(I tested with metacity in GNOME). Torn off menus are shrinkable
      	vertically but have a maximum size, and are not maximizable or
      	minimizable, like on X11.
      
      	(gdk_window_set_decorations, gdk_window_set_functions): Let
      	set_or_clear_decorations() do most of the job.
      
      	* gdk/win32/gdkprivate-win32.h: Remove declaration of
      	_gdk_win32_get_adjusted_client_rect().
      9b5c5f9d
    • Tor Lillqvist's avatar
      gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32) Store the type · 64f1e837
      Tor Lillqvist authored
      2005-11-09  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkwindow-win32.h (struct _GdkWindowImplWin32)
      	* gdk/win32/gdkwindow-win32.c (gdk_window_impl_win32_init,
      	gdk_window_get_type_hint, gdk_window_get_type_hint): Store the
      	type hint. Implement gdk_window_get_type_hint() by just returning
      	the hint stored.
      64f1e837
  3. 08 Nov, 2005 4 commits
  4. 07 Nov, 2005 8 commits
  5. 06 Nov, 2005 3 commits
    • Michael Natterer's avatar
      fixed rule to actually create the symlinks, erroring out if anything goes · 097038c3
      Michael Natterer authored
      2005-11-06  Michael Natterer  <mitch@imendio.com>
      
      	* gtk/Makefile.am (icons): fixed rule to actually create the
      	symlinks, erroring out if anything goes wrong.
      097038c3
    • Tor Lillqvist's avatar
      Can't rename a file if the target exists on Win32. First rename the target · 30edb631
      Tor Lillqvist authored
      2005-11-06  Tor Lillqvist  <tml@novell.com>
      
      	* gtk/updateiconcache.c (build_cache): Can't rename a file if the
      	target exists on Win32. First rename the target temporarily, then
      	if the renaming of the source to target fails, restore the
      	original name for the target.
      
      	* gtk/Makefile.am: Use EXEEXT in the dependency on gtk-update-icon-cache.
      30edb631
    • Tor Lillqvist's avatar
      (pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap, like · bd9e367d
      Tor Lillqvist authored
      2005-11-06  Tor Lillqvist  <tml@novell.com>
      
      	(pixbuf_to_hbitmaps_alpha_winxp): Use an 1-bit mask bitmap,
      	like pixbuf_to_hbitmaps_normal().
      	(_gdk_win32_pixbuf_to_hicon_supports_alpha): Check
      	G_WIN32_IS_NT_BASED() first, so we can pretend being on Win9x by
      	setting the G_WIN32_PRETEND_WIN9X environment variable.
      
      2005-11-06  Tor Lillqvist  <tml@novell.com>
      
      	Make icon masks work on Win98 (#320152, Peter Zelezny)
      
      	* gdk/win32/gdkcursor-win32.c (create_color_bitmap): Take also a
      	parameter for the depth of the bitmap, so that this function can
      	be used to create 1-bit bitmaps, too.
      	(pixbuf_to_hbitmaps_normal): Create an 1-bit bitmap for the mask,
      	and initialize it properly.
      bd9e367d
  6. 04 Nov, 2005 3 commits
    • Matthias Clasen's avatar
      Store builtin stock icons in an icon cache, instead of populating a hash · b983d1c6
      Matthias Clasen authored
      2005-11-04  Matthias Clasen  <mclasen@redhat.com>
      
              Store builtin stock icons in an icon cache, instead of
              populating a hash table with pixbufs at startup, to save both
              memory and startup time.
      
              * gtk/stock-icons/*: Reorganize the icons in a directory structure
              suitable for gtk-update-icon-cache, and rename them to match the
              stock ids.
      
              * gtk/gtkiconcache.[hc]: Support non-mmapped icon caches, and
              add _gtk_icon_cache_has_icon_in_directory().
      
              * gtk/updateiconcache.c: Support a --source <VARIABLE> argument
              to store the contents of the icon cache in a C header.
      
              * gtk/gtkbuiltincache.h: Generated private header which contains
              the icon cache for the builtin icons.
      
              * gtk/gtkicontheme.c: Create a GtkIconCache for the builtin
              icons, and use that in addition to the hash table whenever
              builtin icons are searched.
      
              * gtk/gtkiconfactory.c: Add GTK_ICON_SOURCE_STATIC_ICON_NAME and
              use it for static stock ids.
              (get_default_icons): Don't add the builtin
              icons to the icon theme, just register the stock ids.
              (render_fallback_image): Take the fallback image out of the
              builtin icon cache.
      
              * gtk/Makefile.am: Remove stock-icons from SUBDIRS and add
              the necessary machinery to rebuild gtkbuiltincache.h.
      b983d1c6
    • Michael Natterer's avatar
      applied patch from maemo-gtk that changes the mtime check for rc files · e087a3bc
      Michael Natterer authored
      2005-11-04  Michael Natterer  <mitch@imendio.com>
      
      	* gtk/gtkrc.c (gtk_rc_reparse_all_for_settings): applied patch
      	from maemo-gtk that changes the mtime check for rc files from
      	'>' to '!=', otherwise theme changes go unnoticed when turning
      	back the clock (Tommi Komulainen).
      e087a3bc
    • Tor Lillqvist's avatar
      Plug memory leak on Win32. · 36e1f67a
      Tor Lillqvist authored
      2005-11-04  Tor Lillqvist  <tml@novell.com>
      
      	* gtk/gtkstatusicon.c (gtk_status_icon_set_tooltip): Plug memory
      	leak on Win32.
      36e1f67a
  7. 03 Nov, 2005 6 commits
    • Tor Lillqvist's avatar
      Typo. · 3f49474e
      Tor Lillqvist authored
      3f49474e
    • Tor Lillqvist's avatar
      Formatting fix. · 5dbd2b16
      Tor Lillqvist authored
      5dbd2b16
    • Tor Lillqvist's avatar
      As there is only one GdkDisplay in the Win32 backend, check that · 72ea12fe
      Tor Lillqvist authored
      2005-11-03  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkcursor-win32.c: As there is only one GdkDisplay in
      	the Win32 backend, check that GdkDisplay* parameters are equal to
      	_gdk_display instead of using the unnecessarily general
      	GDK_IS_DISPLAY().
      72ea12fe
    • Tor Lillqvist's avatar
      Rename the variables for the color bitmap to have "color" in their name, · 5551fc67
      Tor Lillqvist authored
      2005-11-03  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkcursor-win32.c (pixbuf_to_hbitmaps_alpha_winxp):
      	Rename the variables for the color bitmap to have "color" in their
      	name, for similarity with pixbuf_to_hbitmaps_normal(). Create a
      	color bitmap for the mask, too, instead of creating a b&w bitmap
      	with CreateBitmap(). Set up the mask bitmap's contents, ones for
      	those pixels in the color bitmap where the alpha is zero, zero for
      	other pixels. We used to use an unitialized mask bitmap! This
      	meant that icons and cursors created presumably worked more or
      	less by accident. Totally blank icons with zero alpha everywhere
      	(as used by gtktrayicon.c) definitely did not work as expected.
      5551fc67
    • Tor Lillqvist's avatar
      Include gtkstatusicon.c on all platforms. · 3d18823a
      Tor Lillqvist authored
      2005-11-03  Tor Lillqvist  <tml@novell.com>
      
      	* gtk/Makefile.am: Include gtkstatusicon.c on all platforms.
      
      	* gtk/gtkstatusicon.c: Implement for Win32. Use code from
      	gtktrayicon-win32.c as applicable. (gtktrayicon-win32.c is not
      	necessary and can be removed from CVS. It has never been mentioned
      	in gtk/Makefile.am.) No tray icon widget, GtkImage or GtkTooltips
      	are used on Win32. One label widget is used (but never shown) as
      	gtk_widget_render_icon() needs a widget.
      
      	Ifdefs used as necessary in several places. It might be cleaner to
      	split out the backend-specific parts to separate files, or at
      	least collect them into separate blocks in the file.
      
      	(wndproc): New function. Window procedure to monitor mouse events
      	in the system tray icon. Call gtk_status_icon_button_press() as
      	needed.
      	(create_tray_observer): New function. Creates a hidden window that
      	only serves as a tray icon message observer.
      3d18823a
    • Tor Lillqvist's avatar
      Position the dialog with GTK_WIN_POS_CENTER. (do_quit): New function, hide · 542aedc1
      Tor Lillqvist authored
      2005-11-03  Tor Lillqvist  <tml@novell.com>
      
      	* tests/teststatusicon.c (icon_activated): Position the dialog
      	with GTK_WIN_POS_CENTER.
      	(do_quit): New function, hide and unref the GtkStatusIcon, and
      	call gtk_main_quit().
      	(popup_menu): Add a Quit menu item that calls do_quit().
      542aedc1
  8. 02 Nov, 2005 3 commits
    • Tor Lillqvist's avatar
      gdk/win32/gdkcolor-win32.c gdk/win32/gdkscreen-win32.c Whitespace · c2c55f83
      Tor Lillqvist authored
      2005-11-02  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkcolor-win32.c
      	* gdk/win32/gdkscreen-win32.c
      	* gdk/win32/gdkwindow-win32.c: Whitespace consistency
      	fixes. Remove superfluous test for GdkWindow* parameters being
      	non-NULL. Testing GDK_IS_WINDOW() is enough. As there is only one
      	GdkScreen and one GdkDisplay in the Win32 backend, use those
      	variables instead of the getter functions. For GdkDisplay* and
      	GdkScreen* parameters, check that they are equal to the
      	corresponding singleton variables instead of the more general
      	GDK_IS_DISPLAY() or GDK_IS_SCREEN().
      c2c55f83
    • Matthias Clasen's avatar
      Remove some g_return_if_fail() from static functions, replace some others · aa70008f
      Matthias Clasen authored
      2005-11-02  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktextview.c: Remove some g_return_if_fail() from
      	static functions, replace some others by g_assert().
      
      	* gtk/gtktextview.c (selection_motion_event_handler)
      	(gtk_text_view_start_selection_drag): Keep track of the original
      	selection boundaries during a drag selection, in order to correctly
      	decide when to extend or shrink the selection.  (#320167,
      	reported by Arvind S N, patch by Paolo Borelli)
      aa70008f
    • Matthias Clasen's avatar
      Replace manual offset calculations by g_utf8_offset_to_pointer(). · 6002bc65
      Matthias Clasen authored
      2005-11-02  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtktextbtree.c (_gtk_text_line_char_to_byte_offsets):
      	* gtk/gtktextiter.c (gtk_text_iter_backward_chars): Replace
      	manual offset calculations by g_utf8_offset_to_pointer().
      	(#320360, Paolo Borelli)
      6002bc65
  9. 01 Nov, 2005 2 commits
    • Tim Janik's avatar
      get rid of GAllocator usage, allocate and free nodes via the g_slice_*() · d6a9db90
      Tim Janik authored
      Tue Nov  1 16:18:24 2005  Tim Janik  <timj@imendio.com>
      
              * gtk/gtkrbtree.[hc]: get rid of GAllocator usage, allocate and free
              nodes via the g_slice_*() API.
              _gtk_rbtree_new(): fixed wrong node allocation via g_new().
      d6a9db90
    • Tor Lillqvist's avatar
      gdk/win32/gdkprivate-win32.h gdk/win32/gdkglobals-win32.c Add more · 4d1b5589
      Tor Lillqvist authored
      2005-11-01  Tor Lillqvist  <tml@novell.com>
      
      	* gdk/win32/gdkprivate-win32.h
      	* gdk/win32/gdkglobals-win32.c
      	* gdk/win32/gdkmain-win32.c (_gdk_windowing_init): Add more
      	pre-interned GdkAtoms and pre-registered clipboard formats. Sort
      	their declarations, definitions and assignments into a more
      	logical and consistent order.
      
      	* gdk/win32/gdkmain-win32.c (_gdk_win32_cf_to_string): Include the
      	CF_ prefix for the predefined clipboard format names. Put quotes
      	around registered format names to distinguish them.
      
      	* gdk/win32/gdkproperty-win32.c (gdk_property_change): Return
      	immediately with a warning if the property type is STRING, TEXT,
      	COMPOUND_TEXT or SAVE_TARGETS, as these are X11-specific that we
      	should never pretend to handle on Win32. Handle only UTF8_STRING
      	here, other formats with delayed rendering. Use \uc1 instead of
      	\uc0 when generating Rich Text Format for easier testability on
      	XP, where WordPad misinterprets \uc0 encoded characters. Add more
      	GDK_NOTE debugging output for Clipboard operations.
      
      	* gdk/win32/gdkselection-win32.c: Debugging printout improvements.
      	(gdk_selection_convert): Don't pretent to handle STRING, just
      	UTF8_STRING. Streamline error handling, don't unnecessarily have a
      	GError which then isn't used for anything anyway if it gets set.
      	(gdk_win32_selection_add_targets): Skip also STRING, TEXT,
      	COMPOUND_TEXT and SAVE_TARGETS in addition to UTF8_STRING.
      4d1b5589