1. 16 Mar, 2018 1 commit
    • Daniel Boles's avatar
      Notebook: Don’t show raw underline/markup in popup · 7fd9f2d3
      Daniel Boles authored
      If @menu_label == NULL, we create a default page->menu_label. This took
      @tab_label.get_label() and passed that to page->menu_label.set_text().
      This is wrong because we set the plain text of the menu_label from the
      rich text of @tab_label. So, if @tab_label used mnemonics or markup, our
      menu_label got the raw underline or markup tags shown in it as raw text.
      
      As we call set_text() on the menu Label, the fix is to be symmetric: use
      @tab_label’s get_text() as source, as that strips underlines and markup.
      
      It’s not worth making the default Label ‘inherit’ :use-underline/markup;
      that’s a slippery slope, and users wanting such things can just create a
      fully fledged GtkLabel to pass as @menu_label to suppress the default.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=705509
      7fd9f2d3
  2. 07 Jan, 2018 1 commit
  3. 12 Sep, 2017 1 commit
  4. 01 Aug, 2017 1 commit
    • Daniel Boles's avatar
      Notebook: Remove null check after dereference · a381a06b
      Daniel Boles authored
      This function clearly assumes the parameter children cannot be NULL, and
      the call sites seem to perform enough checks to confirm this.
      
      CID 1388869 (#1 of 1): Dereference before null check (REVERSE_INULL)
      check_after_deref: Null-checking children suggests that it may be null,
      but it has already been dereferenced on all paths leading to the check.
      a381a06b
  5. 18 Jul, 2017 1 commit
  6. 20 Mar, 2017 1 commit
  7. 04 Feb, 2017 1 commit
  8. 27 Jan, 2017 1 commit
  9. 24 Jan, 2017 1 commit
  10. 23 Nov, 2016 1 commit
  11. 07 Nov, 2016 1 commit
  12. 29 Aug, 2016 1 commit
  13. 24 Aug, 2016 1 commit
  14. 19 Jul, 2016 1 commit
  15. 06 Jun, 2016 1 commit
  16. 02 May, 2016 1 commit
    • Carlos Soriano's avatar
      gtknotebook: avoid tab dnd from content · ddb0740a
      Carlos Soriano authored
      Before commit 6c1bee23 we were setting an attribute of GtkNotebook
      to track the pressed button if the pressed button happened on the
      tab itself.
      Later in the motion handling code we were checking whether the private
      pressed button attribute was set or not in order to handle a tab dnd
      or not.
      
      In commit 6c1bee23 the code changed and set the pressed button
      variable unconditionally, which means, a motion event from within the
      tab content triggered a tab reordering.
      
      This happened only if the children hierarchy have a widget that bubbles
      up both button press event, which sets the private pressed button
      attribute; and motion events, which started the tab dnd checking the
      private pressed button attribute.
      A widget that experienced the regression was GtkListBox.
      
      In order to fix it, set the button pressed variable only when it press
      the tab itself, not the content.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=764395
      ddb0740a
  17. 29 Apr, 2016 1 commit
    • Matthias Clasen's avatar
      box gadget: Redo expand flag handling · 21487089
      Matthias Clasen authored
      We only keep one align flag per child, so it seems odd to
      keep separate h/v expand flags. Just keep one expand flag
      and interpret it according to orientation. Allow setting
      the expand flag for child widgets too, though, so we can
      make widget expand without interfering with the recursive
      widget expand flag.
      
      Update all callers.
      
      Use the new possibility of expanding child widgets to make
      the label of check and radio buttons expand. This fixes
      unexpected behavior of these widgets in RTL in some places.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=765742
      21487089
  18. 14 Mar, 2016 1 commit
  19. 29 Feb, 2016 2 commits
  20. 27 Feb, 2016 2 commits
    • Benjamin Otte's avatar
      boxgadget: Add ability to draw children in reverse · 245d217e
      Benjamin Otte authored
      This is necessary for GtkNotebook so that the stack is always drawn
      before the header.
      And that is necessary so that the active tab can use negative
      margins to overdraw the border of the stack to create a gap and
      simulate old GTK2-style visuals for notebooks.
      245d217e
    • Benjamin Otte's avatar
      notebook: The active tab is now :checked · cdb1cda6
      Benjamin Otte authored
      :active is reserved for "mouse button down on node", so we have to use
      something else. And stack switcher and radio buttons use :checked for
      the active widget, so it makes sense to use :checked for the active tab,
      too.
      
      Themes have been adapted.
      
      TODO: Implement :active for tabs.
      cdb1cda6
  21. 15 Feb, 2016 1 commit
    • Matthias Clasen's avatar
      notebook: Fix a misplaced tab label · cb43af09
      Matthias Clasen authored
      Sometimes default tab labels ("Page <n>") get created on-demand,
      and in that case, we were forgetting to put them below the tab
      node in the CSS node tree. The visible result of this is that the
      heuristics for when to give notebooks background in Adwaita fail
      in some cases. So, make sure to always place the label below the
      tab node.
      cb43af09
  22. 11 Feb, 2016 1 commit
  23. 08 Feb, 2016 1 commit
    • Timm Bäder's avatar
      Various documentation fixes · c5369356
      Timm Bäder authored
      Always have Since: annotations at the very bottom, use the correct
      ClassName::signal-name/ClassName:property-name syntax, fix a few typos
      in type names, wrong function names, non-existing type names, etc.
      c5369356
  24. 02 Feb, 2016 1 commit
  25. 23 Jan, 2016 1 commit
  26. 20 Jan, 2016 5 commits
  27. 18 Jan, 2016 1 commit
  28. 17 Jan, 2016 2 commits
  29. 15 Jan, 2016 2 commits
  30. 13 Jan, 2016 2 commits
  31. 12 Jan, 2016 1 commit