1. 29 Dec, 2003 1 commit
  2. 27 Dec, 2003 1 commit
  3. 26 Dec, 2003 1 commit
  4. 24 Dec, 2003 3 commits
  5. 21 Dec, 2003 4 commits
    • Matthias Clasen's avatar
      Use gtk_paint_arrow instead of draw_arrow_left/draw_arrow_right. Removed. · 5bacfe39
      Matthias Clasen authored
      Mon Dec 22 00:40:39 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcalendar.c (gtk_calendar_paint_arrow): Use
      	gtk_paint_arrow instead of draw_arrow_left/draw_arrow_right.
      	* gtk/gtkcalendar.c (draw_arrow_left):
      	(draw_arrow_right): Removed.
      	* gtk/gtkcalendar.c (gtk_calendar_realize_arrows):
      	* gtk/gtkcalendar.c (gtk_calendar_state_changed): Set the
      	arrow_state to GTK_STATE_INSENSITIVE if the calendar is
      	insensitive.  (#97376)
      5bacfe39
    • Matthias Clasen's avatar
      Fix memory leaks caused by the failure to free the result of · 6a6455d7
      Matthias Clasen authored
      Sun Dec 21 23:17:01 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkuimanager.c (update_node):
      	(update_smart_separators):
      	(_gtk_menu_is_empty):
      	(find_menu_position):
      	* gtk/gtktreeview.c (gtk_tree_view_search_dialog_destroy):
      	* gtk/gtkcombobox.c (gtk_combo_box_relayout_item):
      	(gtk_combo_box_relayout): Fix memory leaks caused by the
      	failure to free the result of gtk_container_get_children().
      	(#127576, Yao Zhang)
      6a6455d7
    • Soeren Sandmann's avatar
      Set the right properties when the window becomes a toplevel. When a window · d2e744ca
      Soeren Sandmann authored
      Sun Dec 21 17:34:22 2003  Soeren Sandmann  <sandmann@daimi.au.dk>
      
      	* gdk/x11/gdkwindow-x11.c (gdk_window_reparent): Set the right
      	properties when the window becomes a toplevel. When a window that
      	was previously a toplevel becomes a toplevel again, restore its
      	window type. Also make sure the focus window is removed from the
      	XID hash when it is destroyed. (#117579, reported by Morten
      	Welinder, patch reviewed by Owen Taylor).
      d2e744ca
    • Matthias Clasen's avatar
      New function to emit the "cancel" signal on a menu shell. · b21fe174
      Matthias Clasen authored
      Sun Dec 21 01:54:40 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkmenushell.h:
      	* gtk/gtkmenushell.c (gtk_menu_shell_cancel): New function
      	to emit the "cancel" signal on a menu shell.
      
      	* gtk/gtkmenu.c (gtk_menu_key_press):
      	* gtk/gtkoptionmenu.c (gtk_option_menu_remove_menu):
      	* gtk/gtkmenubar.c (_gtk_menu_bar_cycle_focus): Use the
      	new function instead of directly emitting the
      	signal.  (#81803, Owen Taylor)
      b21fe174
  6. 20 Dec, 2003 2 commits
  7. 19 Dec, 2003 7 commits
    • Kristian Rietveld's avatar
      Fixes #108458. · 2f4326e4
      Kristian Rietveld authored
      Fri Dec 19 23:36:00 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Fixes #108458.
      
      	* gtk/gtkcelllayout.[ch]: added a reorder method.
      
      	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_init),
      	(gtk_tree_view_column_cell_layout_reorder): implement reorder.
      
      	* gtk/gtkcellview.c (gtk_cell_view_cell_layout_init),
      	(gtk_cell_view_cell_layout_reorder): ditto.
      
      	* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_init),
      	(gtk_combo_box_cell_layout_reorder): ditto.
      
      	* gtk/gtkentrycompletion.c (gtk_entry_completion_cell_layout_init),
      	(gtk_entry_completion_reorder): ditto.
      2f4326e4
    • Kristian Rietveld's avatar
      use strstr instead of strcmp (#117127, suggestion from Soeren Sandmann). · 30d9f889
      Kristian Rietveld authored
      Fri Dec 19 22:18:19 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_search_equal_func): use strstr
      	instead of strcmp (#117127, suggestion from Soeren Sandmann).
      30d9f889
    • Kristian Rietveld's avatar
      move item insertion logic here from gtk_menu_real_insert(), · 8a834dce
      Kristian Rietveld authored
      Fri Dec 19 21:52:46 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkmenu.c (gtk_menu_do_insert): move item insertion logic
      	here from gtk_menu_real_insert(),
      	(gtk_menu_real_insert): just call gtk_menu_do_insert(),
      	(gtk_menu_reorder_child): run _do_insert after inserting the child
      	(unbreaks _reorder_child, reported by Tim Janik).
      8a834dce
    • Federico Mena Quintero's avatar
      Use g_date_strftime() for UTF-8 correctness; use Julian dates to simplify · f615072c
      Federico Mena Quintero authored
      2003-12-19  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (list_mtime_data_func): Use
      	g_date_strftime() for UTF-8 correctness; use Julian dates to
      	simplify the function.
      f615072c
    • Matthias Clasen's avatar
      Test extra_width, not extra_height, when determining whether to set · 31637e1f
      Matthias Clasen authored
      Fri Dec 19 01:47:34 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkscrolledwindow.c (gtk_scrolled_window_size_request):
      	Test extra_width, not extra_height, when determining whether to
      	set extra_width.  (#129647, Jan Arne Petersen)
      31637e1f
    • Matthias Clasen's avatar
      Add a bug number · d99c68a6
      Matthias Clasen authored
      d99c68a6
    • Matthias Clasen's avatar
      Fix the behaviour of insensitive actions, which was broken when · bc5d7efe
      Matthias Clasen authored
      Fri Dec 19 01:35:34 2003  Matthias Clasen  <maclas@gmx.de>
      
      	Fix the behaviour of insensitive actions, which was broken
      	when gtk_action_activate() was changed to pay attention to
      	sensitivity  (#129557, Christian Persch)
      
      	* gtk/gtkaction.h:
      	* gtk/gtkaction.c (_gtk_action_emit_activate): New auxiliary
      	function to emit an activate signal without regard to sensitivity.
      
      	* gtk/gtkradioaction.c:
      	* gtk/gtktoggleaction.c: Always use _gtk_action_emit_activate()
      	instead of gtk_action_activate().
      bc5d7efe
  8. 18 Dec, 2003 9 commits
    • Kristian Rietveld's avatar
      Fixes #110249, reworked patch from Joshua N Pritikin. · 4d9e9afd
      Kristian Rietveld authored
      Thu Dec 18 19:13:12 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Fixes #110249, reworked patch from Joshua N Pritikin.
      
      	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_get_type),
      	(gtk_tree_model_sort_tree_drag_source_init),
      	(gtk_tree_model_sort_row_draggable),
      	(gtk_tree_model_sort_drag_data_get),
      	(gtk_tree_model_sort_drag_data_delete): implement GtkTreeDragSource.
      
      	* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_get_type),
      	(gtk_tree_model_filter_tree_drag_source_init),
      	(gtk_tree_model_filter_row_draggable),
      	(gtk_tree_model_filter_drag_data_get),
      	(gtk_tree_model_filter_drag_data_delete): ditto.
      4d9e9afd
    • Kristian Rietveld's avatar
      add key bindings for "*" and "/" (expand/collapse all). (#110195, reported · dad34f29
      Kristian Rietveld authored
      Thu Dec 18 18:01:01 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_class_init): add key bindings
      	for "*" and "/" (expand/collapse all). (#110195, reported by
      	Calum Benson).
      dad34f29
    • Kristian Rietveld's avatar
      clear the extra_attrs list if we set "text" after "markup". (Fixes · 10b2c91b
      Kristian Rietveld authored
      Thu Dec 18 17:52:56 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_set_property):
      	clear the extra_attrs list if we set "text" after "markup".
      	(Fixes #121933, Federico Mena Quintero).
      10b2c91b
    • Alexander Larsson's avatar
      Fix typo that used the wrong x/y values for the x1, y1 point · 0fe8b2d6
      Alexander Larsson authored
      2003-12-18  Alexander Larsson  <alexl@redhat.com>
      
      	* gtk/gtkicontheme.c (gtk_icon_info_get_embedded_rect):
      	Fix typo that used the wrong x/y values for the x1, y1 point
      0fe8b2d6
    • Kristian Rietveld's avatar
      added language and language_set properties like GtkTextTag has. (#103800, · bc6e2d55
      Kristian Rietveld authored
      Thu Dec 18 01:41:50 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init),
      	(gtk_cell_renderer_text_finalize),
      	(gtk_cell_renderer_text_get_property),
      	(gtk_cell_renderer_text_set_property), (get_layout): added language
      	and language_set properties like GtkTextTag has. (#103800, reported
      	by Owen Taylor).
      bc6e2d55
    • Matthias Clasen's avatar
      Correct misleading docs. Add docs for the "activate" signal. (#129358, · 3050f437
      Matthias Clasen authored
      Thu Dec 18 01:37:59 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkwidget.c (gtk_widget_activate): Correct misleading docs.
      	* gtk/gtkbutton.c (gtk_button_class_init): Add docs for the
      	"activate" signal.  (#129358, Ka-Hing Cheung)
      3050f437
    • Kristian Rietveld's avatar
      Jonathan got the logical flag backwards in the expand_collapse_cursor_row · 66def989
      Kristian Rietveld authored
      Thu Dec 18 01:21:59 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_class_init): Jonathan got
      	the logical flag backwards in the expand_collapse_cursor_row
      	bindings, fixing.
      	(gtk_tree_view_real_expand_collapse_cursor_row): invert expand
      	flag when !logical and in RTL. (Fixes #107527, reported by
      	Noah Levitt).
      66def989
    • Kristian Rietveld's avatar
      only start editing when activated by the left mouse button. (#106869, · 0b3fa61b
      Kristian Rietveld authored
      Thu Dec 18 01:10:16 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): only start
      	editing when activated by the left mouse button. (#106869,
      	patch from Evan Martin).
      0b3fa61b
    • Kristian Rietveld's avatar
      Migrating all cell renderers to use the new instance private data · c43efa51
      Kristian Rietveld authored
      Thu Dec 18 00:57:18 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Migrating all cell renderers to use the new instance private data
      	construction.
      
      	* gtk/gtktreeprivate.h: remove GtkCellRendererInfo, as it is no
      	longer being used.
      
      	* gtk/gtkcellrenderer.c (gtk_cell_renderer_init),
      	(gtk_cell_renderer_class_init), (gtk_cell_renderer_get_property),
      	(set_cell_bg_color), (gtk_cell_renderer_render): remove old
      	GtkCellRendererInfo handling, migrate to instance private data.
      
      	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_editing_done),
      	(gtk_cell_renderer_text_start_editing): moved focus_out_id
      	from GtkCellRendererInfo to text renderer private data.
      
      	* gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_init),
      	(gtk_cell_renderer_pixbuf_class_init),
      	(gtk_cell_renderer_pixbuf_finalize),
      	(gtk_cell_renderer_pixbuf_get_property),
      	(gtk_cell_renderer_pixbuf_set_property),
      	(gtk_cell_renderer_pixbuf_create_stock_pixbuf),
      	(gtk_cell_renderer_pixbuf_get_size), (gtk_cell_renderer_pixbuf_render):
      	migrate to instance private data.
      
      	* gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_class_init),
      	(gtk_cell_renderer_toggle_get_property),
      	(gtk_cell_renderer_toggle_set_property),
      	(gtk_cell_renderer_toggle_render): migrate to instance private data.
      c43efa51
  9. 17 Dec, 2003 10 commits
    • Kristian Rietveld's avatar
      add a single-paragraph-mode property, use private instance data. (Fixes · 62a15f2a
      Kristian Rietveld authored
      Thu Dec 18 00:24:32 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_class_init),
      	(gtk_cell_renderer_text_get_property),
      	(gtk_cell_renderer_text_set_property), (get_layout): add a
      	single-paragraph-mode property, use private instance data.
      	(Fixes #114943, reported by Morten Welinder).
      62a15f2a
    • Kristian Rietveld's avatar
      now deprecated (#106953, reported by Matthias Clasen). · 48912963
      Kristian Rietveld authored
      Thu Dec 18 00:07:01 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreemodel.h (gtk_tree_path_new_root),
      	(gtk_tree_model_get_iter_root): now deprecated (#106953, reported
      	by Matthias Clasen).
      48912963
    • Kristian Rietveld's avatar
      if we set a new stock_id and there was a previous stock_id, unref the · e6e76e1c
      Kristian Rietveld authored
      Wed Dec 17 23:50:56 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtkcellrendererpixbuf.c (gtk_cell_renderer_pixbuf_set_property):
      	if we set a new stock_id and there was a previous stock_id, unref
      	the pixbuf (since it was used to renderer the previous stock_id
      	and stock_id might have been set to NULL now). (Fixes #122966).
      e6e76e1c
    • Marco Pesenti Gritti's avatar
      Check that index is not bigger than level array length also when depth is · 3ea41a92
      Marco Pesenti Gritti authored
      2003-12-17  Marco Pesenti Gritti  <marco@gnome.org>
      
              * gtk/gtktreemodelsort.c: (gtk_tree_model_sort_get_iter):
      
              Check that index is not bigger than level array length
              also when depth is 1. Now get_iter_first correctly return
              FALSE when the model is empty (#129411).
      3ea41a92
    • Kristian Rietveld's avatar
      only try to strcmp or strlen if we managed to normalize and casefold the · b1187d9e
      Kristian Rietveld authored
      Wed Dec 17 23:31:19 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_search_equal_func): only
      	try to strcmp or strlen if we managed to normalize and casefold
      	the string correctly. Fixes crashes with non-UTF8 strings.
      	(#121617, Patch from Tim-Philipp Müller).
      b1187d9e
    • Matthias Clasen's avatar
      Add missing GDK_THREADS_ENTER()/GDK_THREADS_LEAVE(). Cast second argument · 2a136e56
      Matthias Clasen authored
      Wed Dec 17 23:20:23 2003  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkexpander.c (gtk_expander_animation_timeout): Add missing
      	GDK_THREADS_ENTER()/GDK_THREADS_LEAVE().
      	* gtk/gtkcalendar.c, gtk/gtkclist.c, gtk/gtkexpander.c,
      	gtk/gtklist.c, gtk/gtknotebook.c, gtk/gtkselection.c,
      	gtk/gtkspinbutton.c: Cast second argument to g_timeout_add() to
      	GSourceFunc instead of GtkFunction.  (#129525, Olexiy Avramchenko)
      2a136e56
    • Kristian Rietveld's avatar
      fix compile warning. (#122727, patch from Kjartan Maraas). · d1f4899f
      Kristian Rietveld authored
      Wed Dec 17 23:16:45 2003  Kristian Rietveld  <kris@gtk.org>
      
      	* gtk/gtktreeview.c (gtk_tree_view_button_press): fix compile warning.
      	(#122727, patch from Kjartan Maraas).
      d1f4899f
    • Kristian Rietveld's avatar
      Yay! Fixed height mode! Hooray! (Part 2 of #80868). · f219093f
      Kristian Rietveld authored
      Wed Dec 17 21:23:01 2003  Kristian Rietveld  <kris@gtk.org>
      
      	Yay! Fixed height mode! Hooray! (Part 2 of #80868).
      
      	* gtk/gtktreeview.c (gtk_tree_view_class_init),
      	(gtk_tree_view_init), (gtk_tree_view_set_property),
      	(gtk_tree_view_get_property), (gtk_tree_view_set_model): add a
      	fixed_height_mode property,
      	(intialize_fixed_height_mode), (do_validate_rows),
      	(column_sizing_notify), (gtk_tree_view_set_fixed_height_mode),
      	(gtk_tree_view_style_set), (gtk_tree_view_row_changed),
      	(gtk_tree_view_row_inserted), (gtk_tree_view_remove_column),
      	(gtk_tree_view_insert_column): implement fixed height mode,
      	(gtk_tree_view_append_column), (gtk_tree_view_insert_column),
      	(gtk_tree_view_insert_column_with_attributes),
      	(gtk_tree_view_insert_column_with_data_func): update docs.
      
      	* gtk/gtktreeprivate.h: add two fields to GtkTreePrivate.
      f219093f
    • Murray Cumming's avatar
      Actually call the default signal handlers instead of calling the · c64c7ee0
      Murray Cumming authored
      2003-12-07  Murray Cumming  <murrayc@usa.net>
      
              * gtk/gtktreemodel.c:
              (row_inserted_marshal, row_deleted_marshal, rows_reorderered_marshal)
              Actually call the default signal handlers instead of calling the
              marshallers themselves in an endless loop. These default signal handler
              callbacks are not actually set so this is only noticed by gtkmm at
              the moment. Bug 123923.
      c64c7ee0
    • Federico Mena Quintero's avatar
      Added a "volumes-changed" signal. Added the following methods: · 8baf8571
      Federico Mena Quintero authored
      2003-12-16  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilesystem.h (struct _GtkFileSystemIface): Added a
      	"volumes-changed" signal.  Added the following methods:
      		list_volumes
      		volume_free
      		volume_get_base_path
      		volume_get_is_mounted
      		volume_mount
      		volume_get_display_name
      		volume_render_icon
      
      	* gtk/gtkfilesystem.c (gtk_file_system_base_init): Create the
      	"volumes-changed" signal.
      	(gtk_file_system_list_volumes): New function.
      	(gtk_file_system_volume_free): New function.
      	(gtk_file_system_volume_get_base_path): New function.
      	(gtk_file_system_volume_get_is_mounted): New function.
      	(gtk_file_system_volume_mount): New function.
      	(gtk_file_system_volume_get_display_name): New function.
      	(gtk_file_system_volume_render_icon): New function.
      
      	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_volume_free): Implement.
      	(gtk_file_system_unix_volume_get_base_path): Implement.
      	(gtk_file_system_unix_volume_get_is_mounted): Implement.
      	(gtk_file_system_unix_volume_mount): Implement.
      	(gtk_file_system_unix_volume_get_display_name): Implement.
      	(gtk_file_system_unix_volume_render_icon): Implement.
      
      	* gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
      	Added a field for the "volumes-changed" signal connection.
      	(gtk_file_chooser_default_set_property): Connect to
      	"volumes-changed" on the file system.
      	(gtk_file_chooser_default_finalize): Disconnect from
      	"volumes-changed".
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_remove_rows): New helper
      	function.
      	(shortcuts_get_index): New helper function.
      	(shortcuts_insert_path): Can now insert volumes as well as paths.
      	(shortcuts_append_paths): Don't take is_file_system_root.
      	(shortcuts_add_volumes): New function.
      	(shortcuts_append_file_system_roots): Removed.
      	(create_shortcuts_model): Use shortcuts_add_volumes().
      	(remove_bookmark_button_clicked_cb): Check that the index is
      	within range.
      	(bookmarks_check_add_sensitivity): Take volumes into account.
      	(shortcuts_get_selected_index): New helper function.
      	(remove_bookmark_button_clicked_cb): Use
      	shortcuts_get_selected_index().
      	(bookmarks_check_remove_sensitivity): Likewise.
      	(shortcuts_select_func): Likewise.
      	(shortcuts_row_activated_cb): Handle volumes as well as normal
      	paths.
      	(shortcuts_activate_volume): New function.
      	(struct _GtkFileChooserDefault): Removed the bookmarks_set and
      	bookmarks_iter fields.
      	(shortcuts_append_bookmarks): Use shortcuts_remove_rows().
      	(bookmarks_changed_cb): Use shortcuts_add_bookmarks().
      	(remove_bookmark_rows): Removed.
      	(shortcuts_add_bookmarks): New function; moved most of the code
      	over from shortcuts_append_bookmarks().
      	(shortcuts_append_bookmarks): Add the separator node here, and
      	then call shortcuts_add_bookmarks().
      8baf8571
  10. 16 Dec, 2003 2 commits
    • Manish Singh's avatar
      fix preprocessor conditional confusion. (G_OS_UNIX/G_OS_WIN32 stuff) · 6b80f394
      Manish Singh authored
      Tue Dec 16 15:01:10 2003  Manish Singh  <yosh@gimp.org>
      
              * gtk/gtkfilechooserwidget.c: fix preprocessor conditional confusion.
              (G_OS_UNIX/G_OS_WIN32 stuff)
      6b80f394
    • Matthias Clasen's avatar
      Do not interpret distant clicks as double-clicks (#116541, Bernhard · fbb0ba1a
      Matthias Clasen authored
      Tue Dec 16 01:46:46 2003  Matthias Clasen  <maclas@gmx.de>
      
      	Do not interpret distant clicks as double-clicks  (#116541,
      	Bernhard Walle):
      
      	* gdk/gdkdisplay.h (struct GdkDisplay): Add new fields
      	double_click_distance, button_x and button_y.
      	* gdk/gdkdisplay.c (gdk_display_init): Initialize the new fields.
      
      	* gdk/gdkdisplay.h:
      	* gdk/gdkevents.c (gdk_display_set_double_click_distance):
      	New function to set the double click distance on a display.
      
      	* gdk/gdkevents.c: Take double click distance into account
      	when generating single, double or triple clicks.
      
      	* gtk/gtksettings.c: Add new setting "gtk-double-click-distance".
      
      	* gdk/x11/gdkevents-x11.c: Add the XSetting
      	"Net/DoubleClickDistance" and map it to "gtk-double-click-distance".
      fbb0ba1a