1. 02 Oct, 2012 16 commits
  2. 01 Oct, 2012 17 commits
  3. 28 Sep, 2012 7 commits
    • Cosimo Cecchi's avatar
      symboliccolor: fix a critical warning · a2bef8ca
      Cosimo Cecchi authored
      This was introduced in 0cc32eae
      a2bef8ca
    • Benjamin Otte's avatar
      css: Huge refactoring to avoid computing wrong values · 1454ba15
      Benjamin Otte authored
      Here's the shortest description of the bug I can come up with:
      When computing values, we have 3 kinds of dependencies:
      (1) other properties ("currentColor" or em values)
      (2) inherited properties ("inherit")
      (3) generic things from the theme (@keyframes or @define-color)
      Previously, we passed the GtkStyleContext as an argument, because it
      provided these 3 things using:
      (1) _gtk_style_context_peek_property()
      (2) _gtk_style_context_peek_property(gtk_style_context_get_parent())
      (3) context->priv->cascade
      
      However, this makes it impossible to lookup values other than the ones
      accessible via _gtk_style_context_peek_property(). And this is exactly
      what we are doing in gtk_style_context_update_cache(). So when the cache
      updates encountered case (1), they were looking up the values from the
      wrong style data.
      
      So this large patch essentially does nothing but replace the
      context argument in all compute functions with new arguments for the 3
      cases above:
      (1) values
      (2) parent_values
      (3) provider
      
      We apparently have a lot of computing code.
      1454ba15
    • Benjamin Otte's avatar
      symboliccolor: Change prototype of _gtk_symbolic_color_resolve_full() · 0cc32eae
      Benjamin Otte authored
      We can juts pass a GtkStyleProviderPrivate, that one has the vfunc we
      want already. So no need to pass vfuncs anymore.
      0cc32eae
    • Benjamin Otte's avatar
      css: Move declaration · 448cdb07
      Benjamin Otte authored
      ... for future changes. This is just to check that compilation still
      succeeds.
      448cdb07
    • Benjamin Otte's avatar
      cssvalue: Remove unnecessary include · e2ec13c5
      Benjamin Otte authored
      e2ec13c5
    • Benjamin Otte's avatar
      css: Don't crash when printing gradients · 5c4fc16c
      Benjamin Otte authored
      ... in the fallback code. Instead print a FIXME.
      5c4fc16c
    • Benjamin Otte's avatar
      cssvalue: Don't crash when printing NULL strings · 94c0c154
      Benjamin Otte authored
      A NULL string should be printed as "none".
      94c0c154