1. 11 Nov, 2017 1 commit
  2. 07 Nov, 2017 1 commit
  3. 03 Oct, 2017 1 commit
  4. 07 Aug, 2017 1 commit
  5. 13 Jul, 2017 1 commit
    • Uwe Hermann's avatar
      Various log message cleanups. · 91057d2f
      Uwe Hermann authored
      Drop unneeded log messages, add some others that might be useful,
      document which ones we're intentionally not emitting.
      
      Don't log "$operation successful" type of messages in most cases,
      that's too verbose; logging failures only is sufficient there.
      
      baylibre-acme: Don't log "No such file or directory" messages during scan,
      this triggers on all kinds of unrelated devices (e.g. "AMDGPU i2c bit
      bus 0x91" in this case):
      
        sr: [...] baylibre-acme: Name for probe 1 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-0040/name”: No such file or directory
        sr: [...] baylibre-acme: Name for probe 2 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-0041/name”: No such file or directory
        sr: [...] baylibre-acme: Name for probe 3 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-0044/name”: No such file or directory
        sr: [...] baylibre-acme: Name for probe 4 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-0045/name”: No such file or directory
        sr: [...] baylibre-acme: Name for probe 5 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-0042/name”: No such file or directory
        sr: [...] baylibre-acme: Name for probe 5 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-004c/name”: No such file or directory
        sr: [...] baylibre-acme: Name for probe 6 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-0043/name”: No such file or directory
        sr: [...] baylibre-acme: Name for probe 6 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-0049/name”: No such file or directory
        sr: [...] baylibre-acme: Name for probe 7 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-0046/name”: No such file or directory
        sr: [...] baylibre-acme: Name for probe 7 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-004f/name”: No such file or directory
        sr: [...] baylibre-acme: Name for probe 8 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-0047/name”: No such file or directory
        sr: [...] baylibre-acme: Name for probe 8 can't be read: Failed to open file “/sys/class/i2c-adapter/i2c-1/1-004b/name”: No such file or directory
      91057d2f
  6. 06 Jun, 2017 1 commit
  7. 11 Mar, 2017 1 commit
  8. 10 Mar, 2017 2 commits
  9. 21 Jan, 2017 4 commits
  10. 20 Jan, 2017 2 commits
    • Gerhard Sittig's avatar
      scpi: Don't process received data of zero length · 90084681
      Gerhard Sittig authored
      When nothing was received in a read attempt, we need not adjust the
      buffered data's read position nor the glib string object's size. Skip
      any processing for empty input, just keep checking for timeouts.
      90084681
    • Gerhard Sittig's avatar
      scpi: Rephrase buffer resize for free space during SCPI read, add comments · ad21865f
      Gerhard Sittig authored
      Routine sr_scpi_get_data() checks for free space in the receive buffer,
      and resizes the buffer when free space drops below a threshold. The
      previous logic assumed that the resize and the read logic would interact
      in some specific way to achieve the desired operation.
      
      Adjust the buffer resize such that more free space is pre-allocated, yet
      the payload size of the buffer is not affected. This eliminates the
      dependency of the optional resize logic from subsequent activity for
      reception of data that is non-optional.
      
      Add comments while we are here, outline the steps taken in the
      sr_scpi_get_data() routine.
      ad21865f
  11. 07 Jan, 2017 4 commits
    • Gerhard Sittig's avatar
      Revert "scpi: Don't process received data of zero length" · d5a61aaf
      Gerhard Sittig authored
      Undo the change which skips management activities when no data was
      received. This change breaks the current implementation, and needs to
      get deferred until a delicate interaction between the resize and the
      read logic has been eliminated.
      d5a61aaf
    • Gerhard Sittig's avatar
      scpi: Rephrase length logic in data block reception, comment/group code · 26e8c6a2
      Gerhard Sittig authored
      Slightly rephrase the SCPI code which parses the responses that carry
      (binary) data blocks. Be explicit about NUL termination when parsing the
      leading length spec in the response, obsoleting the array initializer.
      Add lots of comments and group source code lines to better reflect
      what's happening from the protocol's perspective.
      
      Fix the returned error code in the path which reads responses of
      excessive length in chunks. The previous implementation detected errors
      but always returned code 0 (success).
      26e8c6a2
    • Gerhard Sittig's avatar
      scpi: Don't process received data of zero length · 904401e8
      Gerhard Sittig authored
      When nothing was received in a read attempt, we need not adjust the
      buffered data's read position nor the glib string object's size. Skip
      any processing for empty input, just keep checking for timeouts.
      904401e8
    • Gerhard Sittig's avatar
      scpi: Minor style nits · d3de86f3
      Gerhard Sittig authored
      Drop an initial assignment to a variable which never takes effect.
      Add braces around the body of a more complex if block. Separate routines
      from each other by exactly one empty line.
      d3de86f3
  12. 29 Aug, 2016 1 commit
  13. 16 May, 2016 2 commits
  14. 23 Apr, 2016 3 commits
  15. 17 Apr, 2016 1 commit
  16. 30 Mar, 2016 2 commits
    • Alexandru Gagniuc's avatar
      scpi/libgpib: Place device in local mode before closing handle · 8b0ad3a5
      Alexandru Gagniuc authored
      Devices connected on a real GPIB bus are placed in remote mode when
      opening them. libgpib does not automatically place devices back in
      local mode when closing the handle. It is thus possible to lock out a
      GPIB device by probing it with libsigrok.
      
      This happens on the HP 3457A meter, which does not have a "LOCAL"
      command, and must be put back in local mode via GPIB handshake.
      ibloc() takes care of this, and it does it on a per-device basis,
      such that other devices on the GPIB bus are not affected.
      8b0ad3a5
    • Alexandru Gagniuc's avatar
      scpi/libgpib: Print error string instead of number on errors · daf13c57
      Alexandru Gagniuc authored
      libgpib has an error_string which formats a numeric error code into a
      human-readable description. Use that instead of printing the numeric
      code, as it makes debugging easier.
      daf13c57
  17. 29 Jan, 2016 1 commit
  18. 26 Dec, 2015 1 commit
  19. 08 Nov, 2015 1 commit
  20. 25 Oct, 2015 1 commit
  21. 24 Oct, 2015 3 commits
  22. 25 Sep, 2015 1 commit
    • Uwe Hermann's avatar
      Fix a few "value never read" scan-build warnings. · e57057ae
      Uwe Hermann authored
      This fixes parts of bug #423.
      
      The list of fixed warnings:
      
      src/output/srzip.c:285:3: warning: Value stored to 'ret' is never read
                      ret = zip_append(o, logic->data, logic->unitsize, logic->length);
                      ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      src/scpi/scpi.c:610:2: warning: Value stored to 'ret' is never read
              ret = SR_OK;
              ^     ~~~~~
      src/scpi/scpi.c:667:2: warning: Value stored to 'ret' is never read
              ret = SR_OK;
              ^     ~~~~~
      src/dmm/vc870.c:410:2: warning: Value stored to 'info_local' is never read
              info_local = (struct vc870_info *)info;
              ^            ~~~~~~~~~~~~~~~~~~~~~~~~~
      src/hardware/conrad-digi-35-cpu/api.c:130:2: warning: Value stored to 'ret' is never read
              ret = SR_OK;
              ^     ~~~~~
      src/hardware/fx2lafw/api.c:658:2: warning: Value stored to 'timeout' is never read
              timeout = fx2lafw_get_timeout(devc);
              ^         ~~~~~~~~~~~~~~~~~~~~~~~~~
      src/hardware/gmc-mh-1x-2x/protocol.c:941:3: warning: Value stored to 'retc' is never read
                      retc = SR_ERR_ARG;
                      ^      ~~~~~~~~~~
      src/hardware/gmc-mh-1x-2x/api.c:168:2: warning: Value stored to 'model' is never read
              model = METRAHIT_NONE;
              ^       ~~~~~~~~~~~~~
      src/hardware/ikalogic-scanalogic2/api.c:325:2: warning: Value stored to 'ret' is never read
              ret = SR_OK;
              ^     ~~~~~
      src/hardware/openbench-logic-sniffer/api.c:185:3: warning: Value stored to 'devc' is never read
                      devc = sdi->priv;
                      ^      ~~~~~~~~~
      src/hardware/rigol-ds/api.c:813:3: warning: Value stored to 'devc' is never read
                      devc = sdi->priv;
                      ^      ~~~~~~~~~
      src/hardware/scpi-pps/api.c:405:2: warning: Value stored to 'ret' is never read
              ret = SR_OK;
              ^     ~~~~~
      src/hardware/yokogawa-dlm/api.c:239:2: warning: Value stored to 'ret' is never read
              ret = SR_ERR_NA;
              ^     ~~~~~~~~~
      e57057ae
  23. 22 Sep, 2015 2 commits
  24. 21 Sep, 2015 2 commits