Commit 1bd72d0a authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab Committed by Martin Kepplinger
Browse files

media: imx: imx7-media-csi: Don't set PIXEL_BIT in CSICR1



This is an automatic generated email to let you know that the following patch were queued:

Subject: media: imx: imx7-media-csi: Don't set PIXEL_BIT in CSICR1
Author:  Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date:    Wed Feb 3 03:57:18 2021 +0100

The PIXEL_BIT field of the CSICR1 register is documented as setting the
Bayer data width to 10 bits, and is set by the driver for all non-YUV
pixel formats. Test code from NXP showed that the bit shouldn't be set
for Bayer formats, and this was confirmed by experimentation with RAW8
capture (which doesn't work when setting the field) and RAW10 capture
(for which setting the field doesn't seem to make a difference) on
i.MX8MM with an OV5640 sensor connected over CSI-2. Don't set it.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarRui Miguel Silva <rmfrfs@gmail.com>
Tested-by: Martin Kepplinger's avatarMartin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>

 drivers/staging/media/imx/imx7-media-csi.c | 15 ---------------
 1 file changed, 15 deletions(-)
parent a43fffec
......@@ -491,21 +491,6 @@ static void imx7_csi_configure(struct imx7_csi *csi)
cr18 |= BIT_MIPI_DATA_FORMAT_YUV422_8B;
break;
}
switch (out_pix->pixelformat) {
case V4L2_PIX_FMT_Y10:
case V4L2_PIX_FMT_Y12:
case V4L2_PIX_FMT_SBGGR8:
case V4L2_PIX_FMT_SGBRG8:
case V4L2_PIX_FMT_SGRBG8:
case V4L2_PIX_FMT_SRGGB8:
case V4L2_PIX_FMT_SBGGR16:
case V4L2_PIX_FMT_SGBRG16:
case V4L2_PIX_FMT_SGRBG16:
case V4L2_PIX_FMT_SRGGB16:
cr1 |= BIT_PIXEL_BIT;
break;
}
}
imx7_csi_reg_write(csi, cr1, CSI_CSICR1);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment