GitLab

The commit message mentions 8-pixels alignment, whereas rounding is performed to 2^8.
For the width, the rounding factor is 8-pixels, according to the data sheet.
This indicates that the author misunderstood the round_up() semantics in the neighboring roundings too.

TODO: test the devkit cam that now uses the mainline csi drivers.

UNTESTED

Mauro Carvalho Chehab authored Aug 02, 2021 and Martin Kepplinger committed Sep 17, 2021

This is an automatic generated email to let you know that the following patch were queued:

Subject: media: imx: imx7-media-csi: Set TWO_8BIT_SENSOR for >= 10-bit formats
Author:  Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date:    Wed Feb 3 04:08:19 2021 +0100

Sample code from NXP, as well as experiments on i.MX8MM with RAW10
capture with an OV5640 sensor connected over CSI-2, showed that the
TWO_8BIT_SENSOR field of the CSICR3 register needs to be set for formats
larger than 8 bits. Do so, even if the reference manual doesn't clearly
describe the effect of the field.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

 drivers/staging/media/imx/imx7-media-csi.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Mauro Carvalho Chehab authored Aug 02, 2021 and Martin Kepplinger committed Sep 17, 2021

This is an automatic generated email to let you know that the following patch were queued:

Subject: media: imx: imx7-media-csi: Fix buffer return upon stream start failure
Author:  Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date:    Wed May 12 01:44:40 2021 +0200

When the stream fails to start, the first two buffers in the queue have
been moved to the active_vb2_buf array and are returned to vb2 by
imx7_csi_dma_unsetup_vb2_buf(). The function is called with the buffer
state set to VB2_BUF_STATE_ERROR unconditionally, which is correct when
stopping the stream, but not when the start operation fails. In that
case, the state should be set to VB2_BUF_STATE_QUEUED. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

 drivers/staging/media/imx/imx7-media-csi.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

Mauro Carvalho Chehab authored Aug 02, 2021 and Martin Kepplinger committed Sep 17, 2021

This is an automatic generated email to let you know that the following patch were queued:

Subject: media: imx: imx7-media-csi: Don't set PIXEL_BIT in CSICR1
Author:  Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date:    Wed Feb 3 03:57:18 2021 +0100

The PIXEL_BIT field of the CSICR1 register is documented as setting the
Bayer data width to 10 bits, and is set by the driver for all non-YUV
pixel formats. Test code from NXP showed that the bit shouldn't be set
for Bayer formats, and this was confirmed by experimentation with RAW8
capture (which doesn't work when setting the field) and RAW10 capture
(for which setting the field doesn't seem to make a difference) on
i.MX8MM with an OV5640 sensor connected over CSI-2. Don't set it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

 drivers/staging/media/imx/imx7-media-csi.c | 15 ---------------
 1 file changed, 15 deletions(-)

Mauro Carvalho Chehab authored Aug 02, 2021 and Martin Kepplinger committed Sep 17, 2021

This is an automatic generated email to let you know that the following patch were queued:

Subject: media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller
Author:  Martin Kepplinger <martin.kepplinger@puri.sm>
Date:    Wed Jul 28 11:12:44 2021 +0200

Add a driver to support the i.MX8MQ MIPI CSI receiver. The hardware side
is based on
https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/media/platform/imx8/mxc-mipi-csi2_yav.c?h=imx_5.4.70_2.3.0



It's built as part of VIDEO_IMX7_CSI because that's documented to support
i.MX8M platforms. This driver adds i.MX8MQ support where currently only the
i.MX8MM platform has been supported.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

 drivers/staging/media/imx/Makefile           |   1 +
 drivers/staging/media/imx/imx8mq-mipi-csi2.c | 991 +++++++++++++++++++++++++++
 2 files changed, 992 insertions(+)

Mauro Carvalho Chehab authored Aug 02, 2021 and Martin Kepplinger committed Sep 17, 2021

This is an automatic generated email to let you know that the following patch were queued:

Subject: media: dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and controller
Author:  Martin Kepplinger <martin.kepplinger@puri.sm>
Date:    Wed Jul 28 11:12:43 2021 +0200

The i.MX8MQ SoC integrates a different MIPI CSI receiver as the i.MX8MM so
describe the DT bindings for it.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

 .../bindings/media/nxp,imx8mq-mipi-csi2.yaml       | 174 +++++++++++++++++++++
 1 file changed, 174 insertions(+)

Dorota Czaplejewicz authored Sep 06, 2021 and Martin Kepplinger committed Sep 16, 2021

By fixing format setting and implementing (as a stub) a link frequency control.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>

This is the 5.13.16 stable release

Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>

Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>

Sebastian Krzyszkowiak authored Aug 16, 2021 and Martin Kepplinger committed Sep 14, 2021

(upstream commit eaa2c490514d2d49c3ef1764530234d07f422289)

There's no need to print a message on every change in battery percentage
on regular log levels.
Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Sebastian Krzyszkowiak authored Sep 12, 2021 and Martin Kepplinger committed Sep 14, 2021

Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>

Sebastian Krzyszkowiak authored Sep 12, 2021 and Martin Kepplinger committed Sep 14, 2021

Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>