Skip to content
  • Arnd Bergmann's avatar
    scsi: nsp32: fix logic bug in error handling · 287f7965
    Arnd Bergmann authored
    
    
    gcc-8 points out a logic error that has existed since the start of the
    git history:
    
    drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi':
    drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
      if(((phase & BUSMON_BSY) == 1) || (phase & BUSMON_SEL) == 1) {
                               ^~
    
    Presumably the author intended to check if one of two bits was set, so
    that's what I'm changing the code to. This will obviously change the
    behavior of the code, hopefully to do the right thing, but I have not
    tested this or checked if the new "(phase & BUSMON_BSY) || (phase &
    BUSMON_SEL)" condition should indeed be treated as a fatal error.
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarGOTO Masanori <gotom@debian.or.jp>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    287f7965