Skip to content
  • Dave Chinner's avatar
    Revert "mm: slowly shrink slabs with a relatively small number of objects" · a9a238e8
    Dave Chinner authored
    This reverts commit 172b06c3 ("mm: slowly shrink slabs with a
    relatively small number of objects").
    
    This change changes the agressiveness of shrinker reclaim, causing small
    cache and low priority reclaim to greatly increase scanning pressure on
    small caches.  As a result, light memory pressure has a disproportionate
    affect on small caches, and causes large caches to be reclaimed much
    faster than previously.
    
    As a result, it greatly perturbs the delicate balance of the VFS caches
    (dentry/inode vs file page cache) such that the inode/dentry caches are
    reclaimed much, much faster than the page cache and this drives us into
    several other caching imbalance related problems.
    
    As such, this is a bad change and needs to be reverted.
    
    [ Needs some massaging to retain the later seekless shrinker
      modifications.]
    
    Link: http://lkml.kernel.org/r/20190130041707.27750-3-david@fromorbit.com
    Fixes: 172b06c3
    
     ("mm: slowly shrink slabs with a relatively small number of objects")
    Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
    Cc: Wolfgang Walter <linux@stwm.de>
    Cc: Roman Gushchin <guro@fb.com>
    Cc: Spock <dairinin@gmail.com>
    Cc: Rik van Riel <riel@surriel.com>
    Cc: Michal Hocko <mhocko@kernel.org>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    a9a238e8