Skip to content
  • Scott Wood's avatar
    udp: Fix inverted NAPI_GRO_CB(skb)->flush test · 2d8f7e2c
    Scott Wood authored
    Commit 2abb7cdc ("udp: Add support for doing checksum unnecessary
    conversion") caused napi_gro_cb structs with the "flush" field zero to
    take the "udp_gro_receive" path rather than the "set flush to 1" path
    that they would previously take.  As a result I saw booting from an NFS
    root hang shortly after starting userspace, with "server not
    responding" messages.
    
    This change to the handling of "flush == 0" packets appears to be
    incidental to the goal of adding new code in the case where
    skb_gro_checksum_validate_zero_check() returns zero.  Based on that and
    the fact that it breaks things, I'm assuming that it is unintentional.
    
    Fixes: 2abb7cdc
    
     ("udp: Add support for doing checksum unnecessary conversion")
    Cc: Tom Herbert <therbert@google.com>
    Signed-off-by: default avatarScott Wood <scottwood@freescale.com>
    Acked-by: default avatarEric Dumazet <edumazet@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    2d8f7e2c