Skip to content
  • Yinghai Lu's avatar
    x86/boot: Correctly bounds-check relocations · 4abf061b
    Yinghai Lu authored
    
    
    Relocation handling performs bounds checking on the resulting calculated
    addresses. The existing code uses output_len (VO size plus relocs size) as
    the max address. This is not right since the max_addr check should stop at
    the end of VO and exclude bss, brk, etc, which follows.  The valid range
    should be VO [_text, __bss_start] in the loaded physical address space.
    
    This patch adds an export for __bss_start in voffset.h and uses it to
    set the correct limit for max_addr.
    
    Signed-off-by: default avatarYinghai Lu <yinghai@kernel.org>
    [ Rewrote the changelog. ]
    Signed-off-by: default avatarKees Cook <keescook@chromium.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Baoquan He <bhe@redhat.com>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Dave Young <dyoung@redhat.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Vivek Goyal <vgoyal@redhat.com>
    Cc: lasse.collin@tukaani.org
    Link: http://lkml.kernel.org/r/1461888548-32439-7-git-send-email-keescook@chromium.org
    
    
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    4abf061b