GitLab

Otherwise the following request will simply be not performed
as the cancellable is now in cancelled state

Which uses less memory

All we do is to save the error and then delete it, never use.

I often need this for debugging especially on network
failures

If the chat name is updated only when json data is set, the name may not
get updated for empty rooms

We were comparing the same values which will always be true

Mohammed Sadiq authored Jul 06, 2021 and Mohammed Sadiq committed Jul 06, 2021

JsonObject is not a GObject.  Use json_object_unref()
to free

We were freeing the hashtable value but we were not passing
a copy of the string, so the same memory location was being
freed multiple times.

Also clear the memory before freeing because we don't want
access token to be in memory after free.

We don't want the access token to stay in memory after the application
is closed

And remove no longer code

Mohammed Sadiq authored Jul 02, 2021 and Mohammed Sadiq committed Jul 02, 2021

Let's eventually move network related methods to a separate class
so that matrix-api won't be much cluttered as more features
are added there.

Instead of blindly emitting 'changed' signal, let it be a property
so that if the changes are reverted, the 'modified' property
can be unset so that we can handle it appropriately

Also adapt to changes in settins-dialog

And adapt to changes.

This is required for matrix accounts as they can be saved only async

This implements the new design