- 26 Apr, 2021 11 commits
-
-
Guido Gunther authored
-
-
It's assigned multiple times.
-
Fixes another leak.
-
This went unnoticed since the manager forgot to cleanup this at all (see follow up commit).
-
The current logic was fragile and failed e.g. when the FEEDBACKD_UDEV_VAL_LED would not match leaking the dev since the g_object_unref() at the end of the loop was never hit. Prevent that with automatic cleanup and explicitly ref'ing the devs we want to use.
-
g_ascii_strdown() creates a copy already.
-
g_enum_to_string() is transfer full.
-
So far we only unref'ed the device.
-
-
-
- 22 Apr, 2021 6 commits
-
-
Guido Gunther authored
When the client goes away we build up a list of events to end feedback for to make sure the hash table isn't modified in place. tThe alternative approach would be to disconnect the on_event_feedbacks_ended handler, duplicate the DBus signal emission and use g_hash_table_foreach_remove but that looks less robust than using the same code path. Closes: #25
-
Guido Gunther authored
-
Guido Gunther authored
This allows us to store the DBus sender
-
Guido Gunther authored
This matchs phosh's style.
-
Guido Gunther authored
-
Guido Gunther authored
-
- 22 Mar, 2021 1 commit
-
-
Sebastian Spaeth authored
It is TriggerFeedback and not Feedback (anymore). Also add a note how to end the feedback in order to prevent loss of hearing :-).
-
- 20 Mar, 2021 1 commit
-
-
Clayton Craft authored
If the trigger is the last thing in sysfs_path/LED_TRIGGER_ATTR, then the new-line at the end of the output causes g_strv_contains to fail to find the trigger in the list. This strips the new-line before splitting the output into a list for searching. You can see the problem this patch fixes with the librem 5, by: $ rmmod ledtrig-timer # or whatever is listed at the end, so 'pattern' is the last thing $ cat /sys/devices/platform/pwmleds/leds/blue:status/trigger [none] kbd-scrolllock ... pattern $ fbd-ledctrl -p /sys/devices/platform/pwmleds/leds/blue:status -t pattern Failed to set perms of /sys/devices/platform/pwmleds/leds/blue:status/pattern to 101: No such file or directory $ modprobe ledtrig-timer $ cat /sys/devices/platform/pwmleds/leds/blue:status/trigger [none] kbd-scrolllock ... pattern timer $ fbd-ledctrl -p /sys/devices/platform/pwmleds/leds/blue:status -t pattern <success>
-
- 05 Feb, 2021 5 commits
-
-
Guido Gunther authored
-
Guido Gunther authored
-
Guido Gunther authored
Don't leak the error values in the success case
-
Guido Gunther authored
This is not an error per se.
-
Guido Gunther authored
-
- 04 Feb, 2021 1 commit
-
-
Martin Bürgmann authored
tracks the FdbFeedbackSounds in a GHashTable in the FdbDevSound
-
- 25 Jan, 2021 1 commit
-
-
Guido Gunther authored
-
- 11 Jan, 2021 1 commit
-
-
Guido Gunther authored
It was off in several places. Now that there's no outstanding MRs clean it up via uncrustify --replace -c phosh.cfg src/fbd-feedback-manager.c
-
- 01 Jan, 2021 3 commits
-
-
Dylan Van Assche authored
Reads the compatible list of the device and tries to find a device-specific theme file in all directories. If no configuration is found, we fall back to a default theme file. The device-specific theme file can always be overriden by specifying the FEEDBACK_THEME environment variable
-
Dylan Van Assche authored
Run a script as a post install to make sure that all GLib schemas are compiled
-
Dylan Van Assche authored
The foreach loop was not used to validate all the include theme files
-
- 14 Nov, 2020 3 commits
-
-
Guido Gunther authored
-
Guido Gunther authored
Use a separate group for users that should be able to access the LED devices.
-
Guido Gunther authored
The names changed in device tree which tickles up into userspace.
-
- 26 Oct, 2020 1 commit
-
-
- 25 Oct, 2020 1 commit
-
-
Luca Weiss authored
The fbd_dev_led_set_brightness function is only getting called with parameter 0 at the moment so this was never noticed.
-
- 30 Sep, 2020 2 commits
-
-
Guido Gunther authored
This allow us to get debs quicker
-
Guido Gunther authored
This allows pa to cork, duck, etc.
-
- 26 Jul, 2020 1 commit
-
-
Guido Gunther authored
-
- 24 Jul, 2020 2 commits
-
-
Guido Gunther authored
-
Guido Gunther authored
This is not a critical since we prevented submitting initially but daemon cleanup processes all entries in the theme.
-