This can be useful to get the IM chat of a buddy if it
exists.  Currently we use a liststore to do so, which
shall be removed soon.

We were blindly adding all chats to im_list.  Let's check
the chat type and add chat to the appropriate list.

If ChattyChat has a PurpleBuddy or PurpleChat already set,
the `ui_data` of the PurpleConversation wasn't updated
when a conv is set for the chat.

So instead, check for PurpleBuddy/PurpleChat after the `ui_data'
is updated.  Also, remove previously set `ui_data` for the conv
already set in the chat, if any.

Move all chatty-conversation code to chatty-manager so that we
are closer to the plan to make manager alone deal with libpurple

If Return key press is set to send the inserted message, never insert
a newline when the key is pressed.

This was happening when the message input is empty and thus the Return
key press wasn't claimed to send the message.

If Return key is pressed with the message input empty, do an arror bell
instead

Fixes #391

"conversation-created" and "chat-joined" signals are emitted
immediately after the conversation is created.

When the conversation is created, it is handled by chatty_conv_new(),
which adds the PurpleConversation to the chat list.  So what ever
"conversation-created" and "chat-joined" callbacks where doing are
already done by chatty_conv_new().  So let's remove these signals
and their handlers as nothing is done there.

Code for setting buddy were duplicated.  Put
them into a function and use that.

Currently `ui_data` variable is not used.  Let's use it
so that we can eventually remove some list models to handle
chat list.

It's valid for a chat to not have a PurpleChat.  Also, we don't use
purple-chat property to set PurpleChat when creating an object from
PurpleConversation.

So Let's simply use direct pointer assignment instead of a property
so that we can have less code.

Don't duplicate code.

And reuse conv->ui_data for saving associated ChattyChat.

There is no reason to use bit twiddling here.

Mohammed Sadiq authored Aug 19, 2020 and Mohammed Sadiq committed Aug 20, 2020

Move Purple API to delete a chat to chatty-chat use that API
to delete a chat.

Mohammed Sadiq authored Aug 10, 2020 and Mohammed Sadiq committed Aug 19, 2020

We were always passing NULL as db

Mohammed Sadiq authored Aug 10, 2020 and Mohammed Sadiq committed Aug 19, 2020

history is a singleton object.  It's created and finalized only once in
an application's lifetime.  But in tests, the same object may be reused
after closing database, which can result in races that lock the GTask to
never complete.

Free object data in dispose and explicitly run dispose when the database
is closed so that we don't have wait for GObject to free data which may
be delayed.

When the window style changes from folded mode to non-folded mode,
the first chat list item is selected by default regardless of the
current state.

Instead of blindly selecting the first item, select the first item
only if none is selected when window changes to non-folded mode.

Currently, the count is reset only when switching the chat page.
But if the previously selected chat is the same as the currently
selected one, the count isn't reset (as no switching happened)

Fixes #387

Zander Brown authored Aug 10, 2020 and Mohammed Sadiq committed Aug 15, 2020

This is the same change we made in phosh

Librem5/phosh@482b35a7

purple_conversation_present() does all what we need, use that.
Don't repeat them.

This will help us dissociate libpurple handling UI and isolate
UI code from program logic.

items-changed signal is emitted after the item is removed from the list.
If the removed item is selected_item, it may have already freed.  So the
CHATTY_IS_CHAT (selected_item) is invoking a UB.  Let's fix it.

Don’t duplicate the same code everywhere