Skip to content
  • Nicola Corna's avatar
    sb/intel/common/firmware: Use the -S flag of me_cleaner · d171fabf
    Nicola Corna authored and Youness Alaoui's avatar Youness Alaoui committed
    
    
    The -S flag of me_cleaner, in addition to the standard code removal,
    sets the the AltMeDisable bit (ME 6.x-10.x) or the HAP bit (ME 11.x),
    which asks Intel ME to stop the execution after the hardware
    initialization.
    
    This should bring some advantages:
     * The state of Intel ME can be easily obtained by reading the Current
        Operation Mode register to trigger specific adjustments in the
        raminit (as already done in bd82x6x)
     * Intel ME falls into a more defined state, instead of being in a
        generic "Image Failure"
     * Hopefully, less code is run by Intel ME, as the execution should
        stop before even trying to load additional modules
    
    Tested on:
     * Nehalem, Sandy Bridge and Ivy Bridge (Nicola Corna)
     * Broadwell, Skylake and Kabylake (Youness Alaoui)
    
    If needed, the -S flag can be removed or integrated with other
    board-specific options by overriding CONFIG_ME_CLEANER_ARGS.
    
    Change-Id: I2c12d09124dcc39924d1dc4eaf53a2dc1f69a2ac
    Signed-off-by: default avatarNicola Corna <nicola@corna.info>
    Reviewed-on: https://review.coreboot.org/25508
    
    
    Tested-by: default avatarbuild bot (Jenkins) <no-reply@coreboot.org>
    Reviewed-by: default avatarYouness Alaoui <snifikino@gmail.com>
    d171fabf