Commit e7a68ec0 authored by Angel Pons's avatar Angel Pons Committed by Nico Huber
Browse files

nb/intel/pineview/raminit.c: Correct clkset1 programming



Reference code does a 32-bit write, and the values don't fit in 16 bits.

Change-Id: I1195c0637b5c215a45328ebae312cf620cd4c950
Signed-off-by: default avatarAngel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51860

Reviewed-by: default avatarPatrick Rudolph <siro@das-labor.org>
Tested-by: default avatarbuild bot (Jenkins) <no-reply@coreboot.org>
parent 7ee1c47c
...@@ -843,8 +843,7 @@ static void sdram_p_clkset0(const struct pllparam *pll, u8 f, u8 i) ...@@ -843,8 +843,7 @@ static void sdram_p_clkset0(const struct pllparam *pll, u8 f, u8 i)
/* Program clkset1's register for Kcoarse, Tap, PI, DBEn and DBSel */ /* Program clkset1's register for Kcoarse, Tap, PI, DBEn and DBSel */
static void sdram_p_clkset1(const struct pllparam *pll, u8 f, u8 i) static void sdram_p_clkset1(const struct pllparam *pll, u8 f, u8 i)
{ {
/* FIXME: This is actually a dword write! */ MCHBAR32_AND_OR(C0CKTX, ~0x00030880,
MCHBAR16_AND_OR(C0CKTX, ~0x00030880,
(pll->clkdelay[f][i] << 16) | (pll->clkdelay[f][i] << 16) |
(pll->dben[f][i] << 11) | (pll->dben[f][i] << 11) |
(pll->dbsel[f][i] << 7)); (pll->dbsel[f][i] << 7));
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment