Commit f5472a10 authored by Keith Hui's avatar Keith Hui Committed by Patrick Georgi
Browse files

superio/winbond/w83977tf: Only list IR logical device if needed



Really old versions of W83977TF Super I/O had an IR logical device, but
is no longer the case. It does not exist in the newer W83977EF version,
installed in some Asus P2B family boards, and served by this same code.

Add a config option on the off chance we may see board with it (as if
we would) and don't include this device unless it is set. Saves us from
the need to declare a not-present device off and/or extraneous PNP
device errors about a not-present device.

Change-Id: I761ebc41f1735a03e768339a68ca139167edc095
Signed-off-by: default avatarKeith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41004

Reviewed-by: default avatarAngel Pons <th3fanbus@gmail.com>
Tested-by: default avatarbuild bot (Jenkins) <no-reply@coreboot.org>
parent c844d14c
...@@ -4,3 +4,9 @@ ...@@ -4,3 +4,9 @@
config SUPERIO_WINBOND_W83977TF config SUPERIO_WINBOND_W83977TF
bool bool
select SUPERIO_WINBOND_COMMON_PRE_RAM select SUPERIO_WINBOND_COMMON_PRE_RAM
config W83977TF_HAVE_SEPARATE_IR_DEVICE
bool
help
Mainboard should select this option if it contains an old
version of W83977TF with a separate IR logical device.
...@@ -37,7 +37,9 @@ static struct pnp_info pnp_dev_info[] = { ...@@ -37,7 +37,9 @@ static struct pnp_info pnp_dev_info[] = {
{ NULL, W83977TF_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, }, { NULL, W83977TF_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, },
{ NULL, W83977TF_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1, { NULL, W83977TF_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1,
0x07ff, 0x07ff, }, 0x07ff, 0x07ff, },
#if CONFIG(W83977TF_HAVE_SEPARATE_IR_DEVICE)
{ NULL, W83977TF_CIR, PNP_IO0 | PNP_IRQ0, 0x07f8, }, { NULL, W83977TF_CIR, PNP_IO0 | PNP_IRQ0, 0x07f8, },
#endif
{ NULL, W83977TF_GAME_MIDI_GPIO1, PNP_IO0 | PNP_IO1 | PNP_IRQ0, { NULL, W83977TF_GAME_MIDI_GPIO1, PNP_IO0 | PNP_IO1 | PNP_IRQ0,
0x07ff, 0x07fe, }, 0x07ff, 0x07fe, },
{ NULL, W83977TF_ACPI, PNP_IRQ0, }, { NULL, W83977TF_ACPI, PNP_IRQ0, },
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment