1. 24 Feb, 2021 6 commits
    • Guido Gunther's avatar
      tests: Use longer timeout for client tests · 0a6b1ece
      Guido Gunther authored
      The client-tests need about 90s on my arm64 hardware so 120s (instead of
      the default 30s) looks save while not being too long in case of a
      deadlock.
      0a6b1ece
    • Michael Gratton's avatar
      Merge branch 'preview-crash' into 'mainline' · 7f0bb08c
      Michael Gratton authored
      Geary.Imap.FolderSession: Don't crash on empty preview
      
      See merge request GNOME/geary!667
      7f0bb08c
    • Michael Gratton's avatar
      Merge branch 'media-keys-navigation' into 'mainline' · 746a1e5b
      Michael Gratton authored
      Improve navigation using XF86Forward/Back keys
      
      Closes #1129
      
      See merge request GNOME/geary!666
      746a1e5b
    • Guido Gunther's avatar
      Geary.Imap.FolderSession: Don't crash on empty preview · b57567ff
      Guido Gunther authored
      If we didn't set a preview we crash like
      
          *[wrn] 12:54:59.0908 geary:application-certificate-manager.vala:74: No GCR slot URIs found, GCR certificate pinning unavailable
          *[wrn] 12:55:10.0501 Geary: [goa_account_1614080076_2] [imap] [GearyImapClientSession(selected:INBOX selected RW, GearyImapClientConnection(0001/imap.example.com:993/up)), Imap.Folder(>INBOX), ro: false, permanent_flags: \Answered \Flagged \* \Seen \Deleted \Draft, accepts_user_flags: true] GearyImapFolderSession: No preview specifiers "body.peek[1]<0.256>" and "body.peek[1.mime]" found
          *[wrn] 12:55:10.0502 Geary: [goa_account_1614080076_2] [imap] [GearyImapClientSession(selected:INBOX selected RW, GearyImapClientConnection(0001/imap.example.com:993/up)), Imap.Folder(>INBOX), ro: false, permanent_flags: \Answered \Flagged \* \Seen \Deleted \Draft, accepts_user_flags: true] GearyImapFolderSession:  - has body[1.mime]
          *[wrn] 12:55:10.0502 Geary: [goa_account_1614080076_2] [imap] [GearyImapClientSession(selected:INBOX selected RW, GearyImapClientConnection(0001/imap.example.com:993/up)), Imap.Folder(>INBOX), ro: false, permanent_flags: \Answered \Flagged \* \Seen \Deleted \Draft, accepts_user_flags: true] GearyImapFolderSession:  - has body[header.fields (references)]
          *[wrn] 12:55:10.0502 Geary: [goa_account_1614080076_2] [imap] [GearyImapClientSession(selected:INBOX selected RW, GearyImapClientConnection(0001/imap.example.com:993/up)), Imap.Folder(>INBOX), ro: false, permanent_flags: \Answered \Flagged \* \Seen \Deleted \Draft, accepts_user_flags: true] GearyImapFolderSession:  - has body[1]<0>
          ![crt] 12:55:10.0502 GLib:Did not see expected message GLib-GObject-WARNING **: g_object_weak_unref: couldn't find weak ref *
          ![crt] 12:55:10.0502 geary:geary_email_set_message_preview: assertion 'GEARY_RF_C822_IS_PREVIEW_TEXT (preview)' failed
      
          (gdb) bt
          #0  __GI_raise (sig=sig@entry=5) at ../sysdeps/unix/sysv/linux/raise.c:50
          #1  0x0000ffff919a71d8 in _g_log_abort (breakpoint=1) at ../../../glib/gmessages.c:554
          #2  g_logvPython Exception <class 'gdb.MemoryError'> Cannot access memory at address 0x8:
           (log_domain=0xffff91f1d908 "geary", log_level=10, format=<optimized out>, args=#3  0x0000ffff919a7440 in g_log (log_domain=<optimized out>, log_level=<optimized out>, format=<optimized out>)
              at ../../../glib/gmessages.c:1415
          #4  0x0000ffff91eabaf8 in geary_imap_folder_session_fetched_data_to_email
              (error=0xffff11aeb2f0, preview_charset_specifier=0xaaaafe108120 [GearyImapFetchBodyDataSpecifier], preview_specifier=0xaaaafe0ec070 [GearyImapFetchBodyDataSpecifier], body_specifier=0x0, header_specifiers_length1=<optimized out>, header_specifiers=0x0, required_fields=927, fetched_data=<optimized out>, uid=0xaaaafe48de90 [GearyImapUID], self=0xaaaafe1059b0 [GearyImapFolderSession])
              at src/engine/libgeary-engine.a.p/imap/api/imap-folder-session.c:6795
          #5  __lambda103_ (error=0xffff11aeb360, _data28_=0xaaaafdf2d760) at src/engine/libgeary-engine.a.p/imap/api/imap-folder-session.c:4541
          #6  ___lambda103__geary_nonblocking_concurrent_concurrent_callback (cancellable=<optimized out>, self=0xaaaafdf2d760, error=0xffff11aeb360) at src/engine/libgeary-engine.a.p/imap/api/imap-folder-session.c:4640
          #7  0x0000ffff91e412d0 in geary_nonblocking_concurrent_concurrent_operation_execute (self=0xaaaafe48f6d0 [GearyNonblockingConcurrentConcurrentOperation])
              at src/engine/libgeary-engine.a.p/nonblocking/nonblocking-concurrent.c:672
          #8  geary_nonblocking_concurrent_on_work_ready (op=0xaaaafe48f6d0 [GearyNonblockingConcurrentConcurrentOperation], self=<optimized out>)
              at src/engine/libgeary-engine.a.p/nonblocking/nonblocking-concurrent.c:501
          #9  _geary_nonblocking_concurrent_on_work_ready_gfunc (data=0xaaaafe48f6d0, self=<optimized out>) at src/engine/libgeary-engine.a.p/nonblocking/nonblocking-concurrent.c:296
          #10 0x0000ffff919ca3c8 in g_thread_pool_thread_proxy (data=<optimized out>) at ../../../glib/gthreadpool.c:354
          #11 0x0000ffff919c98f4 in g_thread_proxy (data=0xaaaafde2e120) at ../../../glib/gthread.c:820
          #12 0x0000ffff8b437628 in start_thread (arg=0xffff11aeb520) at pthread_create.c:477
          #13 0x0000ffff916a801c in thread_start () at ../sysdeps/unix/sysv/linux/aarch64/clone.S:78
      
      Create an empty preview to avoid that.
      b57567ff
    • Michael Gratton's avatar
      Merge branch 'mjog/replay-queue-fixes' into 'mainline' · ab81266b
      Michael Gratton authored
      Replay queue fixes
      
      Closes #216
      
      See merge request GNOME/geary!668
      ab81266b
    • Michał Kopeć's avatar
  2. 23 Feb, 2021 4 commits
  3. 19 Feb, 2021 1 commit
  4. 18 Feb, 2021 2 commits
  5. 16 Feb, 2021 1 commit
  6. 15 Feb, 2021 2 commits
  7. 11 Feb, 2021 1 commit
  8. 10 Feb, 2021 3 commits
  9. 09 Feb, 2021 1 commit
  10. 08 Feb, 2021 6 commits
  11. 07 Feb, 2021 7 commits
  12. 06 Feb, 2021 1 commit
  13. 05 Feb, 2021 2 commits
  14. 03 Feb, 2021 3 commits