• David Fries's avatar
    x86: fix i486 suspend to disk CR4 oops · e532c06f
    David Fries authored
    arch/x86/power/cpu_32.c __save_processor_state calls read_cr4()
    only a i486 CPU doesn't have the CR4 register.  Trying to read it
    produces an invalid opcode oops during suspend to disk.
    Use the safe rc4 reading op instead. If the value to be written is
    zero the write is skipped.
    done: swapped the use of %eax and %ecx to use jecxz for
    the zero test and jump over store to %cr4.
    restore_image: s/%ecx/%eax/ to be consistent with done:
    In addition to __save_processor_state, acpi_save_state_mem,
    efi_call_phys_prelog, and efi_call_phys_epilog had checks added
    (acpi restore was in assembly and already had a check for
    non-zero).  There were other reads and writes of CR4, but MCE and
    virtualization shouldn't be executed on a i486 anyway.
    Signed-off-by: default avatarDavid Fries <david@fries.net>
    Acked-by: default avatarH. Peter Anvin <hpa@zytor.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
hibernate_asm_32.S 1.6 KB