Skip to content
  • Paul Mundt's avatar
    spi: xilinx_spi: Fix up I/O routine wrapping bogosity. · 97782149
    Paul Mundt authored
    
    
    xilinx_spi presently makes some fairly questionable assumptions about I/O
    routines, and attempts to assign ioread32/iowrite32 and friends directly
    to its own internal function pointers. On many platforms these I/O
    routines are macros or wrappers and not actual functions on their own,
    resulting in things like:
    
    ERROR: "ioread32be" [drivers/spi/xilinx_spi.ko] undefined!
    ERROR: "iowrite32be" [drivers/spi/xilinx_spi.ko] undefined!
    ERROR: "iowrite32" [drivers/spi/xilinx_spi.ko] undefined!
    ERROR: "ioread32" [drivers/spi/xilinx_spi.ko] undefined!
    
    If xilinx_spi wants to do this sort of casting, it needs to provide its
    own wrappers for these, or change how it does accesses completely.
    
    I've opted for the first approach, and the attached silly patch does
    that. If someone with the hardware available wants to give the second
    option a try that's ok too. In any event, the current code is broken for
    at least: arm, avr32, blackfin, microblaze, mn10300, and sh.
    
    Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
    Acked-by: default avatarRichard Röjfors <richard.rojfors@pelagicore.com>
    Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
    97782149