1. 04 May, 2018 1 commit
  2. 23 Mar, 2018 9 commits
  3. 22 Mar, 2018 2 commits
    • Arnd Bergmann's avatar
      media: ngene: avoid unused variable warning · 492b183b
      Arnd Bergmann authored
      The newly added pdev variable is only used in an #ifdef, causing a
      build warning without CONFIG_PCI_MSI, unless we move the declaration
      inside the same #ifdef:
      
      drivers/media/pci/ngene/ngene-core.c: In function 'ngene_start':
      drivers/media/pci/ngene/ngene-core.c:1328:17: error: unused variable 'pdev' [-Werror=unused-variable]
      
      Fixes: 6795bf62 ("media: ngene: convert kernellog printing from printk() to dev_*() macros")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Acked-by: default avatarDaniel Scheller <d.scheller@gmx.net>
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      492b183b
    • Daniel Scheller's avatar
      media: ttpci: improve printing of encoded MAC address · 2c000f4d
      Daniel Scheller authored
      When loading the budget_av driver for ie. a KNC1 DVB-C TDA10024 card,
      which makes use of the ttpci eeprom check functionality (that always
      fails on these cards, but that's no issue at all), this is printed
      to the kernel log:
      
        [   10.497333] saa7146 (0): dma buffer size 192512
        [   10.497335] dvbdev: DVB: registering new adapter (KNC1 DVB-C TDA10024)
        [   10.545007] adapter failed MAC signature check
        [   10.545009] encoded MAC from EEPROM was
        [   10.545010] ff:
        [   10.545011] ff:
        [   10.545011] ff:
        ...
        [   10.545021] ff
        [   10.832422] budget_av: KNC1-4: MAC addr = 00:09:d6:6d:b3:be
      
      with the 'ff' being repeated for a total of 20 times. Improve that by
      using the %*phC format specifier instead dprintk()'ing every byte of the
      encoded MAC separately. This obsoletes the int i, and the kernel log
      looks cleaner:
      
        [ 3234.383153] saa7146 (0): dma buffer size 192512
        [ 3234.383154] dvbdev: DVB: registering new adapter (KNC1 DVB-C TDA10024)
        [ 3234.428745] adapter failed MAC signature check
        [ 3234.428747] encoded MAC from EEPROM was ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff
        [ 3234.728194] budget_av: KNC1-0: MAC addr = 00:09:d6:6d:b3:be
      Signed-off-by: default avatarDaniel Scheller <d.scheller@gmx.net>
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      2c000f4d
  4. 21 Mar, 2018 1 commit
    • Hans Verkuil's avatar
      media: add tuner standby op, use where needed · 3aab15af
      Hans Verkuil authored
      The v4l2_subdev core s_power op was used for two different things: power on/off
      sensors or video decoders/encoders and to put a tuner in standby (and only the
      tuner!). There is no 'tuner wakeup' op, that's done automatically when the tuner
      is accessed.
      
      The danger with calling (s_power, 0) to put a tuner into standby is that it is
      usually broadcast for all subdevs. So a video receiver subdev that supports
      s_power will also be powered off, and since there is no corresponding (s_power, 1)
      they will never be powered on again.
      
      In addition, this is specifically meant for tuners only since they draw the most
      current.
      
      This patch adds a new tuner op called 'standby' and replaces all calls to
      (core, s_power, 0) by (tuner, standby). This prevents confusion between the two
      uses of s_power. Note that there is no overlap: bridge drivers either just want
      to put the tuner into standby, or they deal with powering on/off sensors. Never
      both.
      
      This also makes it easier to replace s_power for the remaining bridge drivers
      with some PM code later.
      
      Whether we want something cleaner for tuners in the future is a separate topic.
      There is a lot of legacy code surrounding tuners, and I am very hesitant about
      making changes there.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      3aab15af
  5. 08 Mar, 2018 2 commits
  6. 07 Mar, 2018 5 commits
  7. 06 Mar, 2018 20 commits