1. 26 Sep, 2018 1 commit
    • Masahiro Yamada's avatar
      kbuild: add .DELETE_ON_ERROR special target · 69383cdc
      Masahiro Yamada authored
      [ Upstream commit 9c2af1c7 ]
      If Make gets a fatal signal while a shell is executing, it may delete
      the target file that the recipe was supposed to update.  This is needed
      to make sure that it is remade from scratch when Make is next run; if
      Make is interrupted after the recipe has begun to write the target file,
      it results in an incomplete file whose time stamp is newer than that
      of the prerequisites files.  Make automatically deletes the incomplete
      file on interrupt unless the target is marked .PRECIOUS.
      The situation is just the same as when the shell fails for some reasons.
      Usually when a recipe line fails, if it has changed the target file at
      all, the file is corrupted, or at least it is not completely updated.
      Yet the file’s time stamp says that it is now up to date, so the next
      time Make runs, it will not try to update that file.
      However, Make does not cater to delete the incomplete target file in
      this case.  We need to add .DELETE_ON_ERROR somewhere in the Makefile
      to request it.
      scripts/Kbuild.include seems a suitable place to add it because it is
      included from almost all sub-makes.
      Please note .DELETE_ON_ERROR is not effective for phony targets.
      The external module building should never ever touch the kernel tree.
      The following recipe fails if include/generated/autoconf.h is missing.
      However, include/config/auto.conf is not deleted since it is a phony
       PHONY += include/config/auto.conf
               $(Q)test -e include/generated/autoconf.h -a -e $@ || (          \
               echo >&2;                                                       \
               echo >&2 "  ERROR: Kernel configuration is invalid.";           \
               echo >&2 "         include/generated/autoconf.h or $@ are missing.";\
               echo >&2 "         Run 'make oldconfig && make prepare' on kernel src to fix it."; \
               echo >&2 ;                                                      \
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  2. 15 Sep, 2018 3 commits
  3. 09 Sep, 2018 1 commit
    • Masahiro Yamada's avatar
      kconfig: fix "Can't open ..." in parallel build · 476738bb
      Masahiro Yamada authored
      commit 98a4afbf upstream.
      If you run "make menuconfig" or "make nconfig" with -j<N> option in a
      fresh source tree, you will see several "Can't open ..." messages:
        $ make -j8 menuconfig
          HOSTCC  scripts/basic/fixdep
          YACC    scripts/kconfig/zconf.tab.c
          LEX     scripts/kconfig/zconf.lex.c
        /bin/sh: 1: .: Can't open scripts/kconfig/.mconf-cfg
        /bin/sh: 1: .: Can't open scripts/kconfig/.mconf-cfg
        /bin/sh: 1: .: Can't open scripts/kconfig/.mconf-cfg
        /bin/sh: 1: .:   HOSTCC  scripts/kconfig/lxdialog/checklist.o
        Can't open scripts/kconfig/.mconf-cfg
        /bin/sh: 1: .: Can't open scripts/kconfig/.mconf-cfg
        /bin/sh: 1: .: Can't open scripts/kconfig/.mconf-cfg
        /bin/sh: 1: .: Can't open scripts/kconfig/.mconf-cfg
          HOSTCC  scripts/kconfig/lxdialog/inputbox.o
        /bin/sh: 1: .: Can't open scripts/kconfig/.mconf-cfg
        /bin/sh: 1: .: Can't open scripts/kconfig/.mconf-cfg
        /bin/sh: 1: .: Can't open scripts/kconfig/.mconf-cfg
          UPD     scripts/kconfig/.mconf-cfg
        /bin/sh: 1: .: Can't open scripts/kconfig/.mconf-cfg
          HOSTCC  scripts/kconfig/lxdialog/menubox.o
          HOSTCC  scripts/kconfig/lxdialog/textbox.o
          HOSTCC  scripts/kconfig/lxdialog/util.o
          HOSTCC  scripts/kconfig/lxdialog/yesno.o
          HOSTCC  scripts/kconfig/mconf.o
          HOSTCC  scripts/kconfig/zconf.tab.o
          HOSTLD  scripts/kconfig/mconf
      Correct dependencies to fix this problem.
      Fixes: 1c5af5cf ("kconfig: refactor ncurses package checks for building mconf and nconf")
      Cc: linux-stable <stable@vger.kernel.org> # v4.18
      Reported-by: default avatarBorislav Petkov <bp@suse.de>
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      Tested-by: default avatarBorislav Petkov <bp@suse.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  4. 05 Sep, 2018 2 commits
  5. 17 Aug, 2018 1 commit
  6. 11 Aug, 2018 1 commit
  7. 16 Jul, 2018 1 commit
  8. 14 Jul, 2018 1 commit
  9. 12 Jul, 2018 1 commit
  10. 08 Jul, 2018 1 commit
  11. 06 Jul, 2018 2 commits
  12. 28 Jun, 2018 3 commits
  13. 27 Jun, 2018 1 commit
    • Linus Torvalds's avatar
      checkpatch: remove warning for 'old' stable@kernel.org address · 3b41c3e2
      Linus Torvalds authored
      It may not be the actual real stable mailing list address, but the
      stable scripts to actually pick up on the traditional way to mark stable
      There are also reasons to explicitly avoid using the actual mailing list
      address, since security patches with embargo dates generally do want the
      stable marking, but don't want tools etc to mistakenly send the patch
      out to the mailing list early.
      So don't warn for things that are still actively used and explicitly
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
  14. 25 Jun, 2018 2 commits
    • Dirk Gouders's avatar
      kconfig: fix line numbers for if-entries in menu tree · b2d00d7c
      Dirk Gouders authored
      The line numers for if-entries in the menu tree are off by one or more
      lines which is confusing when debugging for correctness of unrelated changes.
      According to the git log, commit a02f0570 (kconfig: improve
      error handling in the parser) was the last one that changed that part
      of the parser and replaced
      	"if_entry: T_IF expr T_EOL"
      	"if_entry: T_IF expr nl"
      but the commit message does not state why this has been done.
      When reverting that part of the commit, only the line numers are
      corrected (checked with cdebug = DEBUG_PARSE in zconf.y), otherwise
      the menu tree remains unchanged (checked with zconfdump() enabled in
      An example for the corrected line numbers:
      drivers/soc/Kconfig:15:source drivers/soc/tegra/Kconfig
      changes to:
      drivers/soc/Kconfig:15:source drivers/soc/tegra/Kconfig
      Signed-off-by: default avatarDirk Gouders <dirk@gouders.net>
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    • Sven Joachim's avatar
      stack-protector: Fix test with 32-bit userland and CONFIG_64BIT=y · 5391e536
      Sven Joachim authored
      When building a 64-bit 4.18-rc1 kernel with a 32-bit userland, I
      noticed that stack protection was silently disabled.  Adding -m64 in
      gcc-x86_64-has-stack-protector.sh fixed that, similar to what has been
      noticed in commit 2a61f474 ("stack-protector: test compiler
      capability in Kconfig and drop AUTO mode") for
      Signed-off-by: default avatarSven Joachim <svenjoac@gmx.de>
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
  15. 21 Jun, 2018 1 commit
  16. 15 Jun, 2018 6 commits
  17. 11 Jun, 2018 4 commits
  18. 08 Jun, 2018 6 commits
  19. 05 Jun, 2018 2 commits
    • Greg Kroah-Hartman's avatar
      staging: lustre: delete the filesystem from the tree. · be65f9ed
      Greg Kroah-Hartman authored
      The Lustre filesystem has been in the kernel tree for over 5 years now.
      While it has been an endless source of enjoyment for new kernel
      developers learning how to do basic codingstyle cleanups, as well as an
      semi-entertaining source of bewilderment from the vfs developers any
      time they have looked into the codebase to try to figure out how to port
      their latest api changes to this filesystem, it has not really moved
      forward into the "this is in shape to get out of staging" despite many
      half-completed attempts.
      And getting code out of staging is the main goal of that portion of the
      kernel tree.  Code should not stagnate and it feels like having this
      code in staging is only causing the development cycle of the filesystem
      to take longer than it should.  There is a whole separate out-of-tree
      copy of this codebase where the developers work on it, and then random
      changes are thrown over the wall at staging at some later point in time.
      This dual-tree development model has never worked, and the state of this
      codebase is proof of that.
      So, let's just delete the whole mess.  Now the lustre developers can go
      off and work in their out-of-tree codebase and not have to worry about
      providing valid changelog entries and breaking their patches up into
      logical pieces.  They can take the time they have spend doing those
      types of housekeeping chores and get the codebase into a much better
      shape, and it can be submitted for inclusion into the real part of the
      kernel tree when ready.
      Cc: Oleg Drokin <oleg.drokin@intel.com>
      Cc: Andreas Dilger <andreas.dilger@intel.com>
      Cc: James Simmons <jsimmons@infradead.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    • Peter Zijlstra (Intel)'s avatar
      scripts/faddr2line: make the new code listing format optional · 689135f0
      Peter Zijlstra (Intel) authored
      Commit 6870c016 ("scripts/faddr2line: show the code context")
      radically altered the output format of the faddr2line tool.  And while
      the new list output format might have merit it broke my vim usage and
      was hard to read.
      Make the new format optional; using a '--list' argument and attempt to
      make the output slightly easier to read by adding a little whitespace to
      separate the different files and explicitly mark the line in question.
      Cc: Changbin Du <changbin.du@intel.com>
      Fixes: 6870c016 ("scripts/faddr2line: show the code context")
      Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
      Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>