1. 16 Feb, 2010 1 commit
  2. 14 Aug, 2009 1 commit
    • Herbert Xu's avatar
      crypto: blkcipher - Do not use eseqiv on stream ciphers · 63b5ac28
      Herbert Xu authored
      Recently we switched to using eseqiv on SMP machines in preference
      over chainiv.  However, eseqiv does not support stream ciphers so
      they should still default to chainiv.
      
      This patch applies the same check as done by eseqiv to weed out
      the stream ciphers.  In particular, all algorithms where the IV
      size is not equal to the block size will now default to chainiv.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      63b5ac28
  3. 25 Jun, 2009 2 commits
    • Herbert Xu's avatar
      crypto: skcipher - Change default sync geniv on SMP to eseqiv · 0b67fb65
      Herbert Xu authored
      As it stands we use chainiv for sync algorithms and eseqiv for
      async algorithms.  However, when there is more than one CPU
      chainiv forces all processing to be serialised which is usually
      not what you want.  Also, the added overhead of eseqiv isn't that
      great.
      
      Therefore this patch changes the default sync geniv on SMP machines
      to eseqiv.  For the odd situation where the overhead is unacceptable
      then chainiv is still available as an option.
      
      Note that on UP machines chainiv is still preferred over eseqiv
      for sync algorithms.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      0b67fb65
    • Herbert Xu's avatar
      crypto: skcipher - Fix request for sync algorithms · 435578ae
      Herbert Xu authored
      When a sync givcipher algorithm is requested, if an async version
      of the same algorithm already exists, then we will loop forever
      without ever constructing the sync version based on a blkcipher.
      
      This is because we did not include the requested type/mask when
      getting a larval for the geniv algorithm that is to be constructed.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      435578ae
  4. 18 Feb, 2009 1 commit
    • Herbert Xu's avatar
      crypto: skcipher - Avoid infinite loop when cipher fails selftest · b170a137
      Herbert Xu authored
      When an skcipher constructed through crypto_givcipher_default fails
      its selftest, we'll loop forever trying to construct new skcipher
      objects but failing because it already exists.
      
      The crux of the issue is that once a givcipher fails the selftest,
      we'll ignore it on the next run through crypto_skcipher_lookup and
      attempt to construct a new givcipher.
      
      We should instead return an error to the caller if we find a
      givcipher that has failed the test.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      b170a137
  5. 23 Feb, 2008 1 commit
  6. 10 Jan, 2008 6 commits
    • Herbert Xu's avatar
      [CRYPTO] api: Show async type · 189ed66e
      Herbert Xu authored
      This patch adds an async field to /proc/crypto for ablkcipher and aead
      algorithms.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      189ed66e
    • Herbert Xu's avatar
      [CRYPTO] skcipher: Create default givcipher instances · b9c55aa4
      Herbert Xu authored
      This patch makes crypto_alloc_ablkcipher/crypto_grab_skcipher always
      return algorithms that are capable of generating their own IVs through
      givencrypt and givdecrypt.  Each algorithm may specify its default IV
      generator through the geniv field.
      
      For algorithms that do not set the geniv field, the blkcipher layer will
      pick a default.  Currently it's chainiv for synchronous algorithms and
      eseqiv for asynchronous algorithms.  Note that if these wrappers do not
      work on an algorithm then that algorithm must specify its own geniv or
      it can't be used at all.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      b9c55aa4
    • Herbert Xu's avatar
      [CRYPTO] skcipher: Add skcipher_geniv_alloc/skcipher_geniv_free · ecfc4329
      Herbert Xu authored
      This patch creates the infrastructure to help the construction of givcipher
      templates that wrap around existing blkcipher/ablkcipher algorithms by adding
      an IV generator to them.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      ecfc4329
    • Herbert Xu's avatar
      [CRYPTO] skcipher: Added geniv field · 23508e11
      Herbert Xu authored
      This patch introduces the geniv field which indicates the default IV
      generator for each algorithm.  It should point to a string that is not
      freed as long as the algorithm is registered.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      23508e11
    • Herbert Xu's avatar
      [CRYPTO] skcipher: Add givcrypt operations and givcipher type · 61da88e2
      Herbert Xu authored
      Different block cipher modes have different requirements for intialisation
      vectors.  For example, CBC can use a simple randomly generated IV while
      modes such as CTR must use an IV generation mechanisms that give a stronger
      guarantee on the lack of collisions.  Furthermore, disk encryption modes
      have their own IV generation algorithms.
      
      Up until now IV generation has been left to the users of the symmetric
      key cipher API.  This is inconvenient as the number of block cipher modes
      increase because the user needs to be aware of which mode is supposed to
      be paired with which IV generation algorithm.
      
      Therefore it makes sense to integrate the IV generation into the crypto
      API.  This patch takes the first step in that direction by creating two
      new ablkcipher operations, givencrypt and givdecrypt that generates an
      IV before performing the actual encryption or decryption.
      
      The operations are currently not exposed to the user.  That will be done
      once the underlying functionality has actually been implemented.
      
      It also creates the underlying givcipher type.  Algorithms that directly
      generate IVs would use it instead of ablkcipher.  All other algorithms
      (including all existing ones) would generate a givcipher algorithm upon
      registration.  This givcipher algorithm will be constructed from the geniv
      string that's stored in every algorithm.  That string will locate a template
      which is instantiated by the blkcipher/ablkcipher algorithm in question to
      give a givcipher algorithm.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      61da88e2
    • Herbert Xu's avatar
      [CRYPTO] skcipher: Add crypto_grab_skcipher interface · 378f4f51
      Herbert Xu authored
      Note: From now on the collective of ablkcipher/blkcipher/givcipher will
      be known as skcipher, i.e., symmetric key cipher.  The name blkcipher has
      always been much of a misnomer since it supports stream ciphers too.
      
      This patch adds the function crypto_grab_skcipher as a new way of getting
      an ablkcipher spawn.  The problem is that previously we did this in two
      steps, first getting the algorithm and then calling crypto_init_spawn.
      
      This meant that each spawn user had to be aware of what type and mask to
      use for these two steps.  This is difficult and also presents a problem
      when the type/mask changes as they're about to be for IV generators.
      
      The new interface does both steps together just like crypto_alloc_ablkcipher.
      
      As a side-effect this also allows us to be stronger on type enforcement
      for spawns.  For now this is only done for ablkcipher but it's trivial
      to extend for other types.
      
      This patch also moves the type/mask logic for skcipher into the helpers
      crypto_skcipher_type and crypto_skcipher_mask.
      
      Finally this patch introduces the function crypto_require_sync to determine
      whether the user is specifically requesting a sync algorithm.
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      378f4f51
  7. 10 Oct, 2007 2 commits
  8. 06 Aug, 2007 1 commit
  9. 11 Jul, 2007 2 commits
  10. 02 May, 2007 1 commit