• Evgeniy Polyakov's avatar
    connector: Delete buggy notification code. · f98bfbd7
    Evgeniy Polyakov authored
    On Tue, Feb 02, 2010 at 02:57:14PM -0800, Greg KH (gregkh@suse.de) wrote:
    > > There are at least two ways to fix it: using a big cannon and a small
    > > one. The former way is to disable notification registration, since it is
    > > not used by anyone at all. Second way is to check whether calling
    > > process is root and its destination group is -1 (kind of priveledged
    > > one) before command is dispatched to workqueue.
    > 
    > Well if no one is using it, removing it makes the most sense, right?
    > 
    > No objection from me, care to make up a patch either way for this?
    
    Getting it is not used, let's drop support for notifications about
    (un)registered events from connector.
    Another option was to check credentials on receiving, but we can always
    restore it without bugs if needed, but genetlink has a wider code base
    and none complained, that userspace can not get notification when some
    other clients were (un)registered.
    
    Kudos for Sebastian Krahmer <krahmer@suse.de>, who found a bug in the
    code.
    Signed-off-by: default avatarEvgeniy Polyakov <zbr@ioremap.net>
    Acked-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    f98bfbd7
Name
Last commit
Last update
..
Kconfig Loading commit data...
Makefile Loading commit data...
cn_proc.c Loading commit data...
cn_queue.c Loading commit data...
connector.c Loading commit data...