Use sorted_chat_list, which is now more appropriate.

We now make use of ui_data for tracking various objects.  And
so we no longer have to lookup in lists to find the objects.

Don't differentiate between IM and chats.  Use a single liststore
for any type of chats, and so we no longer require im_list, and
related helper models.

We don't have to list IM chats as buddies are listed separately

We were using the wrong variable to check for match
resulting in surprising results

So that we don't have to handle memory [de]allocations.

Use chatty_manager_add_chat() instead of chatty_manager_add_conversation()
So that we have one less API. Also add_chat() adds chat to the right
list instead of blindly adding to im_list, which was how it was done
until now.

libpurple may remove a node to simply add it again. It's hard
to know if the removal happened simply to add it again or not.

When an actual deletion happen, the associated PurpleConversation
is deleted, and so tracking PurpleConversation alone can make this
process simpler.

Otherwise the chat is simply destroyed, but the user is not left
from the active conversation, if any.  purple_conversation_destroy()
shall do that.

This can be useful to get the IM chat of a buddy if it
exists.  Currently we use a liststore to do so, which
shall be removed soon.

We were blindly adding all chats to im_list.  Let's check
the chat type and add chat to the appropriate list.

If ChattyChat has a PurpleBuddy or PurpleChat already set,
the `ui_data` of the PurpleConversation wasn't updated
when a conv is set for the chat.

So instead, check for PurpleBuddy/PurpleChat after the `ui_data'
is updated.  Also, remove previously set `ui_data` for the conv
already set in the chat, if any.

Move all chatty-conversation code to chatty-manager so that we
are closer to the plan to make manager alone deal with libpurple

If Return key press is set to send the inserted message, never insert
a newline when the key is pressed.

This was happening when the message input is empty and thus the Return
key press wasn't claimed to send the message.

If Return key is pressed with the message input empty, do an arror bell
instead

Fixes #391

"conversation-created" and "chat-joined" signals are emitted
immediately after the conversation is created.

When the conversation is created, it is handled by chatty_conv_new(),
which adds the PurpleConversation to the chat list.  So what ever
"conversation-created" and "chat-joined" callbacks where doing are
already done by chatty_conv_new().  So let's remove these signals
and their handlers as nothing is done there.

Code for setting buddy were duplicated.  Put
them into a function and use that.

Currently `ui_data` variable is not used.  Let's use it
so that we can eventually remove some list models to handle
chat list.

It's valid for a chat to not have a PurpleChat.  Also, we don't use
purple-chat property to set PurpleChat when creating an object from
PurpleConversation.

So Let's simply use direct pointer assignment instead of a property
so that we can have less code.

Don't duplicate code.

And reuse conv->ui_data for saving associated ChattyChat.

There is no reason to use bit twiddling here.

Mohammed Sadiq authored Aug 19, 2020 and Mohammed Sadiq committed Aug 20, 2020

Move Purple API to delete a chat to chatty-chat use that API
to delete a chat.

Mohammed Sadiq authored Aug 10, 2020 and Mohammed Sadiq committed Aug 19, 2020

We were always passing NULL as db