feedbackd Debian release 0.0.0+git20211018-1

We use these to lookup up the sound theme name

feedbackd v0.0.0+git20211018

It was still stuck at 2021-10-07. Fixup version too while at that.

Drop support for buster, this can be handled in downstream builds.

Remove the feedback and the associated callback data before invoking the
callback (which then triggers FbdFeebackBased:ended) since we otherwise
remove the data from the currently playing sound from the hash table
instead of removing the data from the sound that just finished playing.

Call flow for a repeating sound before:

  on_sound_play_finished_callback()
    data->callback()
      fbd_feedback_get_ended()
        on_fb_ended()
          fbd_feedback_run()
            g_hash_table_insert(..., feedback, data)
            fbd_dev_sound_play()
              gsound_context_play_full() [async]
    g_hash_table_remove (..., data->feedback) <- removes wrong feedback

So (since the feedback is still the same but only the callback data
changes) we end up removing the data from the currently playing sound
from the hash table and any calls to fbd_dev_sound_stop() would fail
to find data and hence not cancel the playing sound.

Call flow for a repeating sound now:

  on_sound_play_finished_callback()
    g_hash_table_remove (..., data->feedback)
    data->callback()
      fbd_feedback_get_ended()
        on_fb_ended()
          fbd_feedback_run()
            g_hash_table_insert(..., feedback, data)
            fbd_dev_sound_play()
              gsound_context_play_full() [async]

So we remove the data of the currently playing sound before adding
the feedback to the hash table again. No ownership is transfered to
the hash table so no cleanusp need to be changed.

Closes: #46

We name it `data` elsewhere. Don't call it `object` in one function.

The current name is just confusing

Fixes #45

Evangelos Ribeiro Tzaras authored Sep 06, 2021 and Guido Gunther committed Oct 08, 2021

Named after the corresponding notification from the sound naming spec:
http://0pointer.de/public/sound-naming-spec.html

Evangelos Ribeiro Tzaras authored Sep 06, 2021 and Guido Gunther committed Oct 08, 2021

Named after the corresponding notification from the sound naming spec:
http://0pointer.de/public/sound-naming-spec.html

Evangelos Ribeiro Tzaras authored Sep 06, 2021 and Guido Gunther committed Oct 08, 2021

Named after the corresponding notification from the sound naming spec:
http://0pointer.de/public/sound-naming-spec.html

This will make sure that the json theme file gets validated in CI.

For that we must not set a default event.

It's '-P', not '-p'.

The method is `trigger_feedback` not `trigger`.

Phosh recently changed to XDG_CURRENT_DESKTOP=GNOME:Phosh and has since stopped
using the configured theme and instead used the fallback freedesktop theme.

Closes #41

This would allow users to create their own feedback profiles
without editing system files or using root privileges

Signed-off-by: Pablo Correa Gómez <ablocorrea@hotmail.com>

The README currently states that feedbackd uses the `default.json` theme, whose
location is hardcoded into the application. This doesn't reflect the current
state of the code.

Explain the ability to add custom themes and give some examples to the user.
Also mention the `feedbackd-device-themes` repository explicitly for users
looking to modify the current `default.json` theme. Adds explanations about the
correct naming of custom theme files and theme file precedence when multiple
themes exist.

Previously, assembly of the theme paths for custom paths (based on
`XDG_DATA_DIRS`) was performed using `g_strconcat`, which produced erroneous
file paths with missing path separators due to a typo in the code.

Instead, make use of `g_build_filename` to assemble the theme paths from
`XDG_DATA_DIRS` to look for custom themes, which automatically introduces
host-specific path separators between individual path components. This
introduces another temporary variable to ensure that the filename (which is
itself assembled from a name and the file ending) isn't mangled by introduction
of a path separator between these two "parts".

Update to 0.0.0+git20210426

See merge request DebianOnMobile-team/feedbackd!6

Update to upstream version '0.0.0+git20210426'
with Debian dir ce67e973f713e33c09e66e1871ba0e0c60111e2c