Skip to content

GitLab

Commit 2f300b1e authored by Jose Blaya's avatar Jose Blaya
Browse files
Options

Merge branch 'release/3.0.0' into develop 

# Conflicts:
#	PIA VPN AdBlocker/Info.plist
#	PIA VPN Tunnel/Info.plist
#	PIA VPN/Info.plist
#	PIA VPNTests/Info.plist
#	PIA VPNUITests/Info.plist
#	Podfile
#	Podfile.lock
parents 579eea4e 963df4a2
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 1899 additions and 663 deletions
PIA VPN AdBlocker/Info.plist
View file @ 2f300b1e
......@@ -17,7 +17,7 @@
<key>CFBundlePackageType</key>
<string>XPC!</string>
<key>CFBundleShortVersionString</key>
<string>2.8.2</string>
<string>3.0.0</string>
<key>CFBundleVersion</key>
<string>1</string>
<key>NSExtension</key>
......
PIA VPN Tunnel/Info.plist
View file @ 2f300b1e
......@@ -17,7 +17,7 @@
<key>CFBundlePackageType</key>
<string>XPC!</string>
<key>CFBundleShortVersionString</key>
<string>2.8.2</string>
<string>3.0.0</string>
<key>CFBundleVersion</key>
<string>1</string>
<key>NSExtension</key>
......
PIA VPN.xcodeproj/project.pbxproj
View file @ 2f300b1e
This diff is collapsed.
PIA VPN.xcodeproj/xcshareddata/xcschemes/PIA VPN.xcscheme
View file @ 2f300b1e
......@@ -56,6 +56,16 @@
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "0EE2D77F1CB40A98000DEC4D"
BuildableName = "PIA VPNUITests.xctest"
BlueprintName = "PIA VPNUITests"
ReferencedContainer = "container:PIA VPN.xcodeproj">
</BuildableReference>
</TestableReference>
</Testables>
<MacroExpansion>
<BuildableReference
......
PIA VPN/AboutComponentCell.swift
View file @ 2f300b1e
......@@ -28,17 +28,18 @@ class AboutNoticeCell: UITableViewCell, Restylable {
labelCopyright.text = component.copyright
labelNotice.text = component.notice
buttonName.accessibilityTraits = UIAccessibilityTraitNone
buttonName.accessibilityTraits = UIAccessibilityTraits.none
buttonName.accessibilityLabel = component.name
}
// MARK: Restylable
func viewShouldRestyle() {
Theme.current.applySolidLightBackground(self)
Theme.current.applyTextButton(buttonName)
Theme.current.applySmallInfo(labelCopyright, appearance: .dark)
Theme.current.applySmallInfo(labelNotice, appearance: .dark)
Theme.current.applySecondaryBackground(self)
buttonName.style(style: TextStyle.textStyle9)
Theme.current.applySubtitle(labelCopyright)
Theme.current.applySubtitle(labelNotice)
}
}
......@@ -110,7 +111,7 @@ class AboutLicenseCell: UITableViewCell, Restylable {
}
buttonMore.setImage(moreImage, for: .normal)
buttonName.accessibilityTraits = UIAccessibilityTraitNone
buttonName.accessibilityTraits = UIAccessibilityTraits.none
buttonName.accessibilityLabel = component.name
buttonName.accessibilityHint = L10n.About.Accessibility.Component.expand
}
......@@ -152,11 +153,11 @@ class AboutLicenseCell: UITableViewCell, Restylable {
// MARK: Restylable
func viewShouldRestyle() {
Theme.current.applySolidLightBackground(self)
Theme.current.applyLightBackground(textLicense)
Theme.current.applyTextButton(buttonName)
Theme.current.applySmallInfo(labelCopyright, appearance: .dark)
Theme.current.applyBody1Monospace(textLicense, appearance: .dark)
Theme.current.applySecondaryBackground(self)
Theme.current.applyPrincipalBackground(textLicense)
buttonName.style(style: TextStyle.textStyle9)
Theme.current.applySubtitle(labelCopyright)
Theme.current.applyLicenseMonospaceFontAndColor(textLicense, appearance: .dark)
buttonMore.tintColor = textLicense.textColor
gradientLicense?.removeFromSuperview()
......
PIA VPN/AboutViewController.swift
View file @ 2f300b1e
......@@ -36,10 +36,13 @@ class AboutViewController: AutolayoutViewController {
override func viewDidLoad() {
super.viewDidLoad()
title = L10n.Menu.Item.about
let textApp = L10n.About.app
labelIntro.text = "Copyright © \(AppConfiguration.About.copyright) \(AppConfiguration.About.companyName)\n\(textApp) \(Macros.versionFullString()!)"
tableView.scrollsToTop = true
let nc = NotificationCenter.default
nc.addObserver(self, selector: #selector(viewHasRotated), name: UIDevice.orientationDidChangeNotification, object: nil)
}
override func viewDidAppear(_ animated: Bool) {
......@@ -48,13 +51,18 @@ class AboutViewController: AutolayoutViewController {
loadLicensesInBackground()
}
override func viewWillAppear(_ animated: Bool) {
super.viewWillAppear(animated)
styleNavigationBarWithTitle(L10n.Menu.Item.about)
}
override func viewDidLayoutSubviews() {
super.viewDidLayoutSubviews()
guard let headerView = tableView.tableHeaderView else {
return
}
let height = headerView.systemLayoutSizeFitting(UILayoutFittingCompressedSize).height
let height = headerView.systemLayoutSizeFitting(UIView.layoutFittingCompressedSize).height
var frame = headerView.frame
frame.size.height = height
headerView.frame = frame
......@@ -63,8 +71,16 @@ class AboutViewController: AutolayoutViewController {
headerView.layoutIfNeeded()
}
deinit {
NotificationCenter.default.removeObserver(self)
}
// MARK: Helpers
@objc private func viewHasRotated() {
styleNavigationBarWithTitle(L10n.Menu.Item.settings)
}
private func loadLicensesInBackground() {
for component in components.licenses {
performSelector(inBackground: #selector(fetchLicenseWithComponent(_:)), with: component)
......@@ -78,7 +94,7 @@ class AboutViewController: AutolayoutViewController {
DispatchQueue.main.async {
self.licenseByComponentName[component.name] = license
guard let index = self.components.licenses.index(of: component) else {
guard let index = self.components.licenses.firstIndex(of: component) else {
return
}
self.tableView.reloadRows(at: [IndexPath(row: index, section: 1)], with: .none)
......@@ -86,12 +102,21 @@ class AboutViewController: AutolayoutViewController {
}
// MARK: Restylable
override func viewShouldRestyle() {
super.viewShouldRestyle()
Theme.current.applySolidLightBackground(tableView)
Theme.current.applyBody1(labelIntro, appearance: .dark)
tableView.separatorInset = UIEdgeInsets(top: 0, left: 30, bottom: 0, right: 0)
Theme.current.applyDividerToSeparator(tableView)
styleNavigationBarWithTitle(L10n.Menu.Item.about)
// XXX: for some reason, UITableView is not affected by appearance updates
if let viewContainer = viewContainer {
Theme.current.applyPrincipalBackground(view)
Theme.current.applyPrincipalBackground(viewContainer)
}
Theme.current.applyPrincipalBackground(tableView)
Theme.current.applySubtitle(labelIntro)
}
}
......
PIA VPN/AccountViewController.swift
View file @ 2f300b1e
......@@ -29,7 +29,7 @@ class AccountViewController: AutolayoutViewController {
@IBOutlet private weak var labelUsername: UILabel!
@IBOutlet private weak var textUsername: BorderedTextField!
@IBOutlet private weak var textUsername: UITextField!
@IBOutlet private weak var labelFooterOther: UILabel!
......@@ -37,6 +37,8 @@ class AccountViewController: AutolayoutViewController {
@IBOutlet private weak var itemUpdate: UIBarButtonItem!
@IBOutlet private weak var viewAccountInfo: UIView!
@IBOutlet private weak var viewSeparator: UIView!
@IBOutlet private weak var viewUncredited: UIView!
......@@ -78,12 +80,12 @@ class AccountViewController: AutolayoutViewController {
viewSafe.layoutMargins = .zero
textEmail.isEditable = true
textUsername.isEditable = false
textUsername.isUserInteractionEnabled = false
canSaveAccount = false
let nc = NotificationCenter.default
nc.addObserver(self, selector: #selector(redisplayAccount), name: .PIAAccountDidRefresh, object: nil)
nc.addObserver(self, selector: #selector(accountDidLogout(notification:)), name: .PIAAccountDidLogout, object: nil)
nc.addObserver(self, selector: #selector(viewHasRotated), name: UIDevice.orientationDidChangeNotification, object: nil)
Client.providers.accountProvider.retrieveAccount()
}
......@@ -92,6 +94,7 @@ class AccountViewController: AutolayoutViewController {
super.viewWillAppear(animated)
// update local state immediately
styleNavigationBarWithTitle(L10n.Menu.Item.account)
redisplayAccount()
}
......@@ -115,6 +118,10 @@ class AccountViewController: AutolayoutViewController {
establishUncreditedVisibility()
}
@objc private func viewHasRotated() {
styleNavigationBarWithTitle(L10n.Menu.Item.settings)
}
// MARK: Actions
@IBAction private func saveChanges(_ sender: Any?) {
......@@ -129,9 +136,9 @@ class AccountViewController: AutolayoutViewController {
return
}
let alert = Macros.alert(L10n.Account.Update.Email.Require.Password.title,
L10n.Account.Update.Email.Require.Password.message)
let alert = Macros.alertController(L10n.Account.Update.Email.Require.Password.title,
L10n.Account.Update.Email.Require.Password.message)
alert.addCancelAction(L10n.Global.cancel)
let action = UIAlertAction(title: L10n.Account.Update.Email.Require.Password.button,
style: .default) { [weak self] (alertAction) in
......@@ -143,11 +150,11 @@ class AccountViewController: AutolayoutViewController {
log.debug("Account: Modifying account email...")
let request = UpdateAccountRequest(email: email)
let hud = HUD()
weakSelf.showLoadingAnimation()
Client.providers.accountProvider.update(with: request,
andPassword: password) { (info, error) in
hud.hide()
weakSelf.hideLoadingAnimation()
guard let _ = info else {
if let error = error {
......@@ -158,7 +165,7 @@ class AccountViewController: AutolayoutViewController {
weakSelf.textEmail.text = ""
let alert = Macros.alert(L10n.Global.error, L10n.Account.Error.unauthorized)
alert.addCancelAction(L10n.Global.close)
alert.addDefaultAction(L10n.Global.close)
self?.present(alert, animated: true, completion: nil)
return
......@@ -166,7 +173,7 @@ class AccountViewController: AutolayoutViewController {
log.debug("Account: Email successfully modified")
let alert = Macros.alert(nil, L10n.Account.Save.success)
alert.addCancelAction(L10n.Global.ok)
alert.addDefaultAction(L10n.Global.ok)
weakSelf.present(alert, animated: true, completion: nil)
weakSelf.textEmail.text = email
weakSelf.textEmail.endEditing(true)
......@@ -211,14 +218,14 @@ class AccountViewController: AutolayoutViewController {
log.error("IAP: Failed to restore payment receipt (error: \(error?.localizedDescription ?? ""))")
let alert = Macros.alert(L10n.Global.error, error?.localizedDescription)
alert.addCancelAction(L10n.Global.close)
alert.addDefaultAction(L10n.Global.close)
present(alert, animated: true, completion: nil)
}
private func handleReceiptSubmissionWithError(_ error: Error?) {
if let error = error {
let alert = Macros.alert(L10n.Global.error, error.localizedDescription)
alert.addCancelAction(L10n.Global.close)
alert.addDefaultAction(L10n.Global.close)
present(alert, animated: true, completion: nil)
return
}
......@@ -229,7 +236,7 @@ class AccountViewController: AutolayoutViewController {
L10n.Renewal.Success.title,
L10n.Renewal.Success.message
)
alert.addCancelAction(L10n.Global.close)
alert.addDefaultAction(L10n.Global.close)
present(alert, animated: true, completion: nil)
redisplayAccount()
......@@ -240,15 +247,11 @@ class AccountViewController: AutolayoutViewController {
L10n.Account.Restore.Failure.title,
L10n.Account.Restore.Failure.message
)
alert.addCancelAction(L10n.Global.close)
alert.addDefaultAction(L10n.Global.close)
present(alert, animated: true, completion: nil)
}
// MARK: Notifications
@objc private func accountDidLogout(notification: Notification) {
dismissModal()
}
@objc private func redisplayAccount() {
currentUser = Client.providers.accountProvider.currentUser
......@@ -288,19 +291,27 @@ class AccountViewController: AutolayoutViewController {
override func viewShouldRestyle() {
super.viewShouldRestyle()
for label in [labelEmail!, labelUsername!] {
Theme.current.applyLabel(label, appearance: .dark)
styleNavigationBarWithTitle(L10n.Menu.Item.account)
if let viewContainer = viewContainer {
Theme.current.applyPrincipalBackground(view)
Theme.current.applyPrincipalBackground(viewContainer)
}
Theme.current.applySecondaryBackground(viewAccountInfo)
Theme.current.applySubtitle(labelEmail)
Theme.current.applySubtitle(labelUsername)
Theme.current.applyInput(textEmail)
Theme.current.applyInput(textUsername)
Theme.current.applyDivider(viewSeparator)
Theme.current.applyClearTextfield(textUsername)
for label in [labelFooterOther!, labelExpiryInformation!] {
Theme.current.applySmallInfo(label, appearance: .dark)
Theme.current.applySubtitle(label)
}
Theme.current.applyBody2(labelRestoreTitle, appearance: .dark)
Theme.current.applyBody1(labelRestoreInfo, appearance: .dark)
Theme.current.applyTextButton(buttonRestore)
Theme.current.applyTitle(labelRestoreTitle, appearance: .dark)
Theme.current.applySubtitle(labelRestoreInfo)
buttonRestore.style(style: TextStyle.textStyle9)
styleExpirationDate()
}
......
PIA VPN/AppConfiguration.swift
View file @ 2f300b1e
......@@ -18,14 +18,14 @@ struct AppConfiguration {
}
struct About {
static let copyright = "2014-2018"
static let copyright = "2014-2019"
static let companyName = "London Trust Media, Inc."
}
struct Welcome {
static func defaultPreset() -> PIAWelcomeViewController.Preset {
var preset = PIAWelcomeViewController.Preset()
static func defaultPreset() -> Preset {
var preset = Preset()
guard Flags.shared.customizesWelcomePreset else {
return preset
}
......
PIA VPN/AppConstants.swift
View file @ 2f300b1e
......@@ -48,6 +48,11 @@ struct AppConstants {
static let adBlockerBundleIdentifier = "com.privateinternetaccess.ios.PIA-VPN.AdBlocker"
}
struct SiriShortcuts {
static let shortcutConnect = "com.privateinternetaccess.ios.PIA-VPN.connect"
static let shortcutDisconnect = "com.privateinternetaccess.ios.PIA-VPN.disconnect"
}
struct Web {
static let homeURL = URL(string: "https://www.privateinternetaccess.com/")!
......@@ -118,4 +123,10 @@ struct AppConstants {
return typeface
}()
}
struct VPNWidget {
static let vpnStatus = "vpn.status"
static let vpnButtonDescription = "vpn.button.description"
}
}
PIA VPN/AppDelegate.swift
View file @ 2f300b1e
......@@ -32,7 +32,7 @@ class AppDelegate: NSObject, UIApplicationDelegate {
NotificationCenter.default.removeObserver(self)
}
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey : Any]? = nil) -> Bool {
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey : Any]? = nil) -> Bool {
Bootstrapper.shared.bootstrap()
application.shortcutItems = []
......@@ -61,8 +61,8 @@ class AppDelegate: NSObject, UIApplicationDelegate {
L10n.Notifications.Disabled.title,
L10n.Notifications.Disabled.message
)
alert.addDefaultAction(L10n.Notifications.Disabled.settings) {
application.openURL(URL(string: UIApplicationOpenSettingsURLString)!)
alert.addActionWithTitle(L10n.Notifications.Disabled.settings) {
application.openURL(URL(string: UIApplication.openSettingsURLString)!)
}
alert.addCancelAction(L10n.Global.ok)
window?.rootViewController?.present(alert, animated: true, completion: nil)
......@@ -74,7 +74,7 @@ class AppDelegate: NSObject, UIApplicationDelegate {
application.applicationIconBadgeNumber = 0
}
func application(_ app: UIApplication, open url: URL, options: [UIApplicationOpenURLOptionsKey : Any] = [:]) -> Bool {
func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool {
log.debug("Opened app from URL: \(url)")
guard let host = url.host else {
return false
......@@ -86,6 +86,15 @@ class AppDelegate: NSObject, UIApplicationDelegate {
// in case it's too early for notification delivery (vc not loaded)
TransientState.shouldDisplayRegionPicker = true
case VPNStatus.connected.rawValue:
if Client.providers.vpnProvider.isVPNConnected {
disconnectAfter(milliseconds: 200)
}
case VPNStatus.disconnected.rawValue:
if !Client.providers.vpnProvider.isVPNConnected {
connectAfter(milliseconds: 200)
}
default:
return false
}
......@@ -165,9 +174,7 @@ class AppDelegate: NSObject, UIApplicationDelegate {
case .connect:
if !Client.providers.vpnProvider.isVPNConnected {
// this time delay seems to fix a strange issue of the VPN connecting from a fresh launch
Macros.dispatch(after: .milliseconds(200)) {
Client.providers.vpnProvider.connect(nil)
}
connectAfter(milliseconds: 200)
}
case .disconnect:
......@@ -175,9 +182,7 @@ class AppDelegate: NSObject, UIApplicationDelegate {
// this time delay seems to fix a strange issue of the VPN disconnecting and
// then automatically reconnecting when it's done from a fresh launch
Macros.dispatch(after: .milliseconds(200)) {
Client.providers.vpnProvider.disconnect(nil)
}
disconnectAfter(milliseconds: 200)
}
case .selectRegion:
......@@ -191,4 +196,32 @@ class AppDelegate: NSObject, UIApplicationDelegate {
}
}
//MARK: Siri Shortcuts
func application(_ application: UIApplication, continue userActivity: NSUserActivity, restorationHandler: @escaping ([UIUserActivityRestoring]?) -> Void) -> Bool {
if userActivity.activityType == AppConstants.SiriShortcuts.shortcutConnect {
if AppPreferences.shared.useConnectSiriShortcuts {
connectAfter(milliseconds: 200)
}
return AppPreferences.shared.useConnectSiriShortcuts
} else {
if AppPreferences.shared.useDisconnectSiriShortcuts {
disconnectAfter(milliseconds: 200)
}
return AppPreferences.shared.useDisconnectSiriShortcuts
}
}
private func connectAfter(milliseconds: Int) {
Macros.dispatch(after: .milliseconds(milliseconds)) {
Client.providers.vpnProvider.connect(nil)
}
}
private func disconnectAfter(milliseconds: Int) {
Macros.dispatch(after: .milliseconds(milliseconds)) {
Client.providers.vpnProvider.disconnect(nil)
}
}
}
PIA VPN/AppPreferences.swift
View file @ 2f300b1e
......@@ -10,10 +10,12 @@ import Foundation
import PIALibrary
import PIATunnel
import SwiftyBeaver
import Intents
private let log = SwiftyBeaver.self
class AppPreferences {
private struct Entries {
static let version = "Version"
......@@ -28,6 +30,20 @@ class AppPreferences {
static let lastVPNConnectionStatus = "LastVPNConnectionStatus"
static let piaSocketType = "PIASocketType"
static let favoriteServerIdentifiers = "FavoriteServerIdentifiers"
static let regionFilter = "RegionFilter"
static let useConnectSiriShortcuts = "UseConnectSiriShortcuts"
static let connectShortcut = "ConnectShortcut"
static let useDisconnectSiriShortcuts = "UseDisconnectSiriShortcuts"
static let disconnectShortcut = "disconnectShortcut"
static let todayWidgetVpnStatus = "vpn.status"
static let todayWidgetButtonTitle = "vpn.button.description"
}
static let shared = AppPreferences()
......@@ -104,6 +120,100 @@ class AppPreferences {
}
}
var favoriteServerIdentifiers: [String] {
get {
if let serverIdentifiers = defaults.array(forKey: Entries.favoriteServerIdentifiers) as? [String] {
return serverIdentifiers
}
return []
}
set {
defaults.set(newValue, forKey: Entries.favoriteServerIdentifiers)
}
}
var regionFilter: RegionFilter {
get {
guard let rawValue = defaults.string(forKey: Entries.regionFilter) else {
return .name
}
return RegionFilter(rawValue: rawValue) ?? .name
}
set {
defaults.set(newValue.rawValue, forKey: Entries.regionFilter)
}
}
var useConnectSiriShortcuts: Bool {
get {
return defaults.bool(forKey: Entries.useConnectSiriShortcuts)
}
set {
defaults.set(newValue, forKey: Entries.useConnectSiriShortcuts)
}
}
var useDisconnectSiriShortcuts: Bool {
get {
return defaults.bool(forKey: Entries.useDisconnectSiriShortcuts)
}
set {
defaults.set(newValue, forKey: Entries.useDisconnectSiriShortcuts)
}
}
var todayWidgetVpnStatus: String? {
get {
return defaults.string(forKey: Entries.todayWidgetVpnStatus) ?? L10n.Today.Widget.login
}
set {
defaults.set(newValue, forKey: Entries.todayWidgetVpnStatus)
}
}
var todayWidgetButtonTitle: String? {
get {