Skip to content

GitLab

Commit 4aecfa61 authored by Davide De Rosa's avatar Davide De Rosa
Browse files

Merge branch 'feature/92-consider-re-adding-subscription-info' into 'develop' 

Expiration date information (issue #92 in vpn-ios project)

See merge request ios/client-library-apple!103
parents 82be595f cff9a858
Hide whitespace changes
Inline Side-by-side
Showing with 94 additions and 2 deletions
PIALibrary.podspec
View file @ 4aecfa61
Pod::Spec.new do |s|
s.name = "PIALibrary"
s.version = "1.1.3"
s.version = "1.1.4"
s.summary = "PIA client library in Swift."
s.homepage = "https://www.privateinternetaccess.com/"
......
PIALibrary.xcodeproj/project.pbxproj
View file @ 4aecfa61
......@@ -240,6 +240,8 @@
0EFEB4C420077AC900F81029 /* PIATunnelProvider+Profile.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0EFEB4BF2007784A00F81029 /* PIATunnelProvider+Profile.swift */; };
0EFEB4C520077AC900F81029 /* PIATunnelProfile.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0EFEB4C02007784A00F81029 /* PIATunnelProfile.swift */; };
5EA54E484C7FD035341E021E /* Pods_PIALibrary_PIALibraryTests_iOS.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 9A22DD34A821A4EDAED288D2 /* Pods_PIALibrary_PIALibraryTests_iOS.framework */; };
843C67C22122E714005A3FDA /* AccountInfoTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 843C67C12122E714005A3FDA /* AccountInfoTests.swift */; };
843C67C32122EA13005A3FDA /* AccountInfoTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 843C67C12122E714005A3FDA /* AccountInfoTests.swift */; };
A56365AB3EAA4588B479616A /* Pods_PIALibrary_PIALibraryHost_iOS.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 476E8514A236C48F405ACA40 /* Pods_PIALibrary_PIALibraryHost_iOS.framework */; };
E07462773BC314E3183B240E /* Pods_PIALibrary_PIALibrary_iOS.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 2FC5BF5764146CA9C6104276 /* Pods_PIALibrary_PIALibrary_iOS.framework */; };
/* End PBXBuildFile section */
......@@ -479,6 +481,7 @@
378AC49FB4E07B2415156492 /* Pods-PIALibrary-PIALibraryTests-iOS.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-PIALibrary-PIALibraryTests-iOS.release.xcconfig"; path = "Pods/Target Support Files/Pods-PIALibrary-PIALibraryTests-iOS/Pods-PIALibrary-PIALibraryTests-iOS.release.xcconfig"; sourceTree = "<group>"; };
476E8514A236C48F405ACA40 /* Pods_PIALibrary_PIALibraryHost_iOS.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_PIALibrary_PIALibraryHost_iOS.framework; sourceTree = BUILT_PRODUCTS_DIR; };
64C04C071DE1CB44DE7945D6 /* Pods-PIALibrary-PIALibrary-iOS.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-PIALibrary-PIALibrary-iOS.debug.xcconfig"; path = "Pods/Target Support Files/Pods-PIALibrary-PIALibrary-iOS/Pods-PIALibrary-PIALibrary-iOS.debug.xcconfig"; sourceTree = "<group>"; };
843C67C12122E714005A3FDA /* AccountInfoTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AccountInfoTests.swift; sourceTree = "<group>"; };
9A22DD34A821A4EDAED288D2 /* Pods_PIALibrary_PIALibraryTests_iOS.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_PIALibrary_PIALibraryTests_iOS.framework; sourceTree = BUILT_PRODUCTS_DIR; };
BD0536741E220873045CBCC7 /* Pods-PIALibrary-PIALibraryHost-iOS.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-PIALibrary-PIALibraryHost-iOS.debug.xcconfig"; path = "Pods/Target Support Files/Pods-PIALibrary-PIALibraryHost-iOS/Pods-PIALibrary-PIALibraryHost-iOS.debug.xcconfig"; sourceTree = "<group>"; };
E865E7775CCB07BA4CE22DEE /* Pods_PIALibrary_PIALibrary_macOS.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_PIALibrary_PIALibrary_macOS.framework; sourceTree = BUILT_PRODUCTS_DIR; };
......@@ -910,6 +913,7 @@
0E53A8591FE5E3CD000C2A18 /* MockProviders.swift */,
0EA4C4411FDDFD830041C3D8 /* ServerTests.swift */,
0E2ADD441FE1583A00BB170C /* VPNTests.swift */,
843C67C12122E714005A3FDA /* AccountInfoTests.swift */,
0EE78B011F818A20002E4CDD /* Info-iOS.plist */,
0E2ADD201FE13B8600BB170C /* Info-macOS.plist */,
);
......@@ -1342,6 +1346,7 @@
buildActionMask = 2147483647;
files = (
0E2ADD291FE13C3B00BB170C /* ServerTests.swift in Sources */,
843C67C32122EA13005A3FDA /* AccountInfoTests.swift in Sources */,
0E2ADD461FE1583A00BB170C /* VPNTests.swift in Sources */,
0E53A85B1FE5E3CD000C2A18 /* MockProviders.swift in Sources */,
0E2ADD281FE13C3B00BB170C /* AccountTests.swift in Sources */,
......@@ -1566,6 +1571,7 @@
buildActionMask = 2147483647;
files = (
0E53A85A1FE5E3CD000C2A18 /* MockProviders.swift in Sources */,
843C67C22122E714005A3FDA /* AccountInfoTests.swift in Sources */,
0EE78B001F818A20002E4CDD /* AccountTests.swift in Sources */,
0EA4C4421FDDFD840041C3D8 /* ServerTests.swift in Sources */,
0EB8C0461F9CCB7C005857E4 /* AccountSignupTests.swift in Sources */,
......
PIALibrary/Sources/Core/WebServices/AccountInfo.swift
View file @ 4aecfa61
......@@ -52,4 +52,15 @@ public struct AccountInfo {
newInfo.email = email
return newInfo
}
/// Return the Human Readable Date for the expirationDate var.
/// - Parameters:
/// locale: The locale to format the date, by default will use the locale of the device
public func humanReadableExpirationDate(usingLocale locale: Locale = Locale.current) -> String {
let dateFormatter = DateFormatter()
dateFormatter.dateStyle = .long
dateFormatter.timeStyle = .none
dateFormatter.locale = locale
return dateFormatter.string(from: self.expirationDate)
}
}
PIALibrary/Sources/UI/iOS/Theme.swift
View file @ 4aecfa61
......@@ -386,6 +386,26 @@ public class Theme {
textView.textColor = palette.textColor(forRelevance: 3, appearance: .dark)
}
/// Method to apply a second style for the same UILabel
/// label.text should be previously set
public func makeSmallLabelToStandOut(_ label: UILabel,
withTextToStandOut textToStandOut: String,
andAppearance appearance: Appearance = Appearance.dark) {
if let text = label.text {
let rangeSecondText = (text as NSString).range(of: textToStandOut)
let attributedString = NSMutableAttributedString(string: text)
attributedString.addAttribute(.foregroundColor,
value: palette.textColor(forRelevance: 1,
appearance: appearance),
range: rangeSecondText)
label.attributedText = attributedString
}
}
/// :nodoc:
public func applyTag(_ label: UILabel, appearance: Appearance) {
label.font = typeface.regularFont(size: 12.0)
......
PIALibraryTests/AccountInfoTests.swift 0 → 100644
View file @ 4aecfa61
//
// AccountInfoTests.swift
// PIALibraryTests-iOS
//
// Created by Jose Antonio Blaya Garcia on 14/8/18.
// Copyright © 2018 London Trust Media. All rights reserved.
//
import XCTest
@testable import PIALibrary
class AccountInfoTests: XCTestCase {
private let mock = MockProviders()
private var theDate: Date!
private var accountInfo: AccountInfo!
override func setUp() {
super.setUp()
let dateFormatter = DateFormatter()
dateFormatter.dateFormat = "dd-MM-yyyy"
self.theDate = dateFormatter.date(from: "14-08-2018")
self.accountInfo = AccountInfo(email: "email@email.com",
plan: Plan.monthly,
isRenewable: false,
isRecurring: false,
expirationDate: self.theDate,
shouldPresentExpirationAlert: false,
renewUrl: nil)
}
override func tearDown() {
self.theDate = nil
self.accountInfo = nil
super.tearDown()
}
public func testExpirationDateDefaultLocale() {
//We are going to asume for the test the default Locale is en_US
XCTAssertEqual(accountInfo.humanReadableExpirationDate(usingLocale: Locale(identifier: "en_US")),
"August 14, 2018",
"The human readable format is not correct")
}
public func testExpirationDateUsingSpanishLocale() {
XCTAssertEqual(accountInfo.humanReadableExpirationDate(usingLocale: Locale(identifier: "es_ES")),
"14 de agosto de 2018",
"The human readable format is not correct")
}
}
Podfile
View file @ 4aecfa61
......@@ -7,7 +7,7 @@ abstract_target 'PIALibrary' do
pod 'Alamofire', '~> 4'
pod 'ReachabilitySwift'
#pod 'PIATunnel', :git => 'https://github.com/pia-foss/tunnel-apple.git', :commit => 'dfe7f3c'
pod 'PIATunnel', '~> 1.1.3'
pod 'PIATunnel', '~> 1.1.4'
target 'PIALibrary-iOS' do
platform :ios, '9.0'
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment