Commit 7fc9e315 authored by Martin Kepplinger's avatar Martin Kepplinger
Browse files

TODO: usb: typec: tipd: keep default interrupts enabled during probe()

TODO: mainline the interrupt handling for all events that we need,
revert this patch and instead exted this mask accordingly.

Commit 9990f2f6 ("usb: typec: tipd: Enable event interrupts by default")
writes a fixed set of interrupts to TPS_REG_INT_MASK1. In case interrupts
had been enabled by the firmware by default, these get disabled now
which can break use cases. Only append to what is already enabled instead.

Fixes: 9990f2f6

 ("usb: typec: tipd: Enable event interrupts by default")
Signed-off-by: Martin Kepplinger's avatarMartin Kepplinger <martin.kepplinger@puri.sm>
parent 25e50246
Pipeline #74295 passed with stage
in 95 minutes and 45 seconds
......@@ -1040,10 +1040,14 @@ static int tps6598x_probe(struct i2c_client *client)
irq_handler = cd321x_interrupt;
} else {
ret = tps6598x_read64(tps, TPS_REG_INT_MASK1, &mask1);
if (ret)
return ret;
/* Enable power status, data status and plug event interrupts */
mask1 = TPS_REG_INT_POWER_STATUS_UPDATE |
TPS_REG_INT_DATA_STATUS_UPDATE |
TPS_REG_INT_PLUG_EVENT;
mask1 |= TPS_REG_INT_POWER_STATUS_UPDATE |
TPS_REG_INT_DATA_STATUS_UPDATE |
TPS_REG_INT_PLUG_EVENT;
}
/* Make sure the controller has application firmware running */
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment