GitLab

TODO: test the devkit cam that now uses the mainline csi drivers.

UNTESTED

Add a driver to support the i.MX8MQ MIPI CSI receiver. The hardware side
is based on
https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/media/platform/imx8/mxc-mipi-csi2_yav.c?h=imx_5.4.70_2.3.0



It's built as part of VIDEO_IMX7_CSI because that's documented to support
i.MX8M platforms. This driver adds i.MX8MQ support where currently only the
i.MX8MM platform has been supported.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>

The i.MX8MQ SoC integrates a different MIPI CSI receiver as the i.MX8MM so
describe the DT bindings for it.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>

Laurent Pinchart authored May 19, 2021 and Martin Kepplinger committed Jul 28, 2021

When the stream fails to start, the first two buffers in the queue have
been moved to the active_vb2_buf array and are returned to vb2 by
imx7_csi_dma_unsetup_vb2_buf(). The function is called with the buffer
state set to VB2_BUF_STATE_ERROR unconditionally, which is correct when
stopping the stream, but not when the start operation fails. In that
case, the state should be set to VB2_BUF_STATE_QUEUED. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Laurent Pinchart authored May 16, 2021 and Martin Kepplinger committed Jul 28, 2021

The PIXEL_BIT field of the CSICR1 register is documented as setting the
Bayer data width to 10 bits, and is set by the driver for all non-YUV
pixel formats. Test code from NXP showed that the bit shouldn't be set
for Bayer formats, and this was confirmed by experimentation with RAW8
capture (which doesn't work when setting the field) and RAW10 capture
(for which setting the field doesn't seem to make a difference) on
i.MX8MM with an OV5640 sensor connected over CSI-2. Don't set it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>

Laurent Pinchart authored May 16, 2021 and Martin Kepplinger committed Jul 28, 2021

Sample code from NXP, as well as experiments on i.MX8MM with RAW10
capture with an OV5640 sensor connected over CSI-2, showed that the
TWO_8BIT_SENSOR field of the CSICR3 register needs to be set for formats
larger than 8 bits. Do so, even if the reference manual doesn't clearly
describe the effect of the field.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Laurent Pinchart authored Feb 15, 2021 and Martin Kepplinger committed Jul 28, 2021

Add a flags argument to the v4l2_create_fwnode_links_to_pad() function
to specify the link flags. This allows drivers to create immutable links
for instance.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Elias Rudberg authored Jun 29, 2021 and Guido Gunther committed Jul 06, 2021

Since power status can change not only when
TPS_REG_INT_POWER_STATUS_UPDATE is set but also when
TPS_REG_INT_PP_SWITCH_CHANGED is set, check for power
status change also in the TPS_REG_INT_PP_SWITCH_CHANGED
case. In this way we detect power status change in some
cases where it was earlier undetected.

Fixes https://source.puri.sm/Librem5/linux-next/-/issues/250 and https://source.puri.sm/Librem5/linux-next/-/issues/291

Signed-off-by: Elias Rudberg <mail@eliasrudberg.se>

Having it at 0x0974 makes the upper half of analog gain values
act badly (best noticeable under indoor light).

Dorota Czaplejewicz authored May 01, 2021 and Sebastian Krzyszkowiak committed Jul 05, 2021

This is a hack, a proper solution is adding a custom control. Userpace hasn't caught up yet however.

It might be annoying when debugging, but then there's the override interface for this purpose already.

These cardreader devices issue a MEDIA CHANGE unit attention not only
when actually a medium changed but also simply when resuming from suspend.

Setting the BLIST_MEDIA_CHANGE flag enables using runtime pm for SD cardreaders.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>

For SD cardreader devices that have the BLIST_MEDIA_CHANGE flag set,
a MEDIA CHANGE unit attention is received after resuming from runtime
suspend. Send a REQUEST SENSE to avoid that.

The "downside" is that for these devices we now rely on users not to
really change the medium (SD card) *during* a runtime suspend/resume
cycle, i.e. when not unmounting.

To enable runtime PM for an SD cardreader (device number 0:0:0:0), do:

echo 0 > /sys/module/block/parameters/events_dfl_poll_msecs
echo 1000 > /sys/bus/scsi/devices/0:0:0:0/power/autosuspend_delay_ms
echo auto > /sys/bus/scsi/devices/0:0:0:0/power/control
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>

add a new flag for devices that issue MEDIA CHANGE unit attentions
when actually no medium changed. Drivers can then act accordingly in
case they need to work around it, i.e. in resume().
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>

This reverts commit e5943410.

This reverts commit e683024e.

CAMERA_PWR_EN controls different power supplies that cameras will use.
Describe that appropriately.

and don't call power_off() when power_on() fails.

this is a new node and status is enabled by default.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>

Digital gain registers are comprised of 13 bits. 4 bits [12:9]
control the integer portion, and 9 bits [8:0] control the decimal
portion. Therefore 256 (0x100) corresponds to ~0.5x digital gain.

This sets digital gain to 1.0x by default and limits the minimum
value to 1.0x since there's little point in having global digital
gain of less than 1.0x as its only effect is lowering picture quality
by reducing its dynamic range and white point.

Guido Gunther authored Dec 21, 2020 and Martin Kepplinger committed Jun 09, 2021

This is used on IMX and rockchip platforms
Signed-off-by: Guido Günther <agx@sigxcpu.org>

Guido Gunther authored Jun 07, 2021 and Martin Kepplinger committed Jun 09, 2021

Before enabling hantro support video playback would use software only
but once we enable hantro in the kernel gst-plugins-bad will detect it.
Since that code path is broken on unpatched gst-plugins-bad, let's add a
`Breaks:` to support partial upgrades.

according to the driver changes from
https://lore.kernel.org/linux-media/20210607105213.1211722-4-martin.kepplinger@puri.sm/T/#u

the XSHUTDOWN pin is now correctly handled as a gpio just like the RESETB line.