end-session-dialog: avoid redundant assignment

See merge request Librem5/phosh!814

lockscreen: Move player to center widget

See merge request Librem5/phosh!809

Guido Gunther authored May 05, 2021 and Guido Gunther committed May 13, 2021

This makes the player centered with the indicators and clock

See Librem5/phosh#543



Signed-off-by: Guido Günther <guido.gunther@puri.sm>

layersurface: avoid redundant assignment

See merge request Librem5/phosh!813

A couple  of resource cleanup fixes

See merge request Librem5/phosh!807

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

We don't want to be called after going away.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Seems this got copy pasted all around and should.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

We unref it on dispose so we need to take a reference.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

We shouldn't remove elements form the GList of keys while looping over
it. Fixing this makes sure we actually fee the entries (and is less
code).

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

gnome-shell-manager invokes phosh_shell_remove_global_keyboard_action_entries()
when disposing it's keybindings.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

We should clean up properly on dispose.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

We should clean up properly on dispose.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

We should clean up properly on dispose.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

We should clean up properly on dispose.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

We should clean up properly on dispose.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Don't bother if we ever acquired it, it's important if we tried
(and hence got a > 0 id).

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

The connection is independent from the signal subscription.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

This makes it consistent with other classes

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

This helps detecting bad types.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Unnoticed by the compiler since the type was unused so far.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Unused so far so the compiler didn't spot it.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Bump glib requirement to 2.62

See merge request Librem5/phosh!806

Guido Gunther authored Apr 30, 2021 and Guido Gunther committed May 06, 2021

We can rely on glib 2.62 now.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Guido Gunther authored Apr 30, 2021 and Guido Gunther committed May 06, 2021

This is in byzantium/bullseye and will allow us to use
g_clear_signal_handler() and friends.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

Add initial test for the shell object

See merge request Librem5/phosh!805

This allows us to exclude autogenerated files. It needs to go
toplevel for gcovr to find it.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

This creates a bit nicer reports but more importantly supports
a gcovr.cfg in _build/ so we can exclude autogenerated files
in the future.

This needs some hackery due to
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987818


but since this only affects this project and not e.g. downstreams
it should be o.k. for the time being.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>

The test-shell unit test basically covers this.

Signed-off-by: Guido Günther <guido.gunther@puri.sm>